Repository navigation
fix(mcp): contain synchronous run-code listener exceptions - #43708
Closed
Anirudh Sharma (anirudhqwerty) wants to merge 5 commits into
Closed
Anirudh Sharma (anirudhqwerty) wants to merge 5 commits into
Anirudh Sharma (anirudhqwerty) wants to merge 5 commits into
Conversation
Author
|
@microsoft-github-policy-service agree |
| for (const listener of this._unhandledRejectionListeners) | ||
| listener(reason); | ||
| }; | ||
| readonly runCodeListenerErrors = new ListenerErrorScope(this._onUnhandledRejection); |
Collaborator
There was a problem hiding this comment.
We don't want some extra private API between library and mcp tools.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
References #43770. Alternative to #43686 with containment scoped to callbacks created in
browser_run_code_unsafeVM contexts.oncecleanup. Weak-key registration and context disposal control the error scope's lifetime.Evidence: baseline crash reproduction, Windows verification: 19 MCP and 55 event tests, and final Linux build and full flint. Windows tested the same executable code and tests; the final source commit adds only the required test-catalog entries. Functional coverage is Chromium only; macOS and performance/heap stress were not tested.