Skip to content

feat(webkit): roll to r2387 - #43812

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2387
Oct 31, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2387

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/a09b1b7db396a253b597b55c9798bce5283d11cb. Build has full platform coverage - check that all tests pass there.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [playwright-test] › hooks.spec.ts:132 › beforeEach failure should prevent the test, but not other hooks @playwright-x64-ubuntu24-64-core-bun

23621 passed, 705 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5194 passed, 616 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Both current failures predate this PR

Hi, I'm the Playwright bot. I checked the diff, failed-job logs, and refreshed CI test history.

Details

The only change in 8efa40ec5e50 is the WebKit revision, 2386 → 2387, in browsers.json. Neither failing test uses WebKit. Both have matching failures on unrelated commits.

Pre-existing flake — Bun hook output

[playwright-test] › hooks.spec.ts:132 › beforeEach failure should prevent the test, but not other hooks fails in the Bun job. All three hooks log their messages, but a reporter line appears between beforeEach2 and afterEach, breaking the contiguous-output assertion.

The exact same test, project, Bun bot, and assertion failed on #43732 (run, ddc8b36d69f0) and #43719 (run, 31c925fe163b). Excluding this PR, the refreshed database has 406 passing and two failing runs for this test on that bot.

Pre-existing failure — Android service worker

[android-page] › page/page-goto.spec.ts:695 › NA-051 should be able to navigate to a page controlled by service worker fails on both attempts in the Android job: navigator.serviceWorker is undefined when reading controller.

The same test and error already occur on main at f0f066e95404 (run) and 256c5308d6bc (run). This Android Chrome failure is independent of the WebKit revision.

This verdict covers the latest merged tests 1 report and completed jobs in tests 2. tests 2 still has running checks; their results are not covered.

Triaged by the Playwright bot - agent run

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

1 failed
❌ [android-page] › page/page-goto.spec.ts:695 › NA-051 should be able to navigate to a page controlled by service worker

13 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@frozen-time-library-chromium-linux`
⚠️ [chromium-library] › library/webmcp.spec.ts:238 › WM-013 should call same-name tools in their own frame `@tracing-chromium`
⚠️ [chromium-library] › library/browsercontext-user-agent.spec.ts:127 › UA-006 should work for navigator.userAgentData and sec-ch-ua headers `@msedge-dev-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/inspector/cli-codegen-java.spec.ts:24 › CG-141 should print the correct imports and context options `@chrome-ubuntu-22.04`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › BU-001 should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/tracing.spec.ts:565 › TR-023 should produce screencast frames crop `@chromium-macos-15-large`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@chrome-macos-latest`
⚠️ [firefox-library] › library/defaultbrowsercontext-2.spec.ts:24 › DC-012 should support hasTouch option `@tracing-firefox`
⚠️ [firefox-library] › library/inspector/cli-codegen-aria.spec.ts:87 › CG-100 should update aria snapshot highlight `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/recorder-api.spec.ts:84 › IN-032 should double click `@firefox-macos-15-large`
⚠️ [webkit-library] › library/heap.spec.ts:304 › LE-014 cycle handles `@webkit-playwright-x64-server2025-64-core`
⚠️ [webkit-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@webkit-macos-15-xlarge`
⚠️ [webkit-library] › library/screencast.spec.ts:57 › SC-002 applies backpressure while async onFrame callback is pending `@webkit-macos-15-large`

127150 passed, 4088 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

🟢 Both CI failures predate this PR

Hi, I'm the Playwright bot. I checked the completed CI reports, failed-job logs, and refreshed test history. Neither failure looks caused by this PR.

Details

The only change in 8efa40ec5e50 is the WebKit revision, 2386 → 2387, in packages/playwright-core/browsers.json. Neither failing test uses WebKit. All WebKit jobs passed.

Pre-existing failure — Android service worker

[android-page] › page/page-goto.spec.ts:695 › NA-051 should be able to navigate to a page controlled by service worker fails on both attempts in the Android job. navigator.serviceWorker is undefined when the test reads controller.

The refreshed database shows the same test, Android bot, and error on main before this PR: f0f066e95404 and 256c5308d6bc. This is an existing Android failure, not a WebKit-roll regression.

Pre-existing flake — Bun hook output

[playwright-test] › hooks.spec.ts:132 › beforeEach failure should prevent the test, but not other hooks fails in the Bun job. All three hook messages appear, but a reporter line between beforeEach2 and afterEach breaks the contiguous-output assertion.

The exact same test, project, Bun bot, and assertion failed on #43732 (run, ddc8b36d69f0) and #43719 (run, 31c925fe163b). Excluding this PR, its history on that bot has 406 passing and 2 failing run attempts.

This covers both failures in the latest tests 1 and tests 2 reports. The 13 retry-recovered tests in tests 2 are not persistent failures.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit a294eb0 into main Oct 31, 2026
62 of 64 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the roll-into-pw-webkit/2387 branch October 31, 2026 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant