Repository navigation
fix(route): wait for all active handlers before disabling interception - #43889
Conversation
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Test results for "tests 1"2 failed 1 flaky23577 passed, 704 skipped Merge workflow run. |
🟢 Both failures predate this PRHi, I'm the Playwright bot. I checked the CI failures for DetailsNeither failure looks caused by this PR. Both come from the same VS Code extension output assertion, not the request-interception cleanup changed here. Pre-existing flake / infra
The same test and warning failed before this PR's run, on unrelated commits:
The current failures have that same signature. The warning comes from the unchanged Git metadata plugin's three-second fetch limit; this PR changes only page/context route-handler cleanup and its regression tests. All six updated regression cases passed across Chromium, Firefox, and WebKit. I refreshed and queried the aggregated test-results database. It contains no VS Code extension results, so the historical matches above are verified from the job logs. The report's Chromium worker test passed on retry and is not an outstanding failure. CI failures checked by the Playwright bot - agent run Triaged by the Playwright bot - agent run |
Avoid disabling interception from a completed handler after
unrouteAll()has replaced the route list. Its own interception update must run after all removed handlers finish; otherwise the first completion sends other active requests to the network.Extend the existing page and context regression tests to cover two concurrent requests and assert both mocked responses. All six cases fail without the fix and pass with it. Build and flint pass; the related routing suites pass on Chromium, Firefox and WebKit (325 passed, 8 existing skips).
Fixes #43878
Triaged on Linux by the Playwright bot - agent run