Skip to content

fix(route): wait for all active handlers before disabling interception - #43889

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
triage/43878/41702544263-1
Nov 3, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
triage/43878/41702544263-1

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Avoid disabling interception from a completed handler after unrouteAll() has replaced the route list. Its own interception update must run after all removed handlers finish; otherwise the first completion sends other active requests to the network.

Extend the existing page and context regression tests to cover two concurrent requests and assert both mocked responses. All six cases fail without the fix and pass with it. Build and flint pass; the related routing suites pass on Chromium, Firefox and WebKit (325 passed, 8 existing skips).

Fixes #43878

Triaged on Linux by the Playwright bot - agent run

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5194 passed, 616 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

2 failed
❌ [default] › run-tests.spec.ts:1041 › should produce output twice @vscode-extension
❌ [default-trace] › run-tests.spec.ts:1041 › should produce output twice @vscode-extension

1 flaky ⚠️ [chromium-library] › library/chromium/connect-to-worker.spec.ts:19 › CR-043 should connect, evaluate, receive console and disconnect `@chromium-playwright-x64-ubuntu24-64-core-node22`

23577 passed, 704 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

🟢 Both failures predate this PR

Hi, I'm the Playwright bot. I checked the CI failures for fb60a24 against the PR diff and earlier runs.

Details

Neither failure looks caused by this PR. Both come from the same VS Code extension output assertion, not the request-interception cleanup changed here.

Pre-existing flake / infra

[default] and [default-trace] › run-tests.spec.ts:1041 › should produce output twice fail because an extra GitCommitInfo: timeout … git fetch origin … warning appears in the output. The nested test passes; the exact-output assertion rejects the warning.

The same test and warning failed before this PR's run, on unrelated commits:

The current failures have that same signature. The warning comes from the unchanged Git metadata plugin's three-second fetch limit; this PR changes only page/context route-handler cleanup and its regression tests. All six updated regression cases passed across Chromium, Firefox, and WebKit.

I refreshed and queried the aggregated test-results database. It contains no VS Code extension results, so the historical matches above are verified from the job logs. The report's Chromium worker test passed on retry and is not an outstanding failure.

CI failures checked by the Playwright bot - agent run

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) marked this pull request as ready for review November 3, 2026 21:43
@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit d745ae0 into main Nov 3, 2026
30 of 31 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the triage/43878/41702544263-1 branch November 3, 2026 22:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: unrouteAll({ behavior: 'wait' }) sends other in-flight routes to the network when the first handler finishes

2 participants