Repository navigation
fix(trace-viewer): reject unsafe snapshot attribute names - #43911
Merged
Yury Semikhatsky (yury-s) merged 5 commits intoNov 5, 2026
Merged
Yury Semikhatsky (yury-s) merged 5 commits into
Yury Semikhatsky (yury-s) merged 5 commits into
Conversation
Attribute names were written into the snapshot HTML without escaping. A crafted trace could use a name such as " onerror" to bypass the event handler filter, or smuggle extra attributes after a space. Drop names that contain whitespace, =, <, >, / or quotes, the same rule that already applies to tag names.
Escaping and name validation now live in one class, so no raw string from the trace reaches the HTML without going through it.
This comment has been minimized.
This comment has been minimized.
Pavel Feldman (pavelfeldman)
approved these changes
Nov 5, 2026
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "MCP"5194 passed, 616 skipped Merge workflow run. |
Contributor
Test results for "tests 1"23586 passed, 704 skipped Merge workflow run. |
This was referenced Nov 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
" onerror"to bypass theon*filter, or smuggle extra attributes after a space.=,<,>,/or quotes, the same rule that already applies to tag names since fix(trace-viewer): reject unsafe snapshot tag names #42712.Source - ICM