Skip to content

feat(webkit): roll to r2389 - #43913

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2389
Nov 5, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
mainfrom
roll-into-pw-webkit/2389

Conversation

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

Browser build: https://github.com/microsoft/playwright-browsers/commit/ea1b667b6d7dcc8d8b4702b02cba7a74ccc70948. Build has full platform coverage - check that all tests pass there.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 flaky ⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-playwright-x64-ubuntu24-64-core-node22`

23585 passed, 704 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5194 passed, 616 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

Test results for "tests 2"

7 failed
❌ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › CG-157 should not print context options method override in nunit if no options were passed @firefox-macos-15-large
❌ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › CG-158 should print context options method override in nunit if options were passed @firefox-macos-15-large
❌ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:202 › CG-157 should not print context options method override in mstest if no options were passed @firefox-macos-15-large
❌ [firefox-library] › library/inspector/cli-codegen-javascript.spec.ts:51 › CG-107 should work with --http-credentials @firefox-macos-15-large
❌ [firefox-library] › library/inspector/cli-codegen-pytest.spec.ts:49 › CG-138 should save the codegen output to a file if specified @firefox-macos-15-large
❌ [firefox-library] › library/inspector/cli-codegen-python-async.spec.ts:80 › CG-132 should save the codegen output to a file if specified @firefox-macos-15-large
❌ [firefox-library] › library/inspector/cli-codegen-python.spec.ts:76 › CG-124 should save the codegen output to a file if specified @firefox-macos-15-large

21 flaky ⚠️ [chromium-library] › library/popup.spec.ts:279 › PO-028 should not throw when click closes popup `@tracing-chromium`
⚠️ [chromium-library] › library/video.spec.ts:690 › screencast › VI-028 should capture full viewport `@tracing-chromium`
⚠️ [chromium-library] › library/browsercontext-user-agent.spec.ts:127 › UA-006 should work for navigator.userAgentData and sec-ch-ua headers `@msedge-dev-playwright-x64-server2025-64-core`
⚠️ [chromium-library] › library/beforeunload.spec.ts:20 › BU-001 should close browser with beforeunload page `@chromium-macos-15-large`
⚠️ [chromium-library] › library/browsercontext-basic.spec.ts:36 › BC-002 should be able to click across browser contexts `@chromium-macos-15-large`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1717 › TV-077 should highlight locator in iframe while typing `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@chromium-macos-15-xlarge`
⚠️ [chromium-library] › library/webmcp.spec.ts:216 › WM-012 should scope tools to their frame `@realtime-time-library-chromium-linux`
⚠️ [chromium-library] › library/har.spec.ts:109 › HA-006 should populate entry startedDateTime from the browser `@chrome-macos-latest`
⚠️ [chromium-library] › library/trace-viewer.spec.ts:1937 › TV-087 should not leak recorders `@chrome-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:152 › screencast › VI-005 should continue recording main page after popup closes `@chrome-macos-latest`
⚠️ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace `@chromium-ubuntu-22.04-arm-node22`
⚠️ [chromium-library] › library/webmcp.spec.ts:216 › WM-012 should scope tools to their frame `@chromium-ubuntu-22.04-arm-node22`
⚠️ [firefox-library] › library/browsercontext-reuse.spec.ts:261 › reuse launch › BC-077 should ignore binding from beforeunload `@tracing-firefox`
⚠️ [firefox-library] › library/inspector/cli-codegen-csharp.spec.ts:208 › CG-158 should print context options method override in mstest if options were passed `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-java.spec.ts:125 › CG-149 should print a valid basic program in junit `@firefox-macos-15-large`
⚠️ [firefox-library] › library/inspector/cli-codegen-javascript.spec.ts:104 › CG-110 should save the codegen output to a file if specified `@firefox-macos-15-large`
⚠️ [firefox-library] › library/multiclient.spec.ts:446 › MC-020 should run locator handlers after reconnecting with a pending callback `@firefox-macos-15-large`
⚠️ [firefox-library] › library/browsercontext-basic.spec.ts:170 › BC-007 should make a copy of default viewport `@firefox-macos-15-xlarge`
⚠️ [firefox-library] › library/defaultbrowsercontext-1.spec.ts:89 › DC-004 should support viewport option `@firefox-macos-15-xlarge`
⚠️ [webkit-library] › library/heap.spec.ts:304 › LE-014 cycle handles `@webkit-playwright-x64-server2025-64-core`

121975 passed, 3944 skipped


Merge workflow run.

@github-actions

github-actions Bot commented Nov 5, 2026

Copy link
Copy Markdown
Contributor

🟢 CI failures look unrelated to this PR

Hi, I'm the Playwright bot. I checked the failed jobs against the PR changes and refreshed the CI test history.

Details

The latest merged report lists seven failed tests, all in Firefox code generation. This PR (f7919ec) only updates WebKit from revision 2388 to 2389; it does not change Firefox, code generation, or the test fixtures.

Pre-existing flakes — all seven Firefox failures

All seven time out after 30 seconds waiting for generated navigation code. The CI database records the same tests with the same missing-navigation failure on older commits, on the same firefox-macos-15-large runner.

All tests below use project firefox-library; paths are relative to library/inspector/.

Test Earlier failure outside this PR
cli-codegen-csharp.spec.ts:202 — CG-157, NUnit, no options main 3b3ac25, Nov 1; passed on retry
cli-codegen-csharp.spec.ts:208 — CG-158, NUnit, with options main 4773e9a, Nov 3; passed on retry
cli-codegen-csharp.spec.ts:202 — CG-157, MSTest, no options main 7542bfb, Nov 2; passed on retry
cli-codegen-javascript.spec.ts:51 — CG-107, --http-credentials main 820620c, Nov 2; failed all four attempts
cli-codegen-pytest.spec.ts:49 — CG-138, save output main 0ea3691, Nov 3; passed on retry
cli-codegen-python-async.spec.ts:80 — CG-132, save output main 86e6924, Nov 3; passed on retry
cli-codegen-python.spec.ts:76 — CG-124, save output main deb7e86, Oct 31; passed on retry

Infrastructure interruption — macOS Intel WebKit

The WebKit job has a runner-level failure annotation: “The hosted runner lost communication with the server.” It uploaded no test results, so this is not a reported WebKit test regression. The cause of the disconnection is not established; rerun this job to complete macOS Intel WebKit coverage.

Triaged by the Playwright bot - agent run

@pavelfeldman
Pavel Feldman (pavelfeldman) merged commit d1518e3 into main Nov 5, 2026
62 of 64 checks passed
@pavelfeldman
Pavel Feldman (pavelfeldman) deleted the roll-into-pw-webkit/2389 branch November 5, 2026 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant