Repository navigation
test(extension): run extension tests headless - #44048
Closed
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Closed
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Pavel Feldman (pavelfeldman) wants to merge 1 commit into
Conversation
Pavel Feldman (pavelfeldman)
force-pushed
the
extension-tests-headless
branch
from
November 11, 2026 01:16
6921b6a to
1fed37a
Compare
This comment has been minimized.
This comment has been minimized.
| const executablePath = path.join(dir, 'browser.sh'); | ||
| const requestsFile = path.join(dir, 'requests.txt'); | ||
| await fs.writeFile(requestsFile, ''); | ||
| await fs.writeFile(executablePath, `#!/bin/bash\necho "$@" >> "${requestsFile}"\n`, { mode: 0o755 }); |
There was a problem hiding this comment.
use playwright to drive the browser
The relay opens the connect page by starting the browser executable and relies on the running browser to take the URL over, which needs a headed browser. With PWTEST_EXTENSION_PRINT_CONNECT_URL the relay prints the URL to stderr instead, and the tests open it in their own browser with openConnectPage(). The browser runs headless, the tests run in parallel, and the CI job moves to ubuntu-latest.
Pavel Feldman (pavelfeldman)
force-pushed
the
extension-tests-headless
branch
from
November 11, 2026 01:45
1fed37a to
5b66012
Compare
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Contributor
Test results for "tests 1"1 flaky23618 passed, 713 skipped Merge workflow run. |
Contributor
Test results for "MCP"5229 passed, 637 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
PWTEST_EXTENSION_PRINT_CONNECT_URL, the relay prints the connect page URL to stderr instead of starting the browser executable. The tests open that URL in their own browser withopenConnectPage(), so the browser runs headless.ubuntu-latest.