Skip to content

fix(docker): upgrade base image packages during the build - #44059

Merged
Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom
yury-s:fix-44055
Nov 11, 2026
Merged

Yury Semikhatsky (yury-s) merged 2 commits into
microsoft:mainfrom
yury-s:fix-44055

Conversation

@yury-s

@yury-s Yury Semikhatsky (yury-s) commented Nov 11, 2026 •

Copy link
Copy Markdown
Member

Summary

  • Run apt-get upgrade right after apt-get update in the jammy, noble and resolute images, so that they get security fixes that the ubuntu base image does not have yet (apt CVE-2026-109518 today).

References #44055

Yury Semikhatsky (yury-s) added a commit to microsoft/playwright-mcp that referenced this pull request Nov 11, 2026
## Summary
- Run `apt-get update` and `apt-get upgrade` before `install-deps`, so
that the image gets security fixes that the `node:lts-slim` base image
does not have yet.
- Pass `-o Acquire::Retries=0`, the mitigation from the [Ubuntu
advisory](https://ubuntu.com/blog/apt-vulnerability-fixes-available),
because the old apt downloads its own fix.
- Same change as microsoft/playwright#44059.

References microsoft/playwright#44055
@github-actions

This comment has been minimized.

@github-actions

This comment has been minimized.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟡 Failures appear unrelated; prior occurrences not confirmed

Hi, I'm the Playwright bot. I checked the six failures in tests 1, run 43063966253.

Details

At head add103352, this PR changes only the three Dockerfiles. The failed VSCode Extension job runs directly on ubuntu-latest and does not build or use those images. No failure is explained by the diff.

Uncertain

  • run-tests.spec.ts:1298 — should start webServer, in default, default-reuse and default-trace: the inner test reports failed instead of passed, but the log does not include its underlying error.
  • run-tests.spec.ts:1329 — should start webServer with npx command, in the same three projects: all three fail with EADDRINUSE: address already in use :::42130. Both tests use the same port for a given worker, which points to a port conflict, not a Docker build failure.

I found no matching failures in the 20 recent completed main runs checked, or in the recent failed run of #44058. The test-history database refresh was unavailable because this run has no GITHUB_TOKEN. Without an occurrence outside this PR, I cannot confirm either test as a pre-existing flake. The first test also needs its inner error to establish whether the two failures share a cause.

The reported video test passed on retry and is not one of the six failures.

Checked the failures on Linux by the Playwright bot - agent run

@yury-s
Yury Semikhatsky (yury-s) merged commit c9b4632 into microsoft:main Nov 11, 2026
30 checks passed
@yury-s
Yury Semikhatsky (yury-s) deleted the fix-44055 branch November 11, 2026 18:23
@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 flaky ⚠️ [webkit-library] › library/trace-viewer.spec.ts:616 › TV-029 should show font preview `@webkit-playwright-x64-ubuntu24-64-core-node22`

23627 passed, 713 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

5229 passed, 637 skipped


Merge workflow run.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants