Skip to content

feat(cli): detach --close-tabs for extension sessions - #44084

Merged
Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:detach-close-tabs
Nov 12, 2026
Merged

Pavel Feldman (pavelfeldman) merged 1 commit into
microsoft:mainfrom
pavelfeldman:detach-close-tabs

Conversation

@pavelfeldman

Copy link
Copy Markdown
Member

Summary

  • playwright-cli detach --close-tabs closes the tabs of a session attached with --extension before it detaches, so no gray tab group stays. Without the option, the tabs stay open as before.
  • The playwright-cli skill now documents attach through the extension: browser name, --session as the tab group title, --session-color, and the two ways to detach.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/crash.spec.ts:31 › crash recovery › reports the navigation error, then resets and logs the crash @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:58 › crash recovery › lists only one tab @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:79 › crash recovery › marks non-current crashed tab in the tab list @mcp-ubuntu-latest-chrome

5232 passed, 631 skipped


Merge workflow run.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 All three failures are pre-existing

Hi, I'm the Playwright bot. I checked the failures: the same three tests fail with the same errors on main, without this PR's changes.

Details

Covers MCP run 43314158708 at 2665c0a423c4efd7d3f24025e532b825b6480190, as reported in the merged test report.

The changes affect CLI detach handling, extension tests and documentation. These crash tests start the MCP server directly, not the CLI daemon, and never call detach --close-tabs.

Pre-existing flake / infra

All three failures also occur in the Chrome job on main, at 8882d1c85ef808500d99a2e28778e544c8a77fef, before this PR's run:

  • mcp/crash.spec.ts:31 — reports the navigation error, then resets and logs the crash: the same 30-second timeout at toPass() while waiting for crash recovery.
  • mcp/crash.spec.ts:58 — lists only one tab: the same 30-second timeout and Error: Not connected at the subsequent browser_tabs call.
  • mcp/crash.spec.ts:79 — marks non-current crashed tab in the tab list: the same 30-second timeout and Error: Not connected at the subsequent browser_tabs call.

This proves the failures predate the PR; it does not establish whether they are intermittent. No fix in this PR is indicated.

Checked the failures on Linux by the Playwright bot - agent run

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants