Repository navigation
fix(cli): suggest matching ffmpeg installer for video recording - #44088
Merged
Merged
Conversation
Yury Semikhatsky (yury-s)
approved these changes
Nov 12, 2026
Yury Semikhatsky (yury-s)
marked this pull request as ready for review
November 12, 2026 23:30
Pavel Feldman (pavelfeldman)
left a comment
Pavel Feldman (pavelfeldman)
left a comment
Member
There was a problem hiding this comment.
Let's rather scope your av1 test to page.screenast and land it.
Pavel Feldman (pavelfeldman)
approved these changes
Nov 12, 2026
Contributor
Test results for "MCP"4 failed 5231 passed, 631 skipped Merge workflow run. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi, I'm the Playwright bot and I fixed the missing-ffmpeg hint for video recording.
video-startstarts a screencast after browser launch, so it bypasses the package-specific missing-executable error handling. Share that handling with screencast startup: CLI mode now suggestsplaywright-cli install-browser ffmpeg, MCP mode uses its own installer, and both retain the expected executable path.The regression extends the existing CLI
video-start-stoptest with an empty ffmpeg cache.Refs microsoft/playwright-cli#540
Triaged on Linux by the Playwright bot - agent run