Skip to content

Revert "fix(chromium): pass deep evaluation arguments outside protocol JSON" - #44108

Merged
Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
revert-44069-fix-44060-43119820010-1
Nov 14, 2026
Merged

Dmitry Gozman (dgozman) merged 1 commit into
mainfrom
revert-44069-fix-44060-43119820010-1

Conversation

@dgozman

Copy link
Copy Markdown
Collaborator

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "MCP"

3 failed
❌ [chrome] › mcp/crash.spec.ts:31 › crash recovery › reports the navigation error, then resets and logs the crash @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:58 › crash recovery › lists only one tab @mcp-ubuntu-latest-chrome
❌ [chrome] › mcp/crash.spec.ts:79 › crash recovery › marks non-current crashed tab in the tab list @mcp-ubuntu-latest-chrome

5232 passed, 631 skipped


Merge workflow run.

@github-actions

Copy link
Copy Markdown
Contributor

Test results for "tests 1"

1 failed
❌ [chromium-library] › library/video.spec.ts:762 › screencast › VI-030 should work with video+trace @chromium-playwright-x64-ubuntu24-64-core-node22

1 flaky ⚠️ [playwright-test] › ui-mode-trace.spec.ts:741 › should be able to create and dispose APIRequestContext inside Promise.all `@playwright-x64-server2025-64-core-node22`

23636 passed, 716 skipped


Merge workflow run.

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 All three failures predate this PR

Hi, I'm the Playwright bot. I checked the failed MCP run; this PR did not introduce these failures.

Details

Covers MCP run 43513888339 for head 09f980fbafa1.

Pre-existing flake / infra

All three [chrome] failures also occur in the Linux Chrome job on main, at this PR's exact base commit, 0ad21f1d34e4, before the revert:

  • mcp/crash.spec.ts:31 — reports the navigation error, then resets and logs the crash: 30-second timeout at the crash-reset check, line 48.
  • mcp/crash.spec.ts:58 — lists only one tab: 30-second timeout and Not connected at browser_tabs, line 71.
  • mcp/crash.spec.ts:79 — marks non-current crashed tab in the tab list: 30-second timeout and Not connected at browser_tabs, line 93.

The errors and failure locations match the PR run. The test-history database also records each test failing in 50 of 51 independent Linux Chrome runs since November 6. These are persistent pre-existing crash-recovery failures, not evidence against the serialization revert. No fix is proposed here.

Checked the failures on Linux by the Playwright bot - agent run

@microsoft-playwright-automation

Copy link
Copy Markdown
Contributor

🟢 The video failure is a pre-existing flake

Hi, I'm the Playwright bot. The only failed test in this tests 1 run also flaked before this PR.

Details

Covers tests 1 run 43513888264 at head 09f980fbafa1.

Pre-existing flake / infra

  • [chromium-library] library/video.spec.ts:762 — screencast › VI-030 should work with video+trace: the exact same test passed on retry in the earlier reports for #44090 and #44098, both on chromium-playwright-x64-ubuntu24-64-core-node22. These reports predate this revert. The PR changes evaluation argument transport, not video or trace frame handling; this test does not pass deeply nested evaluation arguments.

The UI-mode test passed on retry, so it is not an outstanding failure. The MCP failures already have a separate verdict.

Full error logs and the test-history database were unavailable, so this verdict uses the public merged reports; I could not compare the exact error messages. No fix is proposed.

Checked the failures on Linux by the Playwright bot - agent run

@dgozman
Dmitry Gozman (dgozman) merged commit b4d016a into main Nov 14, 2026
29 of 31 checks passed
@dgozman
Dmitry Gozman (dgozman) deleted the revert-44069-fix-44060-43119820010-1 branch November 14, 2026 12:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants