Skip to content

[CodeQL] Patch fmt/core.h, folly/ConstexprMath.h, and loadBundleFromServer.js - #13281

Merged
Marlene Cota (marlenecota) merged 6 commits into
microsoft:mainfrom
marlenecota:codeql-fmt
May 29, 2024
Merged

Marlene Cota (marlenecota) merged 6 commits into
microsoft:mainfrom
marlenecota:codeql-fmt

Conversation

@marlenecota

@marlenecota Marlene Cota (marlenecota) commented May 29, 2024 •

Copy link
Copy Markdown
Contributor

Description

Patching fmt CodeQL issues until upstream fix is published and we can consume it. #12702, #12703, #12704

Type of Change

Fmt, folly, and upstream patches

Why

We don't know when fmt will publish next.

What

Fixed fmt patching. Forked fmt/core.h, folly/ConstexprMath.h and loadBundleFromServer.js with fixes.

Testing

Confirmed node_modules fmt core.h version gets overwritten by the one in TEMP_UntilFollyUpdate on build

Changelog

Should this change be included in the release notes: no

Microsoft Reviewers: Open in CodeFlow

@marlenecota
Marlene Cota (marlenecota) requested a review from a team as a code owner May 29, 2024 19:20
@marlenecota
Marlene Cota (marlenecota) enabled auto-merge (squash) May 29, 2024 19:55
@marlenecota
Marlene Cota (marlenecota) requested a review from a team as a code owner May 29, 2024 20:04
@marlenecota Marlene Cota (marlenecota) changed the title Patch fmt and folly files with CodeQL fixes [CodeQL] Patch fmt/core.h, folly/ConstexprMath.h, and loadBundleFromServer.js May 29, 2024
} else {
// [Windows #12704 - CodeQL patch]
// eslint-disable-next-line no-eval
eval(body); // CodeQL [js/eval-usage] Debug only. Developer inner loop.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we have a PR to get this upstreamed?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, it's linked in #12704

@marlenecota
Marlene Cota (marlenecota) merged commit b06795e into microsoft:main May 29, 2024
@marlenecota
Marlene Cota (marlenecota) deleted the codeql-fmt branch May 29, 2024 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants