Skip to content

Integrate React Native 0.88.0-nightly-20260805-f2188610c (Aug 5th) - #16469

Merged
anuagragith merged 22 commits into
microsoft:mainfrom
anuagragith:integrate/nightly-20260805-v2
Oct 13, 2026
Merged

anuagragith merged 22 commits into
microsoft:mainfrom
anuagragith:integrate/nightly-20260805-v2

Conversation

@anuagragith

@anuagragith anuagragith commented Oct 7, 2026 •

Copy link
Copy Markdown
Contributor

Description

Integrates React Native Windows to RN nightly 0.88.0-nightly-20260805-f2188610c, bumping from the previous integration at 0.87.0-nightly-20260704-e04ff69ab (July 4th).

Changes

  • Updated react-native and related dependencies to 0.88.0-nightly-20260805-f2188610c.
  • Resolved merge conflicts introduced by upstream changes between the two nightly versions.
  • Fixed packages/playground/metro.config.js: RN 0.88 introduced self-referencing subpath imports (e.g. react-native/react-private-interface) that are only resolvable via the package's package.json exports map. The previous dev-package redirect logic used the raw subpath, which created a second, inconsistent module instance of ReactNativeViewConfigRegistry and caused an RCTText "view config not found" invariant violation on RNTester startup. Added resolveExportsSubpath() to resolve the subpath through exports first, falling back to the literal subpath, ensuring a single consistent module instance.

Validation

  • Playground/RNTester builds and deploys successfully.
  • Manually validated RNTester: loads cleanly, components list and text render correctly, no redbox/invariant errors (previously reproduced the RCTText crash before the metro.config.js fix; confirmed fixed after).
  • Investigated a separate RNCPicker "view config not found" error: confirmed via an A/B test (same binary, Metro serving baseline RN 0.87 vs. this integration's RN 0.88 JS) that it reproduces identically on both versions. This is a pre-existing limitation (Picker's legacy native Windows ViewManager has never been implemented for composition, and the package is explicitly excluded from Windows autolinking since Fix/playground composition build #16199) — not a regression introduced by this integration, and is out of scope for this change.
Microsoft Reviewers: Open in CodeFlow

Anukrati Agrawal and others added 3 commits October 5, 2026 23:23
…ts and update dependencies

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
- NetworkIOAgent.cpp: remove stale InspectorFlags::getNetworkInspectionEnabled()
  gate around Network.enable (upstream fully removed this flag; matches
  f2188610c), and fix networkHandler scoping bug this exposed.
- ImageComponentView.cpp: adapt to upstream ImageProps::tintColor becoming
  std::optional<SharedColor> (was SharedColor); unwrap via value_or(SharedColor{})
  before use, matching the android platform's pre-optional fallback pattern.
- Shared.vcxitems: add missing ClCompile entries for ErrorUtils.cpp and
  LayoutEventEmitter.cpp, two new upstream source files not yet wired into
  the Windows build, causing LNK2019/LNK2001 unresolved externals for
  handleJSError and LayoutEventEmitter::shadowTreeDidCommit.

Verified via full MSBuild of playground-composition.sln
(playground-composition_Package, Debug/x64) - 0 errors.
RN 0.88 introduced 'self-referencing' subpath imports (e.g. react-native/react-private-interface) that are only valid via the package's package.json exports map, and don't correspond to a literal file at that subpath. tryResolveDevAbsoluteImport() previously redirected such imports into the dev package (src-win) using the raw subpath, creating a second, inconsistent module instance for files like ReactNativeViewConfigRegistry. This caused an RCTText view-config invariant violation on RNTester startup, since the core RN code and the dev-package-redirected code resolved to different module instances with separate registries.

Fix: resolve the subpath through the package's 'exports' map first (resolveExportsSubpath), falling back to the literal subpath if no export entry matches, so the dev-package redirect targets the real file and a single consistent module instance is used throughout.

Verified: RNTester now loads without the RCTText invariant violation on the RN 0.88 nightly integration.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
Copilot AI balanced review requested due to automatic review settings October 7, 2026 01:38
@anuagragith
anuagragith requested review from a team as code owners October 7, 2026 01:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

Windows Flow checking is unintentionally disabled for platform files, and new RNTester entries reference content that was not integrated.

Review effort: Balanced
Findings: 2 High severity · 2 Medium severity

Open (4)
What changed in this PR

Integrates React Native nightly 0.88.0-nightly-20260805-f2188610c into Windows and Win32, updating platform overrides, native sources, tooling, and RNTester content.

Changes:

  • Bumps React Native, Metro, Flow, TypeScript, and related dependencies.
  • Reconciles Windows/Win32 JavaScript, type, and ReactCommon overrides.
  • Adds Metro export-map resolution and new RNTester scenarios.
File Description
vnext/​src-win/​Libraries/​Utilities/​PlatformTypes.js Syncs Flow formatting.
vnext/​src-win/​Libraries/​Text/​Text.d.ts Syncs text declarations.
vnext/​src-win/​Libraries/​Pressability/​HoverState.js Updates formatting.
vnext/​src-win/​Libraries/​Modal/​Modal.windows.js Syncs modal types.
vnext/​src-win/​Libraries/​Modal/​Modal.d.ts Syncs modal declarations.
vnext/​src-win/​Libraries/​Image/​resolveAssetSource.windows.js Uses private asset registry.
vnext/​src-win/​Libraries/​Image/​Image.windows.js Integrates new Image implementation.
vnext/​src-win/​Libraries/​Image/​AssetSourceResolver.windows.js Updates asset APIs.
vnext/​src-win/​Libraries/​Components/​View/​ViewPropTypes.d.ts Syncs view declarations.
vnext/​src-win/​Libraries/​Components/​View/​ViewAccessibility.d.ts Adds upstream accessibility type.
vnext/​src-win/​Libraries/​Components/​Touchable/​TouchableWithoutFeedback.windows.js Syncs Flow formatting.
vnext/​src-win/​Libraries/​Components/​Touchable/​TouchableNativeFeedback.windows.js Syncs Flow formatting.
vnext/​src-win/​Libraries/​Components/​Touchable/​Touchable.windows.js Updates formatting.
vnext/​src-win/​Libraries/​Components/​TextInput/​TextInput.windows.js Updates cleanup ordering.
vnext/​src-win/​Libraries/​Components/​TextInput/​TextInput.flow.windows.js Syncs Flow types.
vnext/​src-win/​Libraries/​Components/​ScrollView/​ScrollView.windows.js Syncs ScrollView types.
vnext/​src-win/​Libraries/​Components/​Pressable/​Pressable.windows.js Syncs Pressable types.
vnext/​src-win/​Libraries/​Components/​Pressable/​Pressable.d.ts Syncs declarations.
vnext/​src-win/​Libraries/​Components/​AccessibilityInfo/​AccessibilityInfo.windows.js Syncs event types.
vnext/​src-win/​Libraries/​Alert/​Alert.windows.js Syncs alert types.
vnext/​src-win/​index.windows.js.flow Updates public Flow exports.
vnext/​src-win/​index.windows.js Updates runtime exports and deprecations.
vnext/​Shared/​Shared.vcxitems Compiles new upstream native sources.
vnext/​ReactCopies/​IntegrationTests/​IntegrationTestsApp.js Uses new environment setup entrypoint.
vnext/​ReactCommon/​TEMP_UntilReactCommonUpdate/​react/​runtime/​ReactInstance.cpp Syncs runtime error handling.
vnext/​ReactCommon/​TEMP_UntilReactCommonUpdate/​react/​renderer/​uimanager/​UIManager.cpp Integrates UIManager changes.
vnext/​ReactCommon/​TEMP_UntilReactCommonUpdate/​react/​renderer/​components/​view/​BaseViewProps.cpp Syncs view prop parsing.
vnext/​ReactCommon/​TEMP_UntilReactCommonUpdate/​react/​renderer/​components/​text/​BaseParagraphProps.cpp Syncs paragraph prop parsing.
vnext/​ReactCommon/​TEMP_UntilReactCommonUpdate/​react/​nativemodule/​dom/​NativeDOM.cpp Preserves nested root parent traversal.
vnext/​ReactCommon/​TEMP_UntilReactCommonUpdate/​jsinspector-modern/​NetworkIOAgent.cpp Syncs network inspection dispatch.
vnext/​ReactCommon/​TEMP_UntilReactCommonUpdate/​jsiexecutor/​jsireact/​JSIExecutor.cpp Updates error-handler include.
vnext/​package.json Bumps RN and toolchain dependencies.
vnext/​overrides.json Advances override baselines and hashes.
vnext/​Microsoft.ReactNative/​Fabric/​Composition/​ImageComponentView.cpp Handles optional image tint colors.
vnext/​.flowconfig Updates Flow configuration.
packages/​sample-custom-component/​package.json Bumps RN and TypeScript.
packages/​sample-app-fabric/​package.json Bumps RN and TypeScript.
packages/​react-native-windows-init/​package.json Bumps RN and TypeScript.
packages/​react-native-platform-override/​package.json Bumps TypeScript.
packages/​playground/​package.json Bumps RN and TypeScript.
packages/​playground/​metro.config.js Resolves package export subpaths.
packages/​e2e-test-app-fabric/​package.json Bumps RN and TypeScript.
packages/​debug-test/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​warm-feed/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​unbroken/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​ts-config/​tsconfig.json Maps generated RN types.
packages/​@rnw-scripts/​take-screenshot/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​stamp-version/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​promote-release/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​prepare-release/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​metro-dev-config/​package.json Bumps RN and TypeScript.
packages/​@rnw-scripts/​just-task/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​integrate-rn/​package.json Bumps RN and TypeScript.
packages/​@rnw-scripts/​format-files/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​fork-sync/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​eslint-config/​package.json Bumps RN lint tooling.
packages/​@rnw-scripts/​doxysaurus/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​create-github-releases/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​beachball-config/​package.json Bumps TypeScript.
packages/​@rnw-scripts/​babel-react-native-config/​package.json Bumps RN Babel preset.
packages/​@react-native/​tester/​package.json Advances RNTester nightly.
packages/​@react-native/​tester/​overrides.json Updates RNTester baselines.
packages/​@react-native/​tester/​js/​utils/​RNTesterList.ios.js Registers new iOS examples.
packages/​@react-native/​tester/​js/​utils/​RNTesterList.android.js Registers ScrollView example.
packages/​@react-native/​tester/​js/​examples/​WebSocket/​websocket_test_server.js Updates Node imports and asset path.
packages/​@react-native/​tester/​js/​examples/​WebSocket/​http_test_server.js Uses explicit Node import.
packages/​@react-native/​tester/​js/​examples/​Text/​TextSharedExamples.js Adds text clipping scenario.
packages/​@react-native/​tester/​js/​examples/​ScrollView/​ScrollViewMaintainVisibleContentPositionExample.js Adds ScrollView scenario.
packages/​@react-native/​tester/​js/​examples/​KeyboardAvoidingView/​KeyboardAvoidingViewExample.js Syncs Flow formatting.
packages/​@react-native/​tester/​js/​examples/​Image/​ImageExample.js Adds percentage radius example.
packages/​@react-native/​tester/​js/​examples/​FlatList/​FlatList-maintainVisibleContentPosition.js Expands FlatList scenario.
packages/​@react-native/​tester/​js/​examples/​Experimental/​PlatformTest/​RNTesterPlatformTestTypes.js Syncs Flow formatting.
packages/​@react-native/​monorepo/​package.json Syncs upstream monorepo metadata.
packages/​@react-native/​monorepo/​overrides.json Advances monorepo baseline.
packages/​@react-native-windows/​tester/​src/​js/​utils/​RNTesterList.windows.js Registers ScrollView example.
packages/​@react-native-windows/​tester/​src/​js/​examples/​Text/​TextSharedExamples.windows.js Adds Windows text clipping scenario.
packages/​@react-native-windows/​tester/​src/​js/​examples/​Image/​ImageExample.windows.js Adds Windows radius example.
packages/​@react-native-windows/​tester/​package.json Bumps RNTester dependencies.
packages/​@react-native-windows/​tester/​overrides.json Updates Windows tester baselines.
packages/​@react-native-windows/​telemetry/​package.json Bumps TypeScript.
packages/​@react-native-windows/​perf-testing/​package.json Bumps RN and TypeScript.
packages/​@react-native-windows/​package-utils/​package.json Bumps TypeScript.
packages/​@react-native-windows/​fs/​package.json Bumps TypeScript.
packages/​@react-native-windows/​find-repo-root/​package.json Bumps TypeScript.
packages/​@react-native-windows/​find-dotnet-tools/​package.json Bumps TypeScript.
packages/​@react-native-windows/​codegen/​package.json Bumps TypeScript.
packages/​@react-native-windows/​cli/​package.json Bumps RN and TypeScript.
packages/​@react-native-windows/​automation/​package.json Bumps TypeScript.
packages/​@react-native-windows/​automation-commands/​package.json Bumps TypeScript.
packages/​@react-native-windows/​automation-channel/​package.json Bumps RN and TypeScript.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Text/​Text.d.ts Syncs text declarations.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Pressability/​HoverState.win32.js Updates formatting.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Image/​Image.win32.js Integrates new Image implementation.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​View/​ViewPropTypes.d.ts Syncs view declarations.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​View/​ViewAccessibility.d.ts Adds accessibility type.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​Touchable/​TouchableNativeFeedback.win32.js Syncs Flow formatting.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​Touchable/​TouchableNativeFeedback.d.ts Syncs declarations.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​Touchable/​Touchable.win32.js Updates formatting.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​TextInput/​TextInput.win32.js Updates cleanup ordering.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​TextInput/​TextInput.flow.win32.js Syncs Flow types.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​Pressable/​Pressable.win32.js Syncs Pressable types.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​Button.win32.js Syncs button types.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​AccessibilityInfo/​AccessibilityInfo.win32.js Syncs event types.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Components/​AccessibilityInfo/​AccessibilityInfo.d.ts Syncs event declarations.
packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Alert/​Alert.win32.js Syncs alert types.
packages/​@office-iss/​react-native-win32/​src-win/​index.win32.js.flow Updates public Flow exports.
packages/​@office-iss/​react-native-win32/​src-win/​index.win32.js Updates runtime exports.
packages/​@office-iss/​react-native-win32/​package.json Bumps RN and toolchain dependencies.
packages/​@office-iss/​react-native-win32/​overrides.json Advances Win32 override baselines.
packages/​@office-iss/​react-native-win32/​.flowconfig Updates Win32 Flow configuration.
packages/​@office-iss/​react-native-win32-tester/​src/​js/​utils/​RNTesterList.win32.js Registers ScrollView example.
packages/​@office-iss/​react-native-win32-tester/​package.json Bumps RNTester dependencies.
packages/​@office-iss/​react-native-win32-tester/​overrides.json Updates Win32 tester baseline.
package.json Bumps root RN and TypeScript versions.

💡 Configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread vnext/.flowconfig Resolved
Copilot AI balanced review requested due to automatic review settings October 7, 2026 06:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🔵 Needs a closer look

Missing RNTester modules, duplicate list keys, and disabled Windows Flow coverage leave reproducible failures unresolved.

Review effort: Balanced
Findings: 2 High severity · 2 Medium severity

Open (4)
Previously missed (1)

In code that hasn't changed since last review

Medium severity Flow check incorrectly excludes Windows implementations

vnext/​.flowconfig:81

This rule makes flow-check skip every Windows platform implementation. The config explicitly retains Windows while excluding other platforms at lines 5–8, and the build overlays src-win files into the package root before linting, so this suppresses Windows-only Flow errors. Keep the macOS exclusion but remove the Windows exclusion.

Resolve React Native package exports before RNX redirects imports to the Windows platform package. Add Jest aliases for the new setup-env and react-private-interface entry points, and apply required C++ formatting.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
Copilot AI balanced review requested due to automatic review settings October 7, 2026 15:17

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The Windows Flow configuration skips target-platform overrides, and the new FlatList example can generate duplicate item keys.

4 open findings
Previously missed (1)

In code that hasn't changed since last review

Medium severity Include Windows override files in Flow checking

vnext/​.flowconfig:81

This excludes the Windows override files from Flow. This config explicitly keeps Windows as the target platform (lines 5–8), and copyRNLibraries.js:53-72 overlays src-win files into the package root before flow-check; with this glob, type errors in those generated *.windows.js files are silently skipped. Keep the macOS exclusion, but remove the Windows exclusion (the analogous Win32 config may still exclude *.windows.js).

🧠 Review effort: Balanced

Keep the Windows forks on their supported Flow version, preserve Windows-compatible ignore rules, and map RN 0.88 exports for Flow and Jest. Align Playground conditional export precedence with Metro.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
Copilot AI balanced review requested due to automatic review settings October 7, 2026 15:46

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The iOS tester list references missing modules, and the new FlatList example can generate duplicate item keys.

3 open findings
1 resolved since last review

🧠 Review effort: Balanced

Use React Native's legacy declaration surface for the existing RNW TypeScript configuration and make the Fabric E2E Jest mappings handle RN 0.88 exports and deep imports.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
Copilot AI balanced review requested due to automatic review settings October 7, 2026 17:52

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

Image accessibility references need Windows-specific normalization, and the new FlatList example can generate duplicate keys.

3 open findings
Previously missed (2)

In code that hasn't changed since last review

Medium severity Split aria-labelledby IDs before passing to native

packages/​@office-iss/​react-native-win32/​src-win/​Libraries/​Image/​Image.win32.js:226

aria-labelledby may contain multiple comma-separated native IDs, but this forwards the whole value as one accessibilityLabelledBy entry. View.win32.js splits the alias before passing it to native (Libraries/Components/View/View.win32.js:82-83); without the same conversion, an Image labelled by multiple elements cannot resolve those references.

Medium severity Split aria-labelledby IDs before passing to native

vnext/​src-win/​Libraries/​Image/​Image.windows.js:215

aria-labelledby may contain multiple comma-separated native IDs, but this forwards the whole value as one accessibilityLabelledBy entry. View.windows.js splits the alias before passing it to native (Libraries/Components/View/View.windows.js:106-108); without the same conversion, an Image labelled by multiple elements cannot resolve those references.

🧠 Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 17fa504c-1713-426a-a4fa-45e18fba36d0
@anuagragith
anuagragith requested a review from a team as a code owner October 7, 2026 20:01
Copilot AI balanced review requested due to automatic review settings October 7, 2026 20:01

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The integration leaves nightly scaffolding inconsistent, accepts a Switch accessibility regression, and forwards unsupported Windows TextInput behavior.

6 open findings

🧠 Review effort: Balanced

Comment on lines +124 to +126
REM cRNL cannot scaffold a nightly before its matching stable RN release exists.
REM Use the latest published stable template, then rewrite dependencies below.
for /f "delims=" %%a in ('npm show react-native@latest version') do set RN_SCAFFOLD_VERSION=%%a
accessibilityLevel={_accessibilityLevel}
accessibilityPosInSet={_accessibilityPosInSet}
accessibilitySetSize={_accessibilitySetSize}
submitBehavior={submitBehavior}
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 17fa504c-1713-426a-a4fa-45e18fba36d0
Copilot AI balanced review requested due to automatic review settings October 9, 2026 22:21

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

Asset registry duplication, incomplete host key-prop parsing, and incorrect E2E Enter input handling remain unresolved.

6 open findings
Previously missed (4)

In code that hasn't changed since last review

Medium severity Use addValue to preserve text before sending Enter

packages/​e2e-test-app-fabric/​test/​TextInputComponentTest.test.ts:970

setValue replaces the field contents before sending the Enter key, so this removes abc and invalidates the preservation assertion. Use addValue for the keystroke, matching the existing TextInput Enter tests.

This issue also appears in the following locations of the same file:

  • line 992
  • line 1013
Medium severity Resolve assets against the react-native-windows registry

vnext/​template/​metro.config.js:69

This resolves generated assets against the react-native package, but Windows Image.resolveAssetSource reads ../../src/private/assets/AssetRegistry from the separately built react-native-windows package. Those are different module instances, so numeric assets can be registered in one registry and looked up in the other. Point Metro at the RNW package copy instead.

Medium severity Resolve assets against the react-native-windows registry

vnext/​templates/​cpp-app/​metro.config.js:69

This resolves generated assets against the react-native package, but Windows Image.resolveAssetSource reads ../../src/private/assets/AssetRegistry from the separately built react-native-windows package. Those are different module instances, so numeric assets can be registered in one registry and looked up in the other. Point Metro at the RNW package copy instead.

Medium severity Resolve assets against the react-native-windows registry

vnext/​templates/​cpp-lib/​example/​metro.config.js:101

This resolves generated assets against the react-native package, but Windows Image.resolveAssetSource reads ../../src/private/assets/AssetRegistry from the separately built react-native-windows package. Those are different module instances, so numeric assets can be registered in one registry and looked up in the other. Point Metro at the RNW package copy instead.

🧠 Review effort: Balanced

Comment on lines +63 to +67
!shouldSetRawProps ? sourceProps.accessibilityLiveRegion
: convertRawProp(
context,
rawProps,
"accessibilityLiveRegion",
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 17fa504c-1713-426a-a4fa-45e18fba36d0
Copilot AI balanced review requested due to automatic review settings October 9, 2026 23:45

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Comment thread package.json
Comment on lines +57 to +59
"react-native": "0.88.0-nightly-20260805-f2188610c",
"react-native-platform-override": "workspace:*",
"typescript": "5.0.4"
"typescript": "5.1.6"
// devMode]{{/devMode}}
},
transformer: {
assetRegistryPath: require.resolve('react-native/asset-registry'),
// devMode]{{/devMode}}
},
transformer: {
assetRegistryPath: require.resolve('react-native/asset-registry'),
},

transformer: {
assetRegistryPath: require.resolve('react-native/asset-registry'),
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 17fa504c-1713-426a-a4fa-45e18fba36d0
Copilot AI balanced review requested due to automatic review settings October 10, 2026 01:08

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The generated Metro templates register assets in React Native’s registry while Windows Image reads a separate RNW registry, breaking bundled static-image resolution.

10 open findings
Previously missed (3)

In code that hasn't changed since last review

Medium severity Use RNW asset registry for Metro asset registration

vnext/​template/​metro.config.js:69

This resolves Metro-generated asset modules against React Native's registry, while the Windows Image implementation now reads react-native-windows/src/private/assets/AssetRegistry (resolveAssetSource.windows.js:20). Those are separate module instances, so numeric require('./image.png') sources registered by Metro are absent from the registry used by <Image>. Point the transformer at RNW's copied src/asset-registry.js entry point so registration and lookup share one registry.

Medium severity Use RNW asset registry for Metro asset registration

vnext/​templates/​cpp-app/​metro.config.js:69

This resolves Metro-generated asset modules against React Native's registry, while the Windows Image implementation now reads react-native-windows/src/private/assets/AssetRegistry (resolveAssetSource.windows.js:20). Those are separate module instances, so numeric require('./image.png') sources registered by Metro are absent from the registry used by <Image>. Point the transformer at RNW's copied src/asset-registry.js entry point so registration and lookup share one registry.

Medium severity Use RNW asset registry for Metro asset registration

vnext/​templates/​cpp-lib/​example/​metro.config.js:101

This resolves Metro-generated asset modules against React Native's registry, while the Windows Image implementation now reads react-native-windows/src/private/assets/AssetRegistry (resolveAssetSource.windows.js:20). Those are separate module instances, so numeric require('./image.png') sources registered by Metro are absent from the registry used by <Image>. Point the transformer at RNW's copied src/asset-registry.js entry point so registration and lookup share one registry.

🧠 Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 17fa504c-1713-426a-a4fa-45e18fba36d0
Copilot AI balanced review requested due to automatic review settings October 10, 2026 02:31

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🔵 Needs a closer look

The generated Metro configurations register assets in React Native’s registry while Windows Image queries a separate RNW registry instance.

10 open findings
Previously missed (3)

In code that hasn't changed since last review

Medium severity Use RNW's AssetRegistry to resolve Windows image assets

vnext/​template/​metro.config.js:69

This resolves the registry from the separate react-native package, while Windows Image reads RNW's copied src/private/assets/AssetRegistry (vnext/src-win/Libraries/Image/resolveAssetSource.windows.js:20; copied by packages/@rnw-scripts/just-task/copyRNLibraries.js:53-72). Metro will register asset IDs in one module instance and Image will query another, so bundled/static images can resolve to null. Point this at the RNW registry instead.

Medium severity Use RNW's AssetRegistry to resolve Windows image assets

vnext/​templates/​cpp-app/​metro.config.js:69

This resolves the registry from the separate react-native package, while Windows Image reads RNW's copied src/private/assets/AssetRegistry (vnext/src-win/Libraries/Image/resolveAssetSource.windows.js:20; copied by packages/@rnw-scripts/just-task/copyRNLibraries.js:53-72). Metro will register asset IDs in one module instance and Image will query another, so bundled/static images can resolve to null. Point this at the RNW registry instead.

Medium severity Use RNW's AssetRegistry to resolve Windows image assets

vnext/​templates/​cpp-lib/​example/​metro.config.js:101

This resolves the registry from the separate react-native package, while Windows Image reads RNW's copied src/private/assets/AssetRegistry (vnext/src-win/Libraries/Image/resolveAssetSource.windows.js:20; copied by packages/@rnw-scripts/just-task/copyRNLibraries.js:53-72). Metro will register asset IDs in one module instance and Image will query another, so bundled/static images can resolve to null. Point this at the RNW registry instead.

🧠 Review effort: Balanced

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2138f38b-a302-40f2-b477-e3f137a488a9
Copilot AI balanced review requested due to automatic review settings October 12, 2026 19:12

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"prettier": "^3.6.2",
"react": "19.2.3",
"react-native": "0.87.0-nightly-20260704-e04ff69ab",
"react-native": "0.88.0-nightly-20260805-f2188610c",
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2138f38b-a302-40f2-b477-e3f137a488a9
Copilot AI balanced review requested due to automatic review settings October 12, 2026 20:38

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>

Copilot-Session: 2138f38b-a302-40f2-b477-e3f137a488a9
Copilot AI balanced review requested due to automatic review settings October 12, 2026 22:05

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@anuagragith
anuagragith merged commit 1f59db1 into microsoft:main Oct 13, 2026
32 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants