You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Integrates React Native Windows to RN nightly 0.88.0-nightly-20260805-f2188610c, bumping from the previous integration at 0.87.0-nightly-20260704-e04ff69ab (July 4th).
Changes
Updated react-native and related dependencies to 0.88.0-nightly-20260805-f2188610c.
Resolved merge conflicts introduced by upstream changes between the two nightly versions.
Fixed packages/playground/metro.config.js: RN 0.88 introduced self-referencing subpath imports (e.g. react-native/react-private-interface) that are only resolvable via the package's package.jsonexports map. The previous dev-package redirect logic used the raw subpath, which created a second, inconsistent module instance of ReactNativeViewConfigRegistry and caused an RCTText "view config not found" invariant violation on RNTester startup. Added resolveExportsSubpath() to resolve the subpath through exports first, falling back to the literal subpath, ensuring a single consistent module instance.
Validation
Playground/RNTester builds and deploys successfully.
Manually validated RNTester: loads cleanly, components list and text render correctly, no redbox/invariant errors (previously reproduced the RCTText crash before the metro.config.js fix; confirmed fixed after).
Investigated a separate RNCPicker "view config not found" error: confirmed via an A/B test (same binary, Metro serving baseline RN 0.87 vs. this integration's RN 0.88 JS) that it reproduces identically on both versions. This is a pre-existing limitation (Picker's legacy native Windows ViewManager has never been implemented for composition, and the package is explicitly excluded from Windows autolinking since Fix/playground composition build #16199) — not a regression introduced by this integration, and is out of scope for this change.
- NetworkIOAgent.cpp: remove stale InspectorFlags::getNetworkInspectionEnabled()
gate around Network.enable (upstream fully removed this flag; matches
f2188610c), and fix networkHandler scoping bug this exposed.
- ImageComponentView.cpp: adapt to upstream ImageProps::tintColor becoming
std::optional<SharedColor> (was SharedColor); unwrap via value_or(SharedColor{})
before use, matching the android platform's pre-optional fallback pattern.
- Shared.vcxitems: add missing ClCompile entries for ErrorUtils.cpp and
LayoutEventEmitter.cpp, two new upstream source files not yet wired into
the Windows build, causing LNK2019/LNK2001 unresolved externals for
handleJSError and LayoutEventEmitter::shadowTreeDidCommit.
Verified via full MSBuild of playground-composition.sln
(playground-composition_Package, Debug/x64) - 0 errors.
RN 0.88 introduced 'self-referencing' subpath imports (e.g. react-native/react-private-interface) that are only valid via the package's package.json exports map, and don't correspond to a literal file at that subpath. tryResolveDevAbsoluteImport() previously redirected such imports into the dev package (src-win) using the raw subpath, creating a second, inconsistent module instance for files like ReactNativeViewConfigRegistry. This caused an RCTText view-config invariant violation on RNTester startup, since the core RN code and the dev-package-redirected code resolved to different module instances with separate registries.
Fix: resolve the subpath through the package's 'exports' map first (resolveExportsSubpath), falling back to the literal subpath if no export entry matches, so the dev-package redirect targets the real file and a single consistent module instance is used throughout.
Verified: RNTester now loads without the RCTText invariant violation on the RN 0.88 nightly integration.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
Integrates React Native nightly 0.88.0-nightly-20260805-f2188610c into Windows and Win32, updating platform overrides, native sources, tooling, and RNTester content.
Changes:
Bumps React Native, Metro, Flow, TypeScript, and related dependencies.
Reconciles Windows/Win32 JavaScript, type, and ReactCommon overrides.
Adds Metro export-map resolution and new RNTester scenarios.
Flow check incorrectly excludes Windows implementations
vnext/.flowconfig:81
This rule makes flow-check skip every Windows platform implementation. The config explicitly retains Windows while excluding other platforms at lines 5–8, and the build overlays src-win files into the package root before linting, so this suppresses Windows-only Flow errors. Keep the macOS exclusion but remove the Windows exclusion.
Resolve React Native package exports before RNX redirects imports to the Windows platform package. Add Jest aliases for the new setup-env and react-private-interface entry points, and apply required C++ formatting.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
This excludes the Windows override files from Flow. This config explicitly keeps Windows as the target platform (lines 5–8), and copyRNLibraries.js:53-72 overlays src-win files into the package root before flow-check; with this glob, type errors in those generated *.windows.js files are silently skipped. Keep the macOS exclusion, but remove the Windows exclusion (the analogous Win32 config may still exclude *.windows.js).
Keep the Windows forks on their supported Flow version, preserve Windows-compatible ignore rules, and map RN 0.88 exports for Flow and Jest. Align Playground conditional export precedence with Metro.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
Use React Native's legacy declaration surface for the existing RNW TypeScript configuration and make the Fabric E2E Jest mappings handle RN 0.88 exports and deep imports.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: f23e5537-da3c-4cc2-859b-0ff6f110152e
aria-labelledby may contain multiple comma-separated native IDs, but this forwards the whole value as one accessibilityLabelledBy entry. View.win32.js splits the alias before passing it to native (Libraries/Components/View/View.win32.js:82-83); without the same conversion, an Image labelled by multiple elements cannot resolve those references.
Split aria-labelledby IDs before passing to native
aria-labelledby may contain multiple comma-separated native IDs, but this forwards the whole value as one accessibilityLabelledBy entry. View.windows.js splits the alias before passing it to native (Libraries/Components/View/View.windows.js:106-108); without the same conversion, an Image labelled by multiple elements cannot resolve those references.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
The integration leaves nightly scaffolding inconsistent, accepts a Switch accessibility regression, and forwards unsupported Windows TextInput behavior.
setValue replaces the field contents before sending the Enter key, so this removes abc and invalidates the preservation assertion. Use addValue for the keystroke, matching the existing TextInput Enter tests.
This issue also appears in the following locations of the same file:
line 992
line 1013
Resolve assets against the react-native-windows registry
vnext/template/metro.config.js:69
This resolves generated assets against the react-native package, but Windows Image.resolveAssetSource reads ../../src/private/assets/AssetRegistry from the separately built react-native-windows package. Those are different module instances, so numeric assets can be registered in one registry and looked up in the other. Point Metro at the RNW package copy instead.
Resolve assets against the react-native-windows registry
vnext/templates/cpp-app/metro.config.js:69
This resolves generated assets against the react-native package, but Windows Image.resolveAssetSource reads ../../src/private/assets/AssetRegistry from the separately built react-native-windows package. Those are different module instances, so numeric assets can be registered in one registry and looked up in the other. Point Metro at the RNW package copy instead.
Resolve assets against the react-native-windows registry
This resolves generated assets against the react-native package, but Windows Image.resolveAssetSource reads ../../src/private/assets/AssetRegistry from the separately built react-native-windows package. Those are different module instances, so numeric assets can be registered in one registry and looked up in the other. Point Metro at the RNW package copy instead.
The reason will be displayed to describe this comment to others. Learn more.
🔵 Needs a closer look
The generated Metro templates register assets in React Native’s registry while Windows Image reads a separate RNW registry, breaking bundled static-image resolution.
Use RNW asset registry for Metro asset registration
vnext/template/metro.config.js:69
This resolves Metro-generated asset modules against React Native's registry, while the Windows Image implementation now reads react-native-windows/src/private/assets/AssetRegistry (resolveAssetSource.windows.js:20). Those are separate module instances, so numeric require('./image.png') sources registered by Metro are absent from the registry used by <Image>. Point the transformer at RNW's copied src/asset-registry.js entry point so registration and lookup share one registry.
Use RNW asset registry for Metro asset registration
vnext/templates/cpp-app/metro.config.js:69
This resolves Metro-generated asset modules against React Native's registry, while the Windows Image implementation now reads react-native-windows/src/private/assets/AssetRegistry (resolveAssetSource.windows.js:20). Those are separate module instances, so numeric require('./image.png') sources registered by Metro are absent from the registry used by <Image>. Point the transformer at RNW's copied src/asset-registry.js entry point so registration and lookup share one registry.
Use RNW asset registry for Metro asset registration
This resolves Metro-generated asset modules against React Native's registry, while the Windows Image implementation now reads react-native-windows/src/private/assets/AssetRegistry (resolveAssetSource.windows.js:20). Those are separate module instances, so numeric require('./image.png') sources registered by Metro are absent from the registry used by <Image>. Point the transformer at RNW's copied src/asset-registry.js entry point so registration and lookup share one registry.
Use RNW's AssetRegistry to resolve Windows image assets
vnext/template/metro.config.js:69
This resolves the registry from the separate react-native package, while Windows Image reads RNW's copied src/private/assets/AssetRegistry (vnext/src-win/Libraries/Image/resolveAssetSource.windows.js:20; copied by packages/@rnw-scripts/just-task/copyRNLibraries.js:53-72). Metro will register asset IDs in one module instance and Image will query another, so bundled/static images can resolve to null. Point this at the RNW registry instead.
Use RNW's AssetRegistry to resolve Windows image assets
vnext/templates/cpp-app/metro.config.js:69
This resolves the registry from the separate react-native package, while Windows Image reads RNW's copied src/private/assets/AssetRegistry (vnext/src-win/Libraries/Image/resolveAssetSource.windows.js:20; copied by packages/@rnw-scripts/just-task/copyRNLibraries.js:53-72). Metro will register asset IDs in one module instance and Image will query another, so bundled/static images can resolve to null. Point this at the RNW registry instead.
Use RNW's AssetRegistry to resolve Windows image assets
This resolves the registry from the separate react-native package, while Windows Image reads RNW's copied src/private/assets/AssetRegistry (vnext/src-win/Libraries/Image/resolveAssetSource.windows.js:20; copied by packages/@rnw-scripts/just-task/copyRNLibraries.js:53-72). Metro will register asset IDs in one module instance and Image will query another, so bundled/static images can resolve to null. Point this at the RNW registry instead.
The reason will be displayed to describe this comment to others. Learn more.
🟡 Changes recommended
Template asset registration uses a different registry instance, and Win32 is missing forwarding entry points required by the RN 0.88 self-referencing imports.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Integrates React Native Windows to RN nightly
0.88.0-nightly-20260805-f2188610c, bumping from the previous integration at0.87.0-nightly-20260704-e04ff69ab(July 4th).Changes
react-nativeand related dependencies to0.88.0-nightly-20260805-f2188610c.packages/playground/metro.config.js: RN 0.88 introduced self-referencing subpath imports (e.g.react-native/react-private-interface) that are only resolvable via the package'spackage.jsonexportsmap. The previous dev-package redirect logic used the raw subpath, which created a second, inconsistent module instance ofReactNativeViewConfigRegistryand caused anRCTText"view config not found" invariant violation on RNTester startup. AddedresolveExportsSubpath()to resolve the subpath throughexportsfirst, falling back to the literal subpath, ensuring a single consistent module instance.Validation
RNCPicker"view config not found" error: confirmed via an A/B test (same binary, Metro serving baseline RN 0.87 vs. this integration's RN 0.88 JS) that it reproduces identically on both versions. This is a pre-existing limitation (Picker's legacy native Windows ViewManager has never been implemented for composition, and the package is explicitly excluded from Windows autolinking since Fix/playground composition build #16199) — not a regression introduced by this integration, and is out of scope for this change.Microsoft Reviewers: Open in CodeFlow