Repository navigation
Fix inline targets in add-decorator codefixes - #12525
Draft
catalinaperalta wants to merge 1 commit into
Draft
catalinaperalta wants to merge 1 commit into
catalinaperalta wants to merge 1 commit into
Conversation
Insert decorators at inline declarations rather than at the start of their containing line. Preserve existing multiline indentation and decorator attachment. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: eddbfa67-cd77-4acf-99f6-8fd275d6c7d6
microsoft-github-policy-service
Bot
added
the
compiler:core
commit: |
Contributor
|
All changed packages have been documented.
Show changes
|
|
You can try these changes here
|
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix
createAddDecoratorCodeFixso declarations sharing a line receive the decorator themselves, rather than decorating the declaration at the start of the line.This enables Azure/typespec-azure#5946 to reuse the compiler helper instead of duplicating insertion logic, following Azure/typespec-azure#5946 (comment).
Validation
@typespec/ts-http-runtimeCommonJS logger module.tmlanguage.d.tsinput/output collision in the compiler tsconfig.Validation was performed on the compiler revision pinned by the Azure prototype, with this fix applied.