Repository navigation
[http-client-csharp] Preserve code-span wildcards in XML documentation - #12557
Draft
Robert Markovski (Roshan931) wants to merge 1 commit into
Draft
Robert Markovski (Roshan931) wants to merge 1 commit into
Robert Markovski (Roshan931) wants to merge 1 commit into
Conversation
Draft generated from the existing Prilog candidate for review. Verification is incomplete or failed; this commit does not claim a passing verification result. Assisted-by: Prilog
|
Azure Pipelines: Successfully started running 1 pipeline(s). 1 pipeline(s) were filtered out due to trigger conditions. There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
|
Robert Markovski (@Roshan931) please read the following Contributor License Agreement(CLA). If you agree with the CLA, please reply with the following information.
Contributor License AgreementContribution License AgreementThis Contribution License Agreement (“Agreement”) is agreed to by the party signing below (“You”),
|
|
@microsoft-github-policy-service agree [company="Prilog"] |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related to #12544. There is already active upstream work in #12547; this draft is an alternative candidate and may be superseded by that PR.
Draft status and known issues
This is an unverified draft, not ready for merge. It preserves wildcard characters inside backtick-delimited code spans and adds unit and generated-documentation regression coverage, but existing emphasis spanning a code span still regresses:
*italic with `code` inside*retains the emphasis markers instead of producing XML italic tags.Validation recorded so far
A targeted .NET 10.0.400 probe against the actual candidate source preserved the reported wildcard examples and literal U+FFFC placeholder characters, while reproducing all three formatting regressions above. This does not establish a passing component or repository test suite. The patch applies cleanly to the current upstream base; no new passing test result is claimed for opening this draft.
Before this is made ready, preserve outer emphasis across protected code spans, rerun the component tests and generated-documentation regression, and coordinate with the existing upstream PR to avoid duplicate work.
AI assistance
The code is the existing Prilog-generated candidate, reviewed with Codex and published as a draft with the known limitations disclosed.
This draft was prepared with Prilog. This is our way of giving back to the open source community.