Repository navigation
[http-client-python] Revert bundled playground dependency wheels - #12577
Open
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Open
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Libba Lawrence (l0lawrence) wants to merge 1 commit into
Conversation
Revert the implementation of microsoft#12484 while preserving Python emitter 0.40.1 and its current dependency upgrades. Record this rollback as an internal change without a version bump. Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Libba Lawrence (l0lawrence)
requested review from
Chenxi Jiang (ChenxiJiang333),
catalinaperalta,
iscai-msft,
Kashif Khan (kashifkhan),
Laurent Mazuel (lmazuel),
Mark Cowlishaw (markcowl),
Yuchao Yan (msyyc),
Chenjie Shi (tadelesh),
Timothee Guerin (timotheeguerin) and
Jeff Fisher (xirzec)
as code owners
November 13, 2026 17:28
microsoft-github-policy-service
Bot
added
the
emitter:client:python
commit: |
Contributor
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Removing the emit tests leaves micropip installation and initialization retry behavior untested, so replacement tests are needed for the generator-wheel URL, installation failure diagnostic, and successful retry.
1 open issue
What changed in this PR
Rolls back the Python emitter’s bundled playground dependency wheels from #12484 ahead of a separate 0.40.1 release retry. Version and dependency upgrades from #12556 remain unchanged.
Changes:
- Restores micropip-based browser installation and the regular generator-wheel build.
- Removes playground-specific build configuration, asset declarations, tests, and documentation.
- Adds an internal, no-version Chronus entry without a new CHANGELOG version.
| File | Description |
|---|---|
packages/http-client-python/tests/unit/test_browser_wheels.py |
Removes bundled browser-wheel build tests. |
packages/http-client-python/package.json |
Removes the playground build command and browser asset declarations. |
packages/http-client-python/eng/scripts/setup/build.ts |
Stops forwarding playground build arguments. |
packages/http-client-python/eng/scripts/setup/build_pygen_wheel.py |
Restores the regular wheel-only build. |
packages/http-client-python/eng/pipeline/publish.yml |
Removes the playground build-script override. |
packages/http-client-python/emitter/test/browser-pyodide.test.ts |
Removes bundled-wheel tests while retaining lazy-bootstrap coverage. |
packages/http-client-python/emitter/src/emitter.ts |
Restores generator-wheel installation through micropip. |
packages/http-client-python/ARCHITECTURE.md |
Removes documentation for bundled browser dependencies. |
.chronus/changes/python-playground-wheel-rollback.md |
Records the rollback as an internal change. |
Review effort: Balanced
| import { expectDiagnostics } from "@typespec/compiler/testing"; | ||
| import { strictEqual } from "assert"; | ||
| import { afterEach, describe, expect, it, vi } from "vitest"; | ||
| import { afterEach, describe, it, vi } from "vitest"; |
Contributor
Python emitter diffBaseline No changes to generated output. Rendered diff: inline on the run summary, or the emitter-diff-html artifact. Informational check (eng/emitter-diff); does not block the PR. |
|
You can try these changes here
|
This was referenced Nov 13, 2026
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Blocking release b/c conflicts with CFS going to revert to get compat with newest typespec versions out and merge back in later