Skip to content

Remove retired Bookings beta routes and complete v3 migration - #3839

Merged
Ramses Sanchez-Hernandez (ramsessanchez) merged 12 commits into
powershell-v3from
ramsessanchez-bookings-v3-migration
Oct 28, 2026
Merged

Remove retired Bookings beta routes and complete v3 migration#3839
Ramses Sanchez-Hernandez (ramsessanchez) merged 12 commits into
powershell-v3from
ramsessanchez-bookings-v3-migration

Conversation

@ramsessanchez

@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) commented Oct 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

N/A

Changes proposed in this pull request

Microsoft retired root-level Bookings beta APIs on April 30, 2024, but the compatible input still included them without usable deprecation annotations. They must not be generated alongside their supported /solutions/... replacements. This implements the requested removal, prevents refresh from restoring them, and completes both-profile generation for the shared-directive migration.

  • Extend the existing byte-preserving pruner with the exact reviewed Bookings beta retirement policy. Remove /bookingBusinesses and /bookingCurrencies plus descendants, case-insensitively at complete root-segment boundaries. Remove 29 paths / 53 operations from compatible beta; preserve every live /solutions operation, lookalike/unrelated paths, schemas, encoding and line endings. Policy removals report their reason, date and official source even when upstream metadata is missing.
  • Enforce pruning in both supported entrypoints: standalone DownloadOpenApiDocKiotaCompat.ps1 immediately after successful download/ID projection, and UpdateOpenApiKiotaCompat.ps1 after profile ID tweaks with one complete aggregate report. Add boundary, quoted-key, missing-metadata, profile-scope, idempotency, exact-byte, actual-spec and end-to-end mocked-refresh regressions. Historical openApiDocs, profile-local readmes and original shared directives remain intact.
  • Reconcile the three shared directive groups with existing curated behavior: exact GET/PATCH /solutions suppression, exact GET/PATCH/DELETE /solutions/virtualEvents suppression, and the existing Solution-prefix strip with the BackupRestore exception. The original root selector is verified against the complete actual historical match set; current compatible PowerShell-formatted IDs now match directly. All three groups have complete reviewed evidence. Withdraw the prepared legacy-default multi-route policy; no retired route is selectable, no global beta naming repair or Support compatible natural-ID operation variants #3849 activation is introduced.

Both required compatible profiles are supported; none are excluded. All directives in src/readme.graph.md and profile-local readmes (including Bookings v1.0/beta) remain explicitly outside the directive migration. Parameter aliases/transforms and schema/response directives remain deferred.

Full generation and compiled evidence

Normal target integration preserves prior commits and includes powershell-v3 at abab9dac88. Both profiles ran sequentially through the coordinator's four-mutex queue, invoking the unchanged full builder with -Module Bookings -ApiVersion <profile> -Configuration Release -SpecRoot .\openApiDocs_KiotaCompat. No SkipKiota, GenerateOnly or NoCollisionData flags were used. Tooling: isolated Kiota 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943, process-local generation parallelism 1, official Authentication 2.38.1.

Profile Full Release result Fresh compiled validation
v1.0 Passed; 217 exported cmdlets Discoverable/importable; zero retired root routes or builder trees; 18 intended live-operation checks and two no-network list/item dispatch probes passed. Generated sources/projects unchanged; only the client lock description hash changes.
beta Passed; 253 exported cmdlets; zero live name collisions Discoverable/importable; zero retired root routes or builder trees; the same 18 live-operation checks and two runtime probes passed. Complete new client, cmdlets, projects and locks included.

Live checks cover Solutions collection/item GET, CRUD, counts, currency routes, publish/unpublish/cancel/getStaffAvailability actions, a webinar function, and unaffected virtual-event neighbors. The withdrawn Route selector and _Route workers are absent. No tenant requests were made.

Compatible spec blobs: v1.0 95f7a092ac4e7b0b37f3579b15370e0b5a8a90ce (unchanged target input); beta 769c9d105fd3ba96a2de8d0169738cf5b907445a (retired paths removed).

Validation commands and results

  • Invoke-Pester -Path .\tools\Tests\BookingsRetirement.Tests.ps1,.\tools\Tests\Remove-ExpiredDeprecatedOpenApiOperations.Tests.ps1,.\tools\Tests\KiotaCompatOperationIds.Tests.ps1 -Output None -PassThru - 44 passed, 0 failed.
  • dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --no-restore --filter 'FullyQualifiedName~BookingsDirectiveMigrationTests|FullyQualifiedName~NamingTests|FullyQualifiedName~DerivedCollisionResolutionsTests|FullyQualifiedName~CmdletConfiguratorTests' --verbosity quiet - 97 passed.
  • .\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module Bookings -FailOnUnresolved - all three directives Mapped, with actual historical selector source checks and no unresolved candidates.
  • pwsh -NoProfile -File .\tools\Test-WrapperDirectiveMigrationInventory.ps1 - passed.
  • Full queued Build-WrapperModule.ps1 runs for v1.0 and beta - passed, followed by fresh-process compiled route/builder/import/runtime checks described above.

Known unrelated parity limitations: Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\Bookings\wrapper\v1.0\Cmdlets still exits 1: 165 matched, four pre-existing function-name mismatches, 19 missing oracle rows, 29 dispatchers. The equivalent beta command exits 1: 165 mismatches (153 solely baseline Mg versus published MgBeta, 12 existing function/action naming differences), 50 missing oracle rows, 38 dispatchers. Historical metadata still points many Bookings commands at retired URLs; it is not evidence that those endpoints remain supported. These baseline parity issues are recorded, not silently fixed or suppressed. The existing YamlReader NU1903 dependency warning is unchanged.

Commit boundaries: original audit/preparation commits are preserved. Normal target merge 1d280c8d00; sourced retirement/input correction d780b427d6; literal-source proof correction 82e4b108d7; full v1.0 client/cmdlet regeneration eedce68ed7; full beta client/cmdlet generation 1630838c1c; focused empty-path report correction cdc08422c4. No prior commits were amended or squashed; generated sources are unmodified generator output, and binaries/logs are excluded.

Other links

@ramsessanchez
Audit Bookings shared directives for v3 migration
eee4c85 
Record exact compatible-profile operation evidence, retain existing curated behavior, and pin shared directive and neighboring naming coverage.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate Bookings v1.0 client and cmdlets
dfb576b 
Run full Kiota 1.36.1 and cmdlet generation with a successful Release build and 217 compiled exports. Generated client/cmdlet sources and projects are unchanged; only the Kiota version lock advances from 1.34.1.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Record reviewed Bookings beta route-selection defaults
5d54af9 
Prepare the separately authorized additive multi-route opt-in: preserve all 53 exact pairs, retain published legacy defaults for 50 pairs and solutions defaults for three actions. Pin compatible-spec identities and published metadata in module-specific tests. Shared runtime implementation remains a separate prerequisite; no route tree is suppressed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Bridge Bookings root operation IDs across source specs
62c8d98 
Resolve the original selector against both legacy sources and explicitly map the exact GET/PATCH solutions roots to compatible operation IDs. Pin both complete source match sets and compatible targets without conflating renamed operation IDs with API absence. Strict inventory revalidation awaits prerequisite #3847.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Merged
@ramsessanchez
Merge remote-tracking branch 'origin/powershell-v3' into ramsessanche…
1d280c8 
…z-bookings-v3-migration
@ramsessanchez
Remove retired Bookings beta root URI families
d780b42 
Enforce Microsoft's 2024-04-30 retirement at both compatible refresh entrypoints even without upstream deprecation metadata. Byte-preserve unrelated paths and schemas while removing 29 retired paths and 53 operations; keep all solutions successors and historical sources. Withdraw the prepared legacy-default policy and update exact shared-directive evidence for current operation IDs.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Keep literal Bookings source proof in audit notes and tests
82e4b10 
Remove reserved legacy-translation fields from literal profiles now that compatible IDs equal the original IDs. Preserve the complete actual historical GET/PATCH root match set in notes and source-reading regression assertions.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate Bookings v1.0 against current compatible inputs
eedce68 
Full queued Kiota 1.36.1 and cmdlet generation with a real Release build: 217 compiled exports, zero retired roots/builders, 18 live-operation checks and two runtime list/item probes. Generated sources and projects are byte-identical; only the compatible description hash in the client lock changes.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Generate Bookings beta client and cmdlets without retired roots
1630838 
Run full queued Kiota 1.36.1 and cmdlet generation with a real Release build and official Authentication 2.38.1: 253 compiled exports and no collisions. Verify zero retired root routes or request builders, 18 live-operation checks and two runtime list/item probes. Include complete beta client, cmdlets, generated projects and locks; no skipped generators or collision bypass.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Report empty retired Bookings paths without phantom operations
cdc0842 
Keep removed-operation arrays empty when a retired path contains only path-level metadata; pin exact report counts and clarify the documented retirement exception.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) changed the title Audit Bookings shared directives for v3 migration Remove retired Bookings beta routes and complete v3 migration Oct 27, 2026
@ramsessanchez
Ramses Sanchez-Hernandez (ramsessanchez) marked this pull request as ready for review October 27, 2026 21:39
Copilot AI reviewed Oct 28, 2026
View reviewed changes

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟡 Changes recommended

The standalone downloader overwrites the profile-wide removal report, losing other modules’ records, while profile-unaware adapter caching can route beta and v1.0 commands to the wrong endpoints.

2 open issues
What changed in this PR

Updates the Bookings Kiota-wrapper migration to exclude retired beta roots during refresh while retaining supported /solutions/... routes.

Changes:

  • Adds standalone pruning and defers bulk pruning until operation-ID tweaks finish.
  • Documents audited shared directives and migration exclusions.
  • Adds generated beta client/cmdlet artifacts and updates the v1.0 generation lock.
File Description
tools/​UpdateOpenApiKiotaCompat.ps1 Updated as part of this pull request.
tools/​README.md Updated as part of this pull request.
tools/​DownloadOpenApiDocKiotaCompat.ps1 Updated as part of this pull request.
src/​Bookings/​wrapper/​v1.0/​Client/​kiota-lock.json Updated as part of this pull request.
src/​Bookings/​wrapper/​Bookings_cmdletConfigurations.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventWebinarSession.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventWebinarRegistrationConfiguration.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventWebinarRegistration.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventWebinarPresenter.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventWebinar.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventTownhallSession.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventTownhallRegistrationConfiguration.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventTownhallRegistration.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventTownhallPresenter.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventTownhall.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventSession.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEventPresenter.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgVirtualEvent.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingCurrency.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingBusinessStaffMember.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingBusinessService.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingBusinessCustomQuestion.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingBusinessCustomer.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingBusinessCalendarView.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingBusinessAppointment.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​RemoveMgBookingBusiness.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​NewMgBookingCurrency.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​kiota-lock.json Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​InvokeMgVirtualEventWebinarRegistrationCancel.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​InvokeMgVirtualEventTownhallRegistrationCancel.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​InvokeMgVirtualEventSetExternalEventInformation.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​InvokeMgVirtualEventPublish.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​InvokeMgVirtualEventCancel.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​InvokeMgBookingBusinessUnpublish.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​InvokeMgBookingBusinessPublish.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventWebinarSessionCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventWebinarRegistrationCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventWebinarRegistrationConfigurationQuestionCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventWebinarPresenterCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventWebinarCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventWebinar_Get.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventTownhallSessionCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventTownhallRegistrationCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventTownhallRegistrationConfigurationQuestionCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventTownhallPresenterCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventTownhallCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventSessionRegistrationCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventSessionPresenterCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventSessionCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventSessionAttendanceReportCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventPresenterSessionCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventPresenterCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEventCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgVirtualEvent_Get.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingCurrencyCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingCurrency_Get.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusinessStaffMemberCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusinessServiceCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusinessCustomQuestionCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusinessCustomerCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusinessCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusinessCalendarViewCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusinessAppointmentCount.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Cmdlets/​GetMgBookingBusiness_Get.g.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Solutions/​VirtualEvents/​Webinars/​GetByUserRoleWithRole/​GetByUserRoleWithRoleResponse.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Solutions/​VirtualEvents/​Webinars/​GetByUserIdAndRoleWithUserIdWithRole/​GetByUserIdAndRoleWithUserIdWithRoleResponse.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Solutions/​VirtualEvents/​Townhalls/​GetByUserRoleWithRole/​GetByUserRoleWithRoleResponse.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Solutions/​VirtualEvents/​Townhalls/​GetByUserIdAndRoleWithUserIdWithRole/​GetByUserIdAndRoleWithUserIdWithRoleResponse.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Solutions/​BookingBusinesses/​Item/​GetStaffAvailability/​GetStaffAvailabilityResponse.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​WeekIndex.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​VirtualEventWebinarRegistrationConfiguration.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​VirtualEventTownhallRegistrationConfiguration.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​VirtualEventStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​VirtualEventAttendeeRegistrationStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​SharePointMigrationTaskStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​SharePointIdentityMappingUserType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​SharePointIdentityMappingGroupType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ServiceType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ServiceAppStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​RetentionPeriodChangeStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​RestoreSessionStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​RestorePointTags.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​RestorePointPreference.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​RestoreJobType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​RestoreArtifactsBulkRequestStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​RecurrencePatternType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ProvisionState.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ProtectionUnitStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ProtectionUnitsBulkJobStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ProtectionSource.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ProtectionRuleStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ProtectionPolicyStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerUserRoleKind.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerTaskTargetKind.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerTaskCompletionRequirements.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerTaskChatMessageType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerTaskChatMentionType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerRuleKind.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerPreviewType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerCreationSourceKind.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PlannerApprovalStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PhysicalAddressType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​PhoneType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​OnlineMeetingType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​OnlineMeetingRole.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​OnlineMeetingPresenters.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​NotificationRecipientsType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​NotificationEventsType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​MeetingLiveShareOptions.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​MeetingEngagementType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​MeetingChatMode.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​MeetingChatHistoryDefaultMode.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​MeetingAudience.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​MailboxType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​LocationUniqueIdType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​LocationType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​LobbyBypassScope.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ExclusionUnitBulkJobStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​EndpointType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​DisableReason.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​DestinationType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​DayOfWeekObject.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​CrossTenantMigrationJobType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BrowseSessionStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingStaffRole.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingStaffMembershipStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingsServiceAvailabilityType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingsAvailabilityStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingReminderRecipients.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingPriceType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingPageAccessControl.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BookingInvoiceStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BodyType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BackupServiceStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BackupServiceConsumer.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BackupReport.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​BackupPolicyProtectionMode.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ArtifactRestoreStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ApproverRole.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ApprovalOperationStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ApprovalItemType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ApprovalItemState.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​AnswerInputType.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​AllowedLobbyAdmitterRoles.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ActivityLogSeverity.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Models/​ActivityLogResultStatus.cs Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​kiota-lock.json Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​Client.csproj Updated as part of this pull request.
src/​Bookings/​wrapper/​beta/​Client/​ApiClient.cs Updated as part of this pull request.
src/​Bookings/​Bookings.md Updated as part of this pull request.

Review effort: Max

Comment thread tools/DownloadOpenApiDocKiotaCompat.ps1 Resolved
Comment thread src/Bookings/wrapper/beta/Client/ApiClient.cs
Comment on lines +40 to +44
if (string.IsNullOrEmpty(RequestAdapter.BaseUrl))
{
RequestAdapter.BaseUrl = "https://graph.microsoft.com/beta";
}
PathParameters.TryAdd("baseurl", RequestAdapter.BaseUrl);

@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) Oct 28, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot can we have the requestAdapter base url here replace the sessionAdapterCache?

Copilot AI Oct 28, 2026

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not safely. BaseUrl belongs to the adapter, and SessionAdapterCache shares that adapter across wrapper profiles. Setting it only when empty makes the first profile win; forcing it on every client construction mutates a shared adapter and can misroute concurrent or subsequent requests. The cache is also needed to follow the session HttpClient lifecycle. The safer fix is a profile-aware cache key, such as (session HttpClient, Graph profile), so each profile gets an adapter with its own base URL while retaining the session transport.

@ramsessanchez
Move Bookings beta retirement into cmdlet configuration
037ab5d 
Keep generic OpenAPI pruning metadata-driven and suppress retired beta root cmdlets through profile-scoped Bookings configuration. Restore legacy input/client routes while preserving supported solutions cmdlets and v1.0 behavior.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Open
@ramsessanchez
Ramses Sanchez-Hernandez (ramsessanchez) merged commit 539f5d0 into powershell-v3 Oct 28, 2026
3 checks passed
@ramsessanchez
Ramses Sanchez-Hernandez (ramsessanchez) deleted the ramsessanchez-bookings-v3-migration branch October 28, 2026 22:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot
Copilot review effort
Applies to this pull request for everyone.Learn more about Copilot code review.
Copilot left review comments
+1 more reviewer
Copilot code review Copilot Copilot left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@ramsessanchez