Skip to content

Migrate DeviceManagement shared directives to v3 wrappers - #3900

Open
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
powershell-v3from
ramsessanchez-devicemanagement-v3-migration
Open

Migrate DeviceManagement shared directives to v3 wrappers#3900
Ramses Sanchez-Hernandez (ramsessanchez) wants to merge 15 commits into
powershell-v3from
ramsessanchez-devicemanagement-v3-migration

Conversation

@ramsessanchez

@ramsessanchez Ramses Sanchez-Hernandez (ramsessanchez) commented Nov 6, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

N/A (module migration; no standalone issue is closed).

Changes proposed in this pull request

  • Migrate only src\DeviceManagement\DeviceManagement.md shared cmdlet directives. Keep every original AutoRest directive active and annotated. Ignore src\readme.graph.md and all profile-local readmes. Parameter aliases/transforms and schema/response directives remain deferred (none occur in this shared file). Both compatible profiles are supported; no profile is excluded.

    Shared directive Reviewed disposition v1.0 operations beta operations
    Original invalid-operation regex Exact method/path suppressions; complete original source selection equals current literal survivors after normal ID alignment 0 12
    New managed/comanaged log collection request Suppress only collection POST; preserve GET/item PATCH/DELETE/download URL neighbors 1 2
    Update comanaged device Suppress only exact item PATCH 0 1
    Start user-experience device-scope action Audited absence in both actual legacy/current specs; no invented route or blanket suppression 0 0

    All 15 shared exact suppressions are retained with derived data on/off and explicit separate generation-profile context. No Legacy bridge fields, profile filters, resurrected DeviceManagement.Actions, global generator changes, or new authored route selectors/groups.

  • Integrate actual normal target 6475f3f5beb4908d39ea356db32bf1e0fd3273cb, then regenerate complete Kiota clients, cmdlets, projects and locks separately for v1.0 (6292b85f1a50ccfd260729a44355d0b4248d5754) and beta (df343d7f469f89a7881a52a0218e16b4bfadf35a). Source/test correction: 69aac73fd2d98e4a919be07f19e641239a3f0f52; normal merge: 2940296e6644020f842bb5761d7dd8a4c10284be. Earlier migration/profile commit boundaries are preserved.

    Both full Release runs use isolated Kiota 1.36.1+fd3bf87790149b87f40f7eae1a5feb9016625943 with process-local model-generation parallelism 1, PowerShell 7, and the complete normally built Authentication 2.41.2 package (all 64 file hashes and physical nupkg SHA256 verified). Wrapper bins contain only the three owned DLLs; there are no dependency copies or preloads. Existing Beta directory casing is preserved.

  • Validate the actual generated modules, not candidate snapshots. PATCH 204 returns no object and sends exactly one PATCH even while GET would return 403; PATCH 200 returns its own typed response with no readback. Caller-explicit GET is independently exercised. Retain all six beta composite workers, mandatory route keys and distinct PolicyId1/DeviceId1 body values. Global/USGov checks assert correct selected profile/cloud URLs, escaped IDs, JSON bodies, headers/If-Match, bodyless DELETE, typed POST/action/GET, default List, WhatIf, genuine declined confirmation, binder rejection, normal assembly ownership, cache reuse, request-context/reconnect invalidation and disconnected no-send.

    Offline runtime isolation correction (probe-only, same head and compiled modules): after the final additional-runspace module import, reapply the existing normal Set-MgTestDataStore helper and reflect the real shared GraphSession.DataStore before Connect, HTTP, request-context changes, reconnect/disconnect and logout. All four profile/cloud runtime gates were rerun with these guards: 276 actual reflected checks and 64 terminal HTTP checks observed Microsoft.Graph.Authentication.Test.Mocks.MockDataStore, with zero mismatches. Authentication64/nupkg and compiled-bin hashes remain unchanged. No source, full build, TRX or generation reruns were performed; those valid prior artifacts are referenced by absolute path/hash in the new handoff. The original 65 evidence files, including the old runtime proof and original handoff, are preserved unchanged rather than relabeled as newly guarded runs. Datastore-type observation alone does not establish actual credential I/O.

    Validation commands and results

    Process-local prerequisites: the exact normally built Authentication 2.41.2 root is first on PSModulePath, the isolated Kiota directory is first on PATH, and KIOTA_Generation__MaxDegreeOfParallelism=1. No global installation, live Graph/OAuth, skipped Kiota, fallback spec, or manual generated-source edits.

    Exact command Result
    dotnet test .\tools\WrapperGenerator.Tests\WrapperGenerator.Tests.csproj --no-restore --filter 'FullyQualifiedName~DeviceManagementDirectiveMigrationTests|FullyQualifiedName~CmdletConfiguratorTests|FullyQualifiedName~DerivedCollisionResolutionsTests|FullyQualifiedName~NamingTests|FullyQualifiedName~CompositeKeyTests|FullyQualifiedName~RequiredQueryTests|FullyQualifiedName~PatchOperationTests' --logger 'trx;LogFileName=targeted.trx' --results-directory 'C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-final' --verbosity quiet Passed 238, executed 238, failed 0, skipped 0; actual targeted.trx
    pwsh -NoProfile -NonInteractive -File .\tools\Get-WrapperDirectiveMigrationInventory.ps1 -Module DeviceManagement -FailOnUnresolved -AsJson Passed, all four shared directives Mapped, zero Unresolved
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1' -RepoRoot 'C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-cautious-parakeet' -Module DeviceManagement -ApiVersion v1.0 -Configuration Release Passed, exit 0 / OK, 297 exports, 521.2s
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\871a5292-dc5b-423e-8083-5165b0006603\files\Invoke-QueuedModuleBuild.ps1' -RepoRoot 'C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-cautious-parakeet' -Module DeviceManagement -ApiVersion beta -Configuration Release Passed, exit 0 / OK, 1187 exports, 748.9s
    dotnet build 'C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-cautious-parakeet\src\DeviceManagement\wrapper\v1.0\Microsoft.Graph.Wrapper.DeviceManagement.csproj' -c Release --no-incremental --nologo -v quiet Passed, exit 0
    dotnet build 'C:\Users\ramsess\Repos\copilot-worktrees\msgraph-sdk-powershell\ramsessanchez-cautious-parakeet\src\DeviceManagement\wrapper\beta\Microsoft.Graph.Wrapper.DeviceManagement.csproj' -c Release --no-incremental --nologo -v quiet Passed, exit 0
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-memory-final\Test-FinalRuntime.ps1' -RepoRoot $PWD.Path -Profile v1.0 -Cloud Global Passed, full compiled module, actual post-import MockDataStore guards
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-memory-final\Test-FinalRuntime.ps1' -RepoRoot $PWD.Path -Profile v1.0 -Cloud USGov Passed, full compiled module, actual post-import MockDataStore guards
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-memory-final\Test-FinalRuntime.ps1' -RepoRoot $PWD.Path -Profile beta -Cloud Global Passed, ordinary plus both composite routes, actual datastore guards
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-memory-final\Test-FinalRuntime.ps1' -RepoRoot $PWD.Path -Profile beta -Cloud USGov Passed, ordinary plus both composite routes, actual datastore guards
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-final\Test-DeviceManagementCompiledRoutes.ps1' -RepoRoot $PWD.Path -Profile v1.0 Passed, one reviewed route absent, seven actual neighbors present
    pwsh -NoProfile -NonInteractive -File 'C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-final\Test-DeviceManagementCompiledRoutes.ps1' -RepoRoot $PWD.Path -Profile beta Passed, 15 reviewed routes absent, 24 actual neighbors present
    pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\DeviceManagement\wrapper\v1.0\Cmdlets Raw baseline failed, 296/297; existing OmaSetting function-name mismatch
    pwsh -NoProfile -NonInteractive -File .\tools\Compare-WrapperCmdletNames.ps1 -GeneratedPath .\src\DeviceManagement\wrapper\Beta\Cmdlets Raw baseline failed, 0/1,187; unchanged published MgBeta prefix/noun differences, not normalized into a false pass

    Required native query inputs: none in either actual module spec, independently checked in source tests; no sibling-GET inputs are added to PATCH. Offline transport evidence is not service/tenant certification. Optional-query issue [v3 wrappers] Support arbitrary optional query parameters #3897 and unrelated naming/PostPath work are outside scope. Historical failed and candidate evidence is preserved separately; current proof and complete Git/file/hash provenance are in C:\Users\ramsess\.copilot\session-state\4f3b52ec-085d-494c-b9e1-b5a5bc09b5f7\files\post3886-6475-memory-final\handoff.json.

Other links

@ramsessanchez
Migrate DeviceManagement shared cmdlet directives
d2bdbc1 
Review complete legacy operation-ID selector sets and preserve exact compatible successors, including final action namespace conversions. Add scoped suppressions, audited absence, shared annotations and affected/neighbor regressions without profile generation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate DeviceManagement v1.0 client and cmdlets
97a3a70 
Run the complete queued compatible-spec Release pipeline with Kiota 1.36.1 and Authentication 2.38.1: 297 compiled cmdlets. Client and cmdlet source/project output is byte-equivalent after Git line-ending normalization; the Kiota lock records the tool upgrade. Preserve the combined v1.0 generation boundary.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Merge powershell-v3 for DeviceManagement migration revalidation
e0af424 
Integrate normally merged compatible natural-ID variants, aligned operation IDs and composite-key routing fixes without rewriting earlier migration/profile boundaries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Revalidate DeviceManagement migration against merged variant APIs
bcc0022 
Pass the derived-data profile separately from shared GeneratorConfig, refresh exact compatible IDs, and pin the complete original selectors and surviving routes. Retain all twelve beta suppressions and explicitly record the remaining intent_updateSetting literal-inventory blocker without unmerged helper schema. Module/configuration/naming/composite regressions: 162 passed; strict inventory honestly fails only the complete beta selector evidence comparison pending reviewed legacy translation.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate DeviceManagement v1.0 after merged variant support
78c59cb 
Run the complete queued compatible-spec Release pipeline on integrated powershell-v3 08e409a with Kiota1.36.1 serial generation and original Authentication2.38.1. Exit0/OK37.6s, 297 compiled exports; reviewed suppression1 absent and actual neighbors7 present. Combined client/cmdlet/project/lock regeneration preserves unchanged sources honestly and updates current-spec model closure and lock.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate DeviceManagement beta after merged composite routing
e2bec94 
Run the complete queued compatible-spec Release pipeline on integrated powershell-v3 with Kiota1.36.1 serial generation and original Authentication2.38.1. Exit0/OK64.9s, 1187 compiled exports; all15 reviewed suppressions absent, actual neighbors24 present. Preserve Beta casing and combined client/cmdlet/project/lock boundary. All six composite workers now compile; offline GET/DELETE escaped URLs and four WhatIf/declined Confirm checks pass. Actual PATCH serialization remains blocked by missing Microsoft.IO.RecyclableMemoryStream3.0.1 in the runtime package closure, and final strict legacy inventory remains blocked; no PR completion claimed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Complete DeviceManagement beta reviewed legacy bridge records
d376830 
Opt only directive1 beta into Legacy operation-ID evidence. Record exact old paths and IDs for the complete twelve-operation source set, including five action-kind-guarded final namespace translations and the differently qualified current intent action ID. Pin all exact bridges in module tests;49 targeted tests pass. Normal-target strict inventory still fails pending normal #3847 merge; no helper copy, merge waiver, generation change or runtime-dependency workaround.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Merge Authentication closure and aligned IDs for DeviceManagement acc…
0610766 
…eptance

Normally integrate powershell-v3 844672d without candidate overlays or rewriting prior migration and generation boundaries.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Finalize literal DeviceManagement evidence on merged Authentication t…
75fa54a 
…arget

Use normal finite-path operation-ID alignment for all twelve beta survivors, remove rejected Legacy integration fields, and retain independent complete original-source evidence. Explicitly pin emitted v1.0/beta transport profiles without per-profile authored filters. Ordinary strict inventory maps all four directives and final module/configurator/naming/emitter/composite tests pass179.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate DeviceManagement v1.0 on normal Authentication closure
363cc7f 
Full unchanged queued Release pipeline on normal844672 after final source75fa54a4: exit0/OK32.7s, 297 compiled exports. Regenerate combined client/cmdlet/project/lock output with packaged Authentication2.41.2 and Kiota1.36.1. Explicit v1.0 transport/default/item GET proof passes, reviewed suppression1 absent and neighbors7 present; generated bin contains only3ownedDLLs and no dependency preload.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate DeviceManagement beta on normal Authentication closure
03bd384 
Full unchanged queued Release pipeline on normal844672 after final source75fa54a4: exit0/OK114s, 1187 compiled exports. Combined Kiota/cmdlet/project/lock generation preserves Beta casing; explicit beta transport,3ownDLLs/no dependency preload,15suppressed routes absent and24neighbors present. Actual six composite workers preserve typed PATCH bodies, escaped same-route204GETrefetch, mandatory route/body distinction and safety. REQUIRED generic Headers on PATCH204GETrefetch fail for both parents, so no full runtime/PR completion is claimed pending normal3886; exact evidence preserved without globalpatch.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Merge final PATCH single-operation contract for DeviceManagement acce…
2940296 
…ptance

Normally integrate powershell-v3 6475f3f and preserve all prior source and separate profile generation history.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Pin DeviceManagement PATCH single-operation acceptance
69aac73 
Exercise actual normal-profile ordinary and composite workers with derived data on and off. Assert no implicit GET, retained typed-result guard, per-operation headers, explicit API roots and distinct composite route/body IDs. Independently prove no required native query inputs exist in either DeviceManagement compatible spec. Combined final module/naming/configuration/composite/required-query/PATCH regressions pass238 with nonempty TRX; ordinary inventory maps all4 directives.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate DeviceManagement v1.0 for single-operation PATCH
6292b85 
Fresh unchanged four-mutex full Release pipeline on normal6475 after finalsource69aac73: exit0/OK521.2s,297exports, followed by successful no-incremental Release rebuild. Combined Kiota/client/cmdlet/project/lock run preserves unchanged client output honestly and removes automatic PATCH readback. Actual Global runtime proves PATCH204 onePATCH/noobject withGET403 configured, PATCH200 typed onePATCH, independent explicit GET, typed POST/action/DELETE, headers, safety and normal Authentication closure.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
@ramsessanchez
Regenerate DeviceManagement beta for single-operation PATCH
df343d7 
Fresh unchanged four-mutex full Release pipeline on normal6475 after finalsource69aac73: exit0/OK748.9s,1187exports, followed by successful no-incremental Release rebuild. Combined Kiota/client/cmdlet/project/lock regeneration preserves unchanged client output honestly and Beta casing. Fresh Global/USGov full-module Factory proofs pass ordinary+bothcomposite PATCH204 onePATCH/noobject withGET403 configured and PATCH200 own typedmodel; explicit GET independent, distinct route/body IDs, escaped URLs, native headers and safety retained. No dependency copies/preloads or invented readback flags.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@ramsessanchez