Repository navigation
Conversation
mkarg
force-pushed
the
vibe/issue-5600-netty-read-timeout
branch
4 times, most recently
from
October 22, 2026 16:20
ff81611 to
a1726b4
Compare
- The test verifies ClientProperties.READ_TIMEOUT against a server that accepts the connection but never sends a response - The elapsed time assertion allows a 2s scheduling margin only, so it verifies the configured timeout rather than eventual termination - A @timeout(10) annotation fails the test deterministically if the connector regression makes the request hang forever - The silent server binds to port 0, so the test does not fail when a fixed port is already in use - All eclipse-ee4j#5600 scenarios pass on the current code, the issue is no longer reproducible Co-authored-by: mkarg <mkarg@users.noreply.github.com>
mkarg
force-pushed
the
vibe/issue-5600-netty-read-timeout
branch
from
October 22, 2026 16:23
a1726b4 to
4d4f0f2
Compare
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
1 Summary
Issue eclipse-ee4j#5600 reports that
NettyConnectordoes not respect timeouts: a request against a serverthat was shut down hangs despite
ClientProperties.CONNECT_TIMEOUTbeing set.The timeout handling in the current code works: the read timeout is implemented by an
IdleStateHandlerin the pipeline (NettyConnector#execute), theIdleStateEventis handled byJerseyClientHandler#userEventTriggered, which closes the channel, andJerseyClientHandler#channelInactivecompletes the response future with aTimeoutException.The connect timeout is passed to the
BootstrapviaChannelOption.CONNECT_TIMEOUT_MILLIS.This PR adds a regression test that verifies
ClientProperties.READ_TIMEOUTagainst a serverthat accepts the connection but never sends a response.
2 Verification
All scenarios from eclipse-ee4j#5600 were executed against the current code:
READ_TIMEOUTagainst a server that accepts the connection but never responds:the request fails with a
ProcessingExceptioncaused by aTimeoutExceptionwithinthe configured read timeout (new test
ReadTimeoutRespectedTest, ~2s for a 2s timeout)with
CONNECT_TIMEOUT=30s: fails immediately withConnection refused, no hangCONNECT_TIMEOUT=3sagainst a non-routable address (dropped SYN, no RST):fails with
ConnectTimeoutException: connection timed out after 3000 msafter ~3.5sThe existing tests still pass:
The issue is no longer reproducible; the reporting user never replied to the reproducer
results in the issue.
Closes eclipse-ee4j#5600