Repository navigation
[Server] Drop null from DocBlockParser::parseDocBlock() - #633
Merged
chr-hertel merged 2 commits intoOct 27, 2026
Merged
Conversation
chr-hertel
requested review from
CodeWithKyrian,
Nyholm and
soyuka
as code owners
October 27, 2026 20:29
chr-hertel
changed the title
?? null on getDocComment()null from DocBlockParser::parseDocBlock()
chr-hertel
added
breaking change
chr-hertel
added a commit
to Adebayo120/php-sdk
that referenced
this pull request
Oct 27, 2026
…nsport-leak-on * origin/main: [Capability] Keep a nullable or union key of an array shape inside the shape (modelcontextprotocol#613) chore(deps): bump the npm_and_yarn group across 1 directory with 3 updates (modelcontextprotocol#632) [Server] Drop `null` from `DocBlockParser::parseDocBlock()` (modelcontextprotocol#633) chore(deps): bump astral-sh/setup-uv from 10.3.0 to 10.3.2 (modelcontextprotocol#628)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PHPStan 2.3.3 flags
getDocComment() ?? nullasnullCoalesce.expr:getDocComment()returnsstring|false, nevernull. Drops the no-op coalesce and narrowsparseDocBlock()tostring|falseto match, so callers passgetDocComment()as is. Unblocks theqajob on open PRs, e.g. #632.🤖 Generated with Claude Code