Skip to content

fix(client): bound initialized handshake timeout - #3079

Open
YingzuoLiu wants to merge 3 commits into
modelcontextprotocol:mainfrom
YingzuoLiu:fix/client-connect-handshake-timeout-3078
Open

YingzuoLiu wants to merge 3 commits into
modelcontextprotocol:mainfrom
YingzuoLiu:fix/client-connect-handshake-timeout-3078

Conversation

@YingzuoLiu

Copy link
Copy Markdown

Summary

  • Bound the legacy notifications/initialized POST by Client.connect()'s timeout and abort signal.
  • Pass a per-message abort signal to the transport and reject connect() promptly even if a custom transport does not honor that signal.
  • Add regression coverage for timeout and caller-abort behavior.

Fixes #3078

Tests

  • @modelcontextprotocol/client: 1,070 tests passed.
  • @modelcontextprotocol/core-internal: 1,836 tests passed.
  • Typecheck and lint passed for both packages.

@YingzuoLiu
YingzuoLiu requested a review from a team as a code owner October 23, 2026 13:49
@changeset-bot

changeset-bot Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: df87cb8

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 6 packages
Name Type
@modelcontextprotocol/client Patch
@modelcontextprotocol/core-internal Patch
@modelcontextprotocol/codemod Patch
@modelcontextprotocol/core Patch
@modelcontextprotocol/server-legacy Patch
@modelcontextprotocol/server Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@pkg-pr-new

pkg-pr-new Bot commented Oct 23, 2026 •

Copy link
Copy Markdown

Open in StackBlitz

@modelcontextprotocol/client

npm i https://pkg.pr.new/@modelcontextprotocol/client@3079

@modelcontextprotocol/codemod

npm i https://pkg.pr.new/@modelcontextprotocol/codemod@3079

@modelcontextprotocol/core

npm i https://pkg.pr.new/@modelcontextprotocol/core@3079

@modelcontextprotocol/server

npm i https://pkg.pr.new/@modelcontextprotocol/server@3079

@modelcontextprotocol/server-legacy

npm i https://pkg.pr.new/@modelcontextprotocol/server-legacy@3079

@modelcontextprotocol/express

npm i https://pkg.pr.new/@modelcontextprotocol/express@3079

@modelcontextprotocol/fastify

npm i https://pkg.pr.new/@modelcontextprotocol/fastify@3079

@modelcontextprotocol/hono

npm i https://pkg.pr.new/@modelcontextprotocol/hono@3079

@modelcontextprotocol/node

npm i https://pkg.pr.new/@modelcontextprotocol/node@3079

commit: df87cb8

@claude claude Bot added the v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes label Oct 24, 2026

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

v2 Ideas, requests and plans for v2 of the SDK which will incorporate major changes and fixes

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[v2] Client.connect(): timeout and signal do not bound the notifications/initialized POST

1 participant