Repository navigation
fix(agents): warn about unowned data with auth - #12669
Merged
Merged
Conversation
Warn before the standalone pool starts root agents with user auth enabled. Count root agents, collections, skills, and configured skill repositories. Document the auth transition, bootstrap rules, and agent key behavior. Addresses the warning and documentation step of #12665. Admin visibility and data migration remain separate work. Assisted-by: Codex:GPT-6
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Enabling user auth on an existing standalone instance leaves root agent data outside authenticated users' storage. Startup now warns before agents start, with counts of root agents, collections, skills, and configured skill repositories. The warning links to guidance covering backups, bootstrap registration, agent state, and API keys.
Addresses the first, independently useful step in #12665. This does not close the issue: admin visibility and opt-in migration remain follow-up work. The warning does not change ownership or agent execution. It excludes user-owned resources and honors the configured collection path.
Notes for Reviewers
c44c32f15, checked again before committing.CGO_ENABLED=0 go test ./core/services/agentpool -run TestServices -ginkgo.focus='legacy auth warning' -count=1.CGO_ENABLED=0 go vet ./core/services/agentpool/...andgit diff --check.make lintcould not run because this environment lacks make. The installed golangci-lint binary also cannot execute here. Full lint remains for CI.GOPROXY=directbecause proxy.golang.org returned Forbidden. No dependency versions changed.Signed commits
Assisted-by.