Repository navigation
Modified files with CRLF block CI #1443
Description
See https://ci.nodejs.org/job/node-test-commit-v8-linux/1590/nodes=rhel72-s390x,v8test=v8test/console
This has happened multiple times now. Is there something we can do to prevent running into this situation?
...
13:53:24 # Untracked files:
13:53:24 # (use "git add <file>..." to include in what will be committed)
13:53:24 #
13:53:24 # build/
13:53:24 # depot_tools/
13:53:24 no changes added to commit (use "git add" and/or "git commit -a")
...
13:53:24 + git rebase --committer-date-is-author-date origin/master
13:53:24 Cannot rebase: You have unstaged changes.
Activity
joyeecheung commentedon Aug 14, 2018
It's not untracked files that block the CI, but modified files. Specifically,
deps/v8/third_party/jinja2/LICENSEwhich uses CRLF. See nodejs/reliability#12 (comment) and nodejs/reliability#12 (comment)This also happens in regular CI and has failed 12 out of 20 recent PR CI runs (tonight in my time zone)
[-]Untracked files block v8 CI[/-][+]Modified files with CRLF block CI[/+]deps: fix CRLF in text file not present in upstream
deps: fix CRLF in text file not present in upstream
deps: fix CRLF in text file not present in upstream
deps: fix CRLF in text file not present in upstream
refack commentedon Sep 25, 2018
I think this has been resolved on the two fronts.
deps/v8/third_party/jinja2/LICENSEwas normalizedautocrlf&safecrlfwas disabled on as many CI worker as possible.I'm not sure of any further actionable items. If noone has any suggestion we could close this issue.
BridgeAR commentedon Nov 13, 2018
@refack thanks a lot!