Skip to content

markdown special symbols in commit description should be escaped #47

Closed

Description

@ChALkeR

The commit messages are initially in text, so rendering them as Markdown can cause errors.

To reproduce, in node, do:

$ changelog-maker --start-ref=9eddaebb --end-ref=9eddaebb
* [[`9eddaebb79`](https://github.com/nodejs/node/commit/9eddaebb79)] - **assert**: remove unnecessary use of __proto__ (Nathan Rajlich) 

If a changelog includes __proto__, we don't want it to render as «proto», we want to render it as «__proto__» or «__proto__». Without knowing more if that is code block or not, it would make sense to just escape some symbols like `_*~\, prefixing those with \.

Refs: nodejs/node#a58b48bc3bc, nodejs/node#7637, nodejs/node#12756 (comment).

Activity

  1. changed the title [-]changelog-maker should escape markdown special symbols in commit description[/-] [+]markdown special symbols in commit description should be escaped[/+] on May 1, 2017
  2. wooorm commented on May 1, 2017

    @wooorm

    Hi folks! 👋

    Shameless plug, but maybe remark can help here, as it automatically deals with escapes and stuff! Here’s an example of how it could look, where a readme is generated from a package.json in a monorepo.

    Let me know if that’s of interest!

  3. MylesBorins commented on Feb 13, 2018

    @MylesBorins
    Contributor

    BUMP to this

    This actually broke CI today as it broke the markdown linter

    nodejs/node#18767

  4. added a commit that references this issue on Mar 1, 2018
    1352412
  5. rvagg commented on Mar 1, 2018

    @rvagg
    Member

    fixed in #52, pls 👍

  6. added a commit that references this issue on Mar 1, 2018
    2b5a600
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions