Fix napi_create_reference to work correctly with integers #380

Activity

1. kfarnung

   assigned

   MSLaguana

   on Aug 26, 2017
2. kfarnung

   added a commit that references this issue on Aug 26, 2017

   test: fixing new test issues

   ...

   7cda2d1
3. MSLaguana commented on Sep 7, 2017

   

   MSLaguana

   on Sep 7, 2017

   Contributor

   More actions

   It looks like test_general/test has continued to evolve and is broken for an additional reason now: It attempts to create an object, wrap it, lose the JS reference to the object, force a GC, and ensure that the finalizer passed when wrapping was called. At the moment it looks like we might be mid-gc when the JS tries to force a gc, and so we complete that GC but it doesn't delete the only-just-now-created object.

   Other than that, there is some discussion about whether it makes sense to create references to primitive values at nodejs/node-addon-api#131
4. gabrielschulhof commented on Sep 7, 2017

   

   gabrielschulhof

   on Sep 7, 2017 via email

   More actions

   Honestly, I would prefer that ChakraCore be able to create references to primitive values, if only because there might be some obscure case out there in the wild where this is happening. Yet, if it's not feasible, I can submit a PR that modifies test_general to not attempt to create references to primitives. After all, that is not the purpose of that test. The reference to the primitive is used only as a test payload for the object wrap.

   …

   On Thu, Sep 7, 2017 at 9:30 PM, Jimmy Thomson ***@***.***> wrote: It looks like test_general/test has continued to evolve and is broken for an additional reason now: It attempts to create an object, wrap it, lose the JS reference to the object, force a GC, and ensure that the finalizer passed when wrapping was called. At the moment it looks like we might be mid-gc when the JS tries to force a gc, and so we complete that GC but it doesn't delete the only-just-now-created object. Other than that, there is some discussion about whether it makes sense to create references to primitive values at nodejs/node-addon-api#131 <nodejs/node-addon-api#131> — You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub <#380 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AA7k0cZ3HoGrA4_-UfTEj4Ai-L-pNU8Fks5sgDZCgaJpZM4PDVIA> .
5. digitalinfinity commented on Sep 8, 2017

   

   digitalinfinity

   on Sep 8, 2017

   Contributor

   More actions

   @gabrielschulhof semantically, what does a reference to a primitive mean if a primitive is not heap allocated? ChakraCore's JSRT returns JsValueRefs that are opaque (can be either pointers to heap allocated objects or primitive values)- are you suggesting in the case of primitive values, we always return boxed (heap allocated) values? That seems to be a rather expensive perf cost for supporting obscure cases, no? Alternatively, if you're not suggesting that, then when you say that we create references to primitive values, are you suggesting that we box the value as part of the CreateWeakReference api? That also seems fraught since that value would get collected at the next GC since no one would have a strong handle to that, just a weak one.

   So it's unclear what the desired behavior should be. My instinct is that if napi has a chance to define this behavior more concretely right now, we should just say that napi_create_weakreference can return an error if the napi_value passed in can't be weakly referenced- that exposes some concept of VM internals but then again, so does napi_create_weakreference, and this approach allows VM vendors to not be "boxed in" 😄
6. gabrielschulhof commented on Sep 9, 2017

   

   gabrielschulhof

   on Sep 9, 2017

   More actions

   I think it's pretty safe to return napi_invalid_arg for values that cannot be referenced. Any engine worth its salt should be able to provide persistent references to objects and functions. V8 is known to have features that are redundant, or have been rendered redundant by its evolution.

   We might even go so far as to document that only objects and functions can be retained as napi_refs. After all, primitive values are better stored as their native equivalents.
7. gabrielschulhof commented on Sep 9, 2017

   

   gabrielschulhof

   on Sep 9, 2017

   More actions

   In fact, we document that the napi_value to which a reference is created must be an object. So, I was basically abusing the napi_create_reference() mechanism. My bad.
8. gabrielschulhof

   added 2 commits that reference this issue on Sep 9, 2017

   n-api: stop creating references to primitives

   ...

   2b78ff9

   n-api: stop creating references to primitives

   ...

   cb94905
9. addaleax

   added a commit that references this issue on Sep 13, 2017

   n-api: stop creating references to primitives

   ...

   d4c9da4
10. jasnell

    added a commit that references this issue on Sep 20, 2017

    n-api: stop creating references to primitives

    ...

    d5b3002
11. MSLaguana

    closed this as completedin #406on Sep 29, 2017
12. MylesBorins

    added a commit that references this issue on Apr 16, 2018

    n-api: stop creating references to primitives

    ...

    676cff4