require.resolve() fails with an empty options object #28077

Activity

1. cjihrig commented on Jun 5, 2019

   

   cjihrig

   on Jun 5, 2019

   Contributor

   More actions

   This should be the fix:

   diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
   index 5cb88da189..98cfe02a97 100644
   --- a/lib/internal/modules/cjs/loader.js
   +++ b/lib/internal/modules/cjs/loader.js
   @@ -601,10 +601,11 @@ Module._resolveFilename = function(request, parent, isMain, options) {
        } else if (options.paths !== undefined) {
          throw new ERR_INVALID_OPT_VALUE('options.paths', options.paths);
        }
   -  } else {
   -    paths = Module._resolveLookupPaths(request, parent);
      }
    
   +  if (paths === undefined)
   +    paths = Module._resolveLookupPaths(request, parent);
   +
      // Look up the filename first, since that's the cache key.
      const filename = Module._findPath(request, paths, isMain);
      if (!filename) {

   PR coming.
2. cjihrig

   added a commit that references this issue on Jun 11, 2019

   module: handle empty require.resolve() options

   ...

   58fc168
3. cjihrig

   closed this as completedin #28078on Jun 11, 2019
4. BridgeAR

   added a commit that references this issue on Jun 17, 2019

   module: handle empty require.resolve() options

   ...

   6014429