Skip to content

crypto: fix use-after-free risk in ManagedX509 assignment #62742

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
omghante wants to merge 1 commit into
base: main
Choose a base branch
from
Open

crypto: fix use-after-free risk in ManagedX509 assignment #62742

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/crypto/crypto_x509.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,6 +95,8 @@ X509Pointer ParseCertificate(const X509CertificateSnapshot::DER& certificate) {

} // namespace

// ManagedX509 is non-copyable to prevent multiple smart pointers managing the
// same raw pointer (Coverity 367349); ownership transfer is explicit via Adopt.
ManagedX509::ManagedX509(X509Pointer cert) : cert_(std::move(cert)) {}

std::shared_ptr<ManagedX509> ManagedX509::Adopt(X509Pointer cert) {
Expand Down
2 changes: 2 additions & 0 deletions src/crypto/crypto_x509.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,6 +24,8 @@ class ManagedX509 final : public MemoryRetainer {
public:
static std::shared_ptr<ManagedX509> Adopt(ncrypto::X509Pointer cert);

// Prevent Coverity 367349: copy and copy-assignment are deleted to avoid
// multiple smart pointers managing the same raw pointer.
ManagedX509(const ManagedX509&) = delete;
ManagedX509& operator=(const ManagedX509&) = delete;

Expand Down
Loading