Repository navigation
Add new contributors (October 2018) #1872
Description
nodejs/nodejs.org committers since 2018-07-01, which aren't contributors yet:
* ZYSzys (ZYSzys)
* academo (Esteban Beltran)
* e-jigsaw (jigsaw)
* suensummit (Summit Suen)
* flowkraD (Prateek Nayak)
* Ginden (Michał Wadas)
* petetnt (Pete Nykänen)
* tehkaiyu (Kaiyu Hsu)
* pboi20 (Patrick Boivin)
* trevorah (Andy Trevorah)
* chakravarthysm (Chakravarthy S M)
* paranoidjk (paranoidjk)
* richardlau (Richard Lau)
* tombusby (Tom Busby)
* nickmccurdy (Nick McCurdy)
* belhassen07 (Belhassen Chelbi)
* taggon (Taegon Kim)
Also, please add @AliSawari, @m-esm, @armanatory and @anio to @nodejs/nodejs-fa.
Thanks everyone for your contributions!
Reacted by ZYSzys, Waleed Ashraf, Nicky McCurdy and Esteban Beltran
Reacted by ZYSzys, Waleed Ashraf, Ali Sawari, Mohsen Esmaeili and Tom Busby
Activity
Trott commentedon Oct 31, 2018
All done. (@anio was already a member of
@nodejs/nodejs-fa.)fhemberger commentedon Oct 31, 2018
Awesome, thanks a lot!
I wish there was a way we could automate this process, so I don't have to bother you all the time.
Trott commentedon Oct 31, 2018
@fhemberger You are a Maintainer of the team and should be able to do this yourself, actually. If it's not working or if you're not sure of the process, let's chat in IRC or email and figure it out.
nickserv commentedon Oct 31, 2018
Thank you for the invite!
In the future it may be more convenient to remove the code block formatting, it disables GitHub's mention feature which automatically sends notifications.
fhemberger commentedon Oct 31, 2018
@Trott As a maintainer, I can only invite users to the team if they are already a member of the org. But I can't add them to the org itself, only org admins can do that
Trott commentedon Oct 31, 2018
Oh, that's right! We go through this every time, don't we? :-D I always forget...
FWIW, a few of the people above were already members so you could have added them, I suppose. But most were not...
fhemberger commentedon Nov 1, 2018
@Trott Yes indeed. :D
Would be nice if we could automate this. Could we use a bot or something that adds new contributors e.g. once a month?
How do other teams of the org handle the onboarding of new members?
Trott commentedon Nov 1, 2018
/ping @nodejs/automation @nodejs/github-bot
No other team has this team's combination of large number of members and permissive rules for being added. So it's not an issue for other teams, I don't think.
addin new team members
phillipj commentedon Nov 1, 2018
Making the bot add people automatically once a month surely sounds feasible. It's a Node.js process running reacting to incoming webhooks, and adding a scheduled job to that code base shouldn't be a problem IMO.
The biggest challenge is inviting people to the org as you mention. Currently the bot does not have privileges to do so. There has been discussions on providing such privileges but IIRC there has been several concerns raised about the security implications, which I've understood as the main reason we havent done so yet.
Might be worthwhile triggering those discussions again though. Maybe there's ways around what was raised back then that makes it less off a concern now.
JasonEtco commentedon Nov 1, 2018
Hey folks - I'm not sure what the historical reasoning is for a monthly cadence, but if you were interested in adding all new PR authors to the Org when the PR is merged, there's a Probot app that already exists: https://probot.github.io/apps/invite-contributors. You'd want to either install this GitHub App, or deploy your own instance of it. I think some of y'all are familiar with Probot, but if not feel free to ping me.
bnb commentedon Nov 2, 2018
@Trott @fhemberger any objections to installing the app for this repo?
Trott commentedon Nov 2, 2018
Probably depends on what privileges it needs and whether it needs them on this repo only or for the org. I'm generally positive if it's for the repo only, and generally a bit reluctant if it's for the whole org.
fhemberger commentedon Nov 2, 2018
@JasonEtco The only historical reasoning is that it was a manual step (until now) to determine new contributors and invite them. Therefore in the past it was only done rarely, so I tried to do do it at least quarterly.
So yes, if the privileges are not an issue, I'm in favor for using the bot instead!
fhemberger commentedon Nov 6, 2018
@Trott Okay, who can help us set up the Probot app on this repo?
JasonEtco commentedon Nov 6, 2018
FYI, here are the permissions its requesting:
My impression is that most of those permission requests are unnecessary, and if that's a problem then we could build the app ourselves (it should be fairly straightforward and this existing app is open source) and then deploy it. That's more of a time-investment of course. (I'm not volunteering, just laying out some options 😬)
Trott commentedon Nov 6, 2018
@fhemberger I'm not sure there are clear guidelines, but probably the best thing to do is open an issue in the nodejs/admin repo explaining what and why.