Repository navigation
Description
Closed as done in #123 (squash 11cb965). Every box below was checked against main.
PR #121 (merged as 8037810) shipped the browser tool router and the external Playwright tier. This is phase 1, PR 1 of the browser tiers design in docs/adr/browser-tiers.md and docs/requirements/browser-tiers.md (issue #118). Review found no HIGH findings. This issue collects the MEDIUM and LOW follow-ups.
Out of scope here and tracked in #118: the stdio managed Playwright child (later phase 1 PRs), the wizard page, on-demand install, and the Apple Events tier.
MEDIUM
- 1. PortOwnerProbe matches only the local port. It checks neither address family nor loopback address, so a same-uid listener on
127.0.0.1:<port>can approve a request to::1:<port>. Pass the validated endpoint into the probe. Add a test with simultaneous IPv4 and IPv6 listeners.- Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: the probe takes the validated endpoint (family and address); tested with simultaneous IPv4 and IPv6 listeners.
- 2. ExternalPlaywrightClient.healthCheck re-runs
initializeevery 30 s.- It overwrites the session id.
- It never sends DELETE for old sessions.
- It uses the 90 s request timeout, while R2 allows 2 s.
- Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: a live session is pinged with a 2 s timeout,
initializeruns only without a session, and a replaced session is deleted.
LOW
- Health check timeout should be 2 s (R2), not 90 s (PlaywrightBackend / ExternalPlaywrightClient). Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123 (2 s).
- BrowserRouter does three owner probes plus an extra
tools/listpertools/call. Reduce. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123 by caching, not by fewer calls: atools/callstill reaches the owner check three times, but a success is reused for 2 s (one real check per call) andtools/listis served from a 30 s cache. -
PlaywrightBackend.tools()turns a transient error into[]. Propagate or keep the last known list. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: the last known list is kept (still[]if none was ever fetched). - R1.6 and R7.5.5 reporting is not wired up:
modeandownerSummaryare missing fromsys_infoand the menu, and there is nostructuredContent.backend. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123:modeandownerSummaryinsys_infoand the menu, plusstructuredContent.backend. - The BrowserRouter guard map
lastis never pruned. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: the guard map is pruned by age and size. - The browser upstream port is not range-checked in
main.swift. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: the port must be 1-65535, otherwise exit 64. - A repeated
--upstream browser=flag is dropped silently. Reject it or take the last value, and say so. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: a repeated--upstream browser=is rejected (exit 64). - The Host header for
::1is sent without brackets. It should be[::1]:<port>. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: the Host header brackets IPv6 literals. - The
BrowserCatalogTeststailscale scan is case-sensitive, while the shell guard usesgrep -i. Make the Swift scan case-insensitive. Fixed in feat: stdio MCP client and managed Playwright tier (browser tiers phase 1, PR 2) #123: the scan is case-insensitive.
Original body
PR #121 (merged as 8037810) shipped the browser tool router and the external Playwright tier. This is phase 1, PR 1 of the browser tiers design in docs/adr/browser-tiers.md and docs/requirements/browser-tiers.md (issue #118). Review found no HIGH findings. This issue collects the MEDIUM and LOW follow-ups.
Out of scope here and tracked in #118: the stdio managed Playwright child (later phase 1 PRs), the wizard page, on-demand install, and the Apple Events tier.
MEDIUM
- 1. PortOwnerProbe matches only the local port. It checks neither address family nor loopback address, so a same-uid listener on
127.0.0.1:<port>can approve a request to::1:<port>. Pass the validated endpoint into the probe. Add a test with simultaneous IPv4 and IPv6 listeners. - 2. ExternalPlaywrightClient.healthCheck re-runs
initializeevery 30 s.- It overwrites the session id.
- It never sends DELETE for old sessions.
- It uses the 90 s request timeout, while R2 allows 2 s.
LOW
- Health check timeout should be 2 s (R2), not 90 s (PlaywrightBackend / ExternalPlaywrightClient).
- BrowserRouter does three owner probes plus an extra
tools/listpertools/call. Reduce. -
PlaywrightBackend.tools()turns a transient error into[]. Propagate or keep the last known list. - R1.6 and R7.5.5 reporting is not wired up:
modeandownerSummaryare missing fromsys_infoand the menu, and there is nostructuredContent.backend. - The BrowserRouter guard map
lastis never pruned. - The browser upstream port is not range-checked in
main.swift. - A repeated
--upstream browser=flag is dropped silently. Reject it or take the last value, and say so. - The Host header for
::1is sent without brackets. It should be[::1]:<port>. - The
BrowserCatalogTeststailscale scan is case-sensitive, while the shell guard usesgrep -i. Make the Swift scan case-insensitive.
Activity
feat: stdio MCP client and managed Playwright tier (browser tiers pha…
chaodu-agent commentedon Nov 16, 2026
done in #123