Skip to content

Wizard wiring tests: eight low-priority follow-ups #154

Closed

Description

@chaodu-agent

Low-priority leftovers from the review of #151 (wizard wiring tests, closes #129). None blocks.

  • The main.swift / StatusItemController checks are source-text regex/substring matches. They catch the intended mutations but break on a harmless reformat or a renamed local.
  • The source guard does not check that main.swift passes browserTools on to StatusItemController / PermissionSetupWindowController (around main.swift:508). Passing nil would reproduce the original symptom and still pass.
  • No test pins the if model.isInstalling { return .failed } line in remove().
  • testStartInstallRefusesASecondInstall... uses a fixed 300 ms sleep; the XCTAssertFalse(second) assertion already covers the case.
  • testClosingThePageWithoutCompletingItDoesNotCompleteIt only calls pageShown(); the window close is not simulated.
  • The source guard locates files through #filePath and needs the source tree at test time.
  • The whole BrowserToolsController API is now public in InstanceMCPCore, which widens the library surface.
  • "closes Browser tools wizard: tests do not cover the production wiring (follow-up from PR #127 review) #129" closed the issue while the UI-layer checkbox is only partly addressed and other items are only documented. Decide whether a separate issue is needed for the rest.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    p3Priority 3: RFC, roadmap, nice-to-have or deferred

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions