You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Low-priority leftovers from the review of #151 (wizard wiring tests, closes #129). None blocks.
The main.swift / StatusItemController checks are source-text regex/substring matches. They catch the intended mutations but break on a harmless reformat or a renamed local.
The source guard does not check that main.swift passes browserTools on to StatusItemController / PermissionSetupWindowController (around main.swift:508). Passing nil would reproduce the original symptom and still pass.
No test pins the if model.isInstalling { return .failed } line in remove().
testStartInstallRefusesASecondInstall... uses a fixed 300 ms sleep; the XCTAssertFalse(second) assertion already covers the case.
testClosingThePageWithoutCompletingItDoesNotCompleteIt only calls pageShown(); the window close is not simulated.
The source guard locates files through #filePath and needs the source tree at test time.
The whole BrowserToolsController API is now public in InstanceMCPCore, which widens the library surface.
Activity
test: close HTTP and wizard test gaps (#163)