Repository navigation
Closed
Labels
enhancementNew feature or requestNew feature or requestp3Priority 3: RFC, roadmap, nice-to-have or deferredPriority 3: RFC, roadmap, nice-to-have or deferred
Description
Non-blocking findings from the review of #159 at head 8b41cca (2 MEDIUM, 4 LOW). Each was re-checked against current main (106f6a0) and still applies.
MEDIUM
-
testSessionResetMidListingStillHonorsTheOverallBudget(Tests/InstanceMCPCoreTests/ToolListPaginationTests.swift) also passes without the fix. Before fix: one overall deadline for listing tools over HTTP (closes #153) #159, the same script returnsplaywright_timeoutat about 1.6 s: the retry gets its own 1.5 s timeout and succeeds, then the next-page check inToolListPagination.collectthrows. That satisfies bothXCTAssertEqual(k, "playwright_timeout")andXCTAssertLessThan(..., .seconds(2.3)), so the test cannot tell the fix from the old code. Make only the retriedtools/listslow (for example 2 s, so it ends past 2.8 s without the fix), or tighten the elapsed bound to just above the 1.5 s budget. - No dedicated test for the total tool cap.
testServerProtocolListErrorsDoNotCountAsChildFailures(Tests/InstanceMCPCoreTests/ManagedPlaywrightTests.swift) covers the page cap, repeated cursor and bad cursor, but never drivestools_list_too_many_tools, althoughManagedPlaywright.isServerProtocolErrorlists it. Add a mode that returns more thanToolListPagination.maxToolsentries and check that repeated failures leave the transport unlatched with unchanged backoff.
LOW
-
ManagedPlaywright.isServerProtocolError:noteFailurealready reduced tonoteFailureIfDead()for every class exceptplaywright_timeout, so the branch only makes the intent explicit. The managed protocol-error test would also pass without fix: one overall deadline for listing tools over HTTP (closes #153) #159, so it pins existing behavior rather than a change. -
ExternalPlaywrightClient: a single-page HTTP server that stalls past the timeout now reportsplaywright_timeoutinstead ofupstream_timeout, because the per-request timeout equals the budget. This is intended, andPlaywrightBackend.tools()discards the class (try?), so nothing visible changes. Consider noting it in R7.5.4. -
ToolListPagination.collectstill measures its overall deadline withDate()(wall clock). This predates fix: one overall deadline for listing tools over HTTP (closes #153) #159 and only affects stdio. Move it toContinuousClock. -
ExternalPlaywrightClient.listToolsstill callscollect(deadline: .infinity), which leaves a dead wall-clock computation in the HTTP path. Acollectoverload without a deadline would be clearer.
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requestp3Priority 3: RFC, roadmap, nice-to-have or deferredPriority 3: RFC, roadmap, nice-to-have or deferred
Activity