Repository navigation
docs: README network interfaces and ports - #113
Merged
Merged
Conversation
Ran: PATH=~/.nvm/versions/node/v22.20.0/bin npx markdownlint-cli2@0.17.2 README.md (repo .markdownlint-cli2.jsonc) -> Summary: 0 error(s). Note CI globs only docs/**/*.md. Facts from .agents/tasks/readme-network/facts.md (code at main 0.12.0 plus a read-only observation of a macmini agent, 0.10.1). No build run.
…ream, auth) Ran: PATH=~/.nvm/versions/node/v22.20.0/bin npx markdownlint-cli2@0.17.2 README.md (repo .markdownlint-cli2.jsonc) -> Summary: 0 error(s). CI globs only docs/**/*.md. Findings checked against code before editing: - poc/pw-mcp/install.sh:36 (serve --https=8443 -> 127.0.0.1:8794), pw-mcp.sh:9: added 8443 row, no auth, off command. - poc/reverse-attach-linux/src/platform/linux/seat.rs:23,252,330: Wayland UnixStream client, scoped never-list to macOS. - scripts/install-linux.sh:19,91,130,146,155: Linux Playwright unit, MCP_UPSTREAM, --no-browser. - main.swift --upstream takes any URL; AuthPolicy checks only configured items: qualified. LOW: --path, IPv4 loopback, probe bind, app-process scope. No build run.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
Adds a "Network interfaces and ports" section to the README (after Auth, plus a Contents link). Docs only. It covers listening sockets, outbound connections, what the app never does, how to expose it, and macOS versus Linux differences.
Version: the app version on
mainis 0.12.0 and the latest release is v0.11.0 (.agentsversions.txt agrees). The README describesmain, not the release.How the facts were established
MCPHTTPEndpoint.swift,AuthPolicy.swift,main.swift,FirstRunSetup.swift,AttachManager.swift,ReverseAttachClient.swift,Switchboard.swift,UpstreamMCP.swift,scripts/install-prebuilt.sh,scripts/install-linux.sh,poc/reverse-attach-linux/src/{http,auth,attach}, plus greps for UDP, Unix sockets and extra listeners. Nothing was built or run.Differences between code and observation
:443are unrelated and left out.poc/pw-mcp/install.shmaps tailnet:8443to 8794 with no token. Not seen on the test Mac. Now documented in the README as a PoC installer mapping, separate from the app's sockets (review fix).Not verified
Identity of the loopback clients, whether the switchboard socket is up, who starts Playwright on the test Mac, 0.12.0 behaviour under an installed LaunchAgent, anything on Linux (not run), and a non-loopback
--host(never run). Linux and IPv6 are labelled "not verified" in the README.Lint
npx markdownlint-cli2@0.17.2 README.mdwith the repo config: 0 errors. CI's job globs onlydocs/**/*.md, so it does not lint the README.Update (review fix): added the :8443 row and off command, Linux Wayland client socket and Playwright unit, the upstream URL wording, and auth qualified as the installer default.