Skip to content

Fix Leaderboard: convert NaN into 0% - #1190

Merged
scottanderson merged 2 commits into
mainfrom
leaderboard-nan
Jun 16, 2025
Merged

scottanderson merged 2 commits into
mainfrom
leaderboard-nan

Conversation

@VariableVince

@VariableVince VariableVince commented Jun 16, 2025 •

Copy link
Copy Markdown
Contributor

Description:

In edge cases, where all land is fallout, Owned % could be NaN%. Have it converted to 0% in such cases.

https://discord.com/channels/1359946986937258015/1383735051195514880

BEFORE:
Before

AFTER:
It's a little hard to test (especially when currently you can't get in the old build menu and the new radial menu doesn't let you nuke yourself). But the code speaks for itself i hope.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
  • I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

Please put your Discord username so you can be contacted if a bug or regression is found:

tryout33

@coderabbitai

coderabbitai Bot commented Jun 16, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

A check was added to the formatPercentage function in the leaderboard graphics layer to handle cases where the computed percentage is NaN. Now, if a NaN value is encountered, the function returns "0%". No other logic or exported declarations were changed.

Changes

File(s) Change Summary
src/client/graphics/layers/Leaderboard.ts Added a NaN check to formatPercentage to return "0%" for invalid numbers

Suggested labels

Bug Fix

Suggested reviewers

  • evanpelle

Poem

When numbers go wild and stray from the plan,
Now "0%" shows up if the value is NaN.
No more confusion, no more dismay—
The leaderboard’s logic keeps errors at bay!
🎉

Warning

There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure.

🔧 ESLint

If the error stems from missing dependencies, add them to the package.json file. For unrecoverable errors (e.g., due to private dependencies), disable the tool in the CodeRabbit configuration.

npm error Exit handler never called!
npm error This is an error with npm itself. Please report this error at:
npm error https://github.com/npm/cli/issues
npm error A complete log of this run can be found in: /.npm/_logs/2025-06-16T01_10_03_555Z-debug-0.log


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a127f7a and c2e1be4.

📒 Files selected for processing (1)
  • src/client/graphics/layers/Leaderboard.ts (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • src/client/graphics/layers/Leaderboard.ts
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Deploy to openfront.dev

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/client/graphics/layers/Leaderboard.ts (1)

283-290: Use Number.isNaN & guard early for clarity

Good call adding the NaN → "0%" fallback.
Two micro-improvements keep the code idiomatic:

  1. Prefer Number.isNaN over the global isNaN. The global version silently coerces non-numbers, which can hide bugs.
  2. Bail out before the range comparisons so the intent (“invalid value ⇒ 0%”) is immediately visible.
function formatPercentage(value: number): string {
   const perc = value * 100;

+  // Guard: invalid number
+  if (Number.isNaN(perc)) return "0%";
+
   if (perc > 99.5) return "100%";
   if (perc < 0.01) return "0%";
   if (perc < 0.1) return perc.toPrecision(1) + "%";
-  if (isNaN(perc)) return "0%";
   return perc.toPrecision(2) + "%";
 }

Very small change, but it reads nicer and avoids an unnecessary coercion.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 43c98e5 and a127f7a.

📒 Files selected for processing (1)
  • src/client/graphics/layers/Leaderboard.ts (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
  • GitHub Check: Deploy to openfront.dev

@VariableVince
VariableVince marked this pull request as ready for review June 16, 2025 01:08
@VariableVince
VariableVince requested a review from a team as a code owner June 16, 2025 01:08
@VariableVince
VariableVince requested a review from evanpelle June 16, 2025 01:08
@scottanderson scottanderson added this to the v24 milestone Jun 16, 2025
@github-project-automation github-project-automation Bot moved this from Triage to Final Review in OpenFront Release Management Jun 16, 2025
@scottanderson
scottanderson merged commit 3894945 into main Jun 16, 2025
@scottanderson
scottanderson deleted the leaderboard-nan branch June 16, 2025 01:17
@github-project-automation github-project-automation Bot moved this from Final Review to Complete in OpenFront Release Management Jun 16, 2025
@VariableVince VariableVince self-assigned this Jun 16, 2025
evanpelle pushed a commit that referenced this pull request Jun 18, 2025
## Description:

In edge cases, where all land is fallout, Owned % could be NaN%. Have it
converted to 0% in such cases.

https://discord.com/channels/1359946986937258015/1383735051195514880

BEFORE:
<img width="1059" alt="Before"
src="https://github.com/user-attachments/assets/a84bffe4-4a96-4175-897f-68be33778653"
/>

AFTER:
It's a little hard to test (especially when currently you can't get in
the old build menu and the new radial menu doesn't let you nuke
yourself). But the code speaks for itself i hope.

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

tryout33
El-Magico777 pushed a commit to El-Magico777/OpenFrontIO-Magico that referenced this pull request Jun 28, 2025
In edge cases, where all land is fallout, Owned % could be NaN%. Have it
converted to 0% in such cases.

https://discord.com/channels/1359946986937258015/1383735051195514880

BEFORE:
<img width="1059" alt="Before"
src="https://github.com/user-attachments/assets/a84bffe4-4a96-4175-897f-68be33778653"
/>

AFTER:
It's a little hard to test (especially when currently you can't get in
the old build menu and the new radial menu doesn't let you nuke
yourself). But the code speaks for itself i hope.

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors
regression is found:

tryout33
@coderabbitai coderabbitai Bot mentioned this pull request Jul 31, 2025
5 tasks done
@coderabbitai coderabbitai Bot mentioned this pull request Jan 10, 2026
4 tasks done

This branch was previously deployed

1 inactive deployment
staging — c2e1be42 Deployed Jun 16, 2025 by openfrontio[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

2 participants