Repository navigation
Fix modal not closing when game starts - #1504
Conversation
WalkthroughThis change updates the client-side logic to close three additional modal dialogs—territory patterns, language, and news—when a user joins a lobby. These modal elements are now included in the list of UI components that are hidden or closed at the start of a game session. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant UI
participant Lobby
User->>Lobby: Join lobby
Lobby-->>UI: Callback to start game
UI->>UI: Close all open modals (including new ones)
UI->>UI: Hide ads
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (2)📓 Common learningssrc/client/Main.ts (1)⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
Description:
When a player joins a public game and opens a modal (such as the news modal) while waiting for the game to start, the modal is not dismissed when the game begins. This leaves the modal visible even after the match has started.
This PR fixes the bug described above.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
aotumuri