Skip to content

Remove Yenisei from public multiplayer games - #1874

Merged
evanpelle merged 1 commit into
v25from
evan-remove-yenis
Aug 20, 2025
Merged

evanpelle merged 1 commit into
v25from
evan-remove-yenis

Conversation

@evanpelle

@evanpelle evanpelle commented Aug 20, 2025 •

Copy link
Copy Markdown
Collaborator

Description:

The map is very large and the game lagged a lot on this map during playtests. So remove it from public lobbies.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

evan

@coderabbitai

coderabbitai Bot commented Aug 20, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

The change removes the "Yenisei" entry from the map frequency mapping in src/server/MapPlaylist.ts. Because the generator uses (frequency[key] ?? 0), Yenisei now yields zero instances and is excluded from generated playlists. No other logic or files are changed.

Changes

Cohort / File(s) Summary
Map playlist frequency update
src/server/MapPlaylist.ts
Deleted Yenisei: 1 from the frequency map; playlist construction remains the same, so Yenisei is no longer included.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~3 minutes

Possibly related PRs

Suggested labels

Feature - Map, Feature - Backend

Suggested reviewers

  • drillskibo
  • scottanderson

Poem

Maps march on in tidy lines,
Yenisei bows, withdraws in time.
The playlist hums a simpler tune,
One less river, same bright moon.
Shuffle dealt, the deck now neat—
Clean TypeScript keeps the beat.


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

💡 Knowledge Base configuration:

  • MCP integration is disabled by default for public repositories
  • Jira integration is disabled by default for public repositories
  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 3e880a3 and 9ab0e65.

📒 Files selected for processing (1)
  • src/server/MapPlaylist.ts (0 hunks)
💤 Files with no reviewable changes (1)
  • src/server/MapPlaylist.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share
🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

CodeRabbit Commands (Invoked using PR/Issue comments)

Type @coderabbitai help to get the list of available commands.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Status, Documentation and Community

  • Visit our Status Page to check the current availability of CodeRabbit.
  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@evanpelle
evanpelle changed the base branch from main to v25 August 20, 2025 02:03
@evanpelle evanpelle changed the title Evan remove yenis Remove Yenisei from public multiplayer games Aug 20, 2025
@evanpelle evanpelle added this to the v25 milestone Aug 20, 2025
@evanpelle
evanpelle marked this pull request as ready for review August 20, 2025 02:06
@evanpelle
evanpelle requested a review from a team as a code owner August 20, 2025 02:06
@evanpelle evanpelle closed this Aug 20, 2025
@evanpelle evanpelle reopened this Aug 20, 2025
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Aug 20, 2025
@github-project-automation github-project-automation Bot moved this from Complete to Triage in OpenFront Release Management Aug 20, 2025
@evanpelle
evanpelle merged commit 4ba9b3b into v25 Aug 20, 2025
@evanpelle
evanpelle deleted the evan-remove-yenis branch August 20, 2025 02:11
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Aug 20, 2025
scottanderson pushed a commit that referenced this pull request Aug 24, 2025
The map is very large and the game lagged a lot on this map during
playtests. So remove it from public lobbies.

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

regression is found:

evan
TheGiraffe3 pushed a commit that referenced this pull request Sep 4, 2025
The map is very large and the game lagged a lot on this map during
playtests. So remove it from public lobbies.

- [x] I have added screenshots for all UI updates
- [x] I process any text displayed to the user through translateText()
and I've added it to the en.json file
- [x] I have added relevant tests to the test directory
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced

regression is found:

evan

This branch had an error being deployed

1 failed deployment
staging — 9ab0e65f Deployed Aug 20, 2025 by openfrontio[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

1 participant