Repository navigation
Add Nuke Wars Baikal Map - #2306
Conversation
|
|
WalkthroughA new map "Baikal (Nuke Wars)" is registered: static asset and manifest files were added, and corresponding entries were added to map generation, localization, client descriptions, configuration, and core game enums/categories. Changes
Sequence Diagram(s)sequenceDiagram
autonumber
participant Assets as Map Assets (`info.json`, `manifest.json`)
participant Generator as Map Generator (`map-generator/main.go`)
participant Core as Game Core (`Game.ts`, `DefaultConfig.ts`)
participant Client as Client UI (`Maps.ts`, `en.json`)
Note over Assets,Generator: New asset + manifest added
Assets->>Generator: Registered map key `baikalnukewars`
Generator->>Core: Map key included in generation/output
Core->>Client: GameMapType & config propagated
Client->>Client: MapDescription + localization updated
Note right of Client: UI can display new map name
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🚧 Files skipped from review as they are similar to previous changes (1)
🔇 Additional comments (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
⛔ Files ignored due to path filters (4)
map-generator/assets/maps/baikalnukewars/image.pngis excluded by!**/*.pngresources/maps/baikalnukewars/map.binis excluded by!**/*.binresources/maps/baikalnukewars/map16x.binis excluded by!**/*.binresources/maps/baikalnukewars/map4x.binis excluded by!**/*.bin
📒 Files selected for processing (7)
map-generator/assets/maps/baikalnukewars/info.json(1 hunks)map-generator/main.go(1 hunks)resources/lang/en.json(1 hunks)resources/maps/baikalnukewars/manifest.json(1 hunks)src/client/components/Maps.ts(1 hunks)src/core/configuration/DefaultConfig.ts(1 hunks)src/core/game/Game.ts(2 hunks)
🔇 Additional comments (7)
src/client/components/Maps.ts (1)
40-40: LGTM! Map description entry added correctly.The new
BaikalNukeWarsentry follows the existing pattern and maintains alphabetical ordering.src/core/game/Game.ts (1)
99-99: Enum member added correctly.The new
BaikalNukeWarsenum member follows the existing pattern and maintains alphabetical ordering.src/core/configuration/DefaultConfig.ts (1)
53-53: LGTM! Player configuration added correctly.The new configuration entry mirrors the original Baikal map with
[100, 70, 50]player counts, which is appropriate if the map dimensions are similar. The alphabetical ordering is maintained.map-generator/main.go (1)
21-21: LGTM! Map generator entry added correctly.The new entry follows the existing pattern and maintains alphabetical ordering. This will enable the map generation pipeline to process the Baikal Nuke Wars map assets.
map-generator/assets/maps/baikalnukewars/info.json (1)
2-2: Name field matches internal name convention.The
"name": "Baikal"field here matches the manifest and likely represents the internal/base map name, while"Baikal (Nuke Wars)"is the user-facing display name. This is consistent with how the system separates internal identifiers from localized display strings.resources/lang/en.json (1)
197-198: LGTM! Translation entry added correctly.The new translation key follows the naming convention (lowercase, no spaces) and the display value
"Baikal (Nuke Wars)"is consistent with the TypeScript enum and client descriptions. The alphabetical ordering is maintained.resources/maps/baikalnukewars/manifest.json (1)
17-17: Update the manifest name field to distinguish the map variant.The verification confirms both maps use
"name": "Baikal". While maps are indexed by directory path, having identical names for different map variants risks confusion in UI display, logs, or user-facing content. The codebase shows this pattern elsewhere (two "Europe" variants also share a name).Update
resources/maps/baikalnukewars/manifest.jsonto use"name": "Baikal (Nuke Wars)"to match how the map is displayed throughout the codebase and ensure each map variant has a unique, descriptive identifier.
|
I think it would be better to have Nuke Wars turn off nations, as opposed to creating a whole new map for it. The only difference I see from the normal Baikal map is the lack of nations. |
Have you taken a look at the map? This totally rebalances it so both sides and far more equal in tile numbers 😅. The lack of nations is just one of many things |
|
Oh yeah, I see now. I hadn't made a comparison before, just skimmed it over. It's been too long since I played the Baikal map, apparently. |
Description:
This PR adds the Nuke Wars Baikal map (more balanced out than the original). This is made for the upcoming Nuke Wars gamemode.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
DISCORD_USERNAME
Nikola123