Repository navigation
fix host can't kick players - #2332
abdallahbahrawi1 wants to merge 1 commit into
Conversation
WalkthroughThe remove-player button in the lobby UI now passes its click event to the Changes
Sequence Diagram(s)sequenceDiagram
participant Button as Remove-Player<br/>Button
participant Handler as kickPlayer<br/>Handler
participant Doc as document
rect rgb(200, 220, 255)
Note over Button,Doc: New Event Flow
Button->>Handler: click event
Handler->>Handler: stopPropagation()
Handler->>Doc: dispatch kick-player<br/>on document
end
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks❌ Failed checks (1 warning)
✅ Passed checks (2 passed)
📜 Recent review detailsConfiguration used: CodeRabbit UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (1)
🧰 Additional context used🧠 Learnings (1)📚 Learning: 2025-06-09T02:20:43.637ZApplied to files:
🔇 Additional comments (2)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
DevelopingTom
left a comment
There was a problem hiding this comment.
Thanks for the fix, but I could not ensure it is fixing the bug: while I can see the bug on openfront.io, it doesn't appear locally. Did you try it, and can you reproduce locally?
Yes i was able to see the issue, but I tested it now and it works fine ! |
|
main still has the issue when deployed, maybe something to do with ad layers? |
Description:
Fixes an issue where the host’s “Kick” button didn’t work.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
abodcraft1