Repository navigation
Update copyright notice & footer - #2496
Conversation
WalkthroughThe footer UI is refactored from a dedicated CSS layout to an inline flex-based structure in HTML. Unused translation keys are removed, and copyright attributions are updated across the application to credit contributors. The modal copyright text is made smaller and updated accordingly. Changes
Sequence DiagramThis change consists primarily of UI restructuring and translation updates without introducing new control flow patterns, so no sequence diagram is needed. Estimated code review effort🎯 3 (Moderate) | ⏱️ ~20 minutes Areas requiring extra attention:
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Pre-merge checks✅ Passed checks (3 passed)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ecf03b4 to
737b11d
Compare
There was a problem hiding this comment.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/client/GameStartingModal.ts (1)
121-121: Inconsistent copyright text with footer.The copyright in index.html (line 358) includes the trademark symbol: "© OpenFront™ and Contributors", but this modal omits it. Consider aligning both for consistency.
Apply this diff to match the footer:
- <div class="copyright">© OpenFront and Contributors</div> + <div class="copyright">© OpenFront™ and Contributors</div>
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (5)
resources/lang/en.json(1 hunks)src/client/GameStartingModal.ts(2 hunks)src/client/index.html(2 hunks)src/client/styles.css(0 hunks)src/client/styles/layout/footer.css(0 hunks)
💤 Files with no reviewable changes (2)
- src/client/styles.css
- src/client/styles/layout/footer.css
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-16T10:52:08.292Z
Learnt from: TheGiraffe3
Repo: openfrontio/OpenFrontIO PR: 884
File: resources/lang/en.json:456-461
Timestamp: 2025-08-16T10:52:08.292Z
Learning: In OpenFrontIO, translation files in resources/lang/*.json (except en.json) should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files. Regular PRs should only update en.json when adding or modifying translation keys.
Applied to files:
resources/lang/en.json
📚 Learning: 2025-05-30T03:53:52.231Z
Learnt from: scottanderson
Repo: openfrontio/OpenFrontIO PR: 949
File: resources/lang/en.json:8-10
Timestamp: 2025-05-30T03:53:52.231Z
Learning: For the OpenFrontIO project, do not suggest updating translation files in resources/lang/*.json except for en.json. The project has a dedicated translation team that handles all other locale files.
Applied to files:
resources/lang/en.json
📚 Learning: 2025-06-02T14:27:37.609Z
Learnt from: andrewNiziolek
Repo: openfrontio/OpenFrontIO PR: 1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.
Applied to files:
resources/lang/en.json
📚 Learning: 2025-06-09T02:20:43.637Z
Learnt from: VariableVince
Repo: openfrontio/OpenFrontIO PR: 1110
File: src/client/Main.ts:293-295
Timestamp: 2025-06-09T02:20:43.637Z
Learning: In src/client/Main.ts, during game start in the handleJoinLobby callback, UI elements are hidden using direct DOM manipulation with classList.add("hidden") for consistency. This includes modals, buttons, and error divs. The codebase follows this pattern rather than using component APIs for hiding elements during game transitions.
Applied to files:
src/client/GameStartingModal.ts
🔇 Additional comments (7)
src/client/GameStartingModal.ts (1)
96-96: Font size reduction looks good.The copyright text is now more subtle in the modal, which is appropriate for secondary information.
resources/lang/en.json (2)
24-24: Simplified Discord label is cleaner.The shorter text works better for the footer layout and is more concise.
1-802: Removed translation keys verified clean.The removed keys
main.how_to_playandmain.advertisehave no references anywhere in the codebase (TypeScript, JavaScript, or HTML files). The removal is safe and complete.src/client/index.html (4)
320-325: Responsive footer structure looks good.The flex-based layout with breakpoints provides a clean, mobile-friendly footer that adapts well across screen sizes.
326-351: Link section styling is consistent and accessible.The responsive alignment and consistent hover effects provide good UX. The translation key usage aligns with the updated en.json.
352-367: Copyright section is well-structured.The centered layout with GitHub icon provides clear attribution. Note: This uses "© OpenFront™ and Contributors" while GameStartingModal.ts omits the ™ symbol (flagged separately).
368-387: Legal links section completes the responsive footer.The right-aligned section on desktop balances the layout nicely, while centering on mobile maintains readability.
Description:
Update copyright notice to "OpenFront and Contributors"
remove the "how to play" on the footer, since that will be moved to the death screen.
Removed css and used tailwind instead for better mobile support
Describe the PR.
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
evan