Skip to content

Update copyright notice & footer - #2496

Merged
evanpelle merged 1 commit into
v27from
evan-update-footer
Nov 22, 2025
Merged

evanpelle merged 1 commit into
v27from
evan-update-footer

Conversation

@evanpelle

@evanpelle evanpelle commented Nov 22, 2025 •

Copy link
Copy Markdown
Collaborator

Description:

  • Update copyright notice to "OpenFront and Contributors"

  • remove the "how to play" on the footer, since that will be moved to the death screen.

  • Removed css and used tailwind instead for better mobile support

Describe the PR.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

evan

@evanpelle
evanpelle requested review from a team as code owners November 22, 2025 04:11
@CLAassistant

CLAassistant commented Nov 22, 2025 •

Copy link
Copy Markdown

CLA assistant check
All committers have signed the CLA.

@coderabbitai

coderabbitai Bot commented Nov 22, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

The footer UI is refactored from a dedicated CSS layout to an inline flex-based structure in HTML. Unused translation keys are removed, and copyright attributions are updated across the application to credit contributors. The modal copyright text is made smaller and updated accordingly.

Changes

Cohort / File(s) Summary
Translation updates
resources/lang/en.json
Removed main.how_to_play and main.advertise entries; shortened main.join_discord from "Join the Discord!" to "Discord"
Modal styling and attribution
src/client/GameStartingModal.ts
Reduced copyright text size from 32px to 20px; updated copyright text to include "and Contributors"
Footer HTML restructuring
src/client/index.html
Reworked footer from nested static structure to responsive flex-based layout; removed "How to Play" link; added Privacy Policy and Terms of Service section; updated GitHub credit text to include contributors
CSS consolidation
src/client/styles.css, src/client/styles/layout/footer.css
Removed import of footer.css; deleted entire footer.css file containing .l-footer, .l-footer__content, and .l-footer__col definitions

Sequence Diagram

This change consists primarily of UI restructuring and translation updates without introducing new control flow patterns, so no sequence diagram is needed.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Areas requiring extra attention:

  • Verify the new footer layout is responsive and aligns correctly across all breakpoints (small, medium, large screens)
  • Confirm all footer links (Wiki, Reddit, Privacy Policy, Terms of Service) remain functional and point to correct destinations
  • Check that the updated copyright attribution displays properly in both GameStartingModal and footer
  • Ensure removal of "how_to_play" and "advertise" translation keys doesn't break any other parts of the application that might reference them

Possibly related PRs

Suggested labels

UI/UX, Translation, Feature - Frontend

Suggested reviewers

  • scottanderson
  • drillskibo

Poem

🎨 The footer finds flex,
Old CSS bids adieu,
Contributors shine bright,
Credits made anew,
Layout flows just right! 🚀

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely summarizes the main changes: updating the copyright notice and restructuring the footer.
Description check ✅ Passed The description is directly related to the changeset, explaining the copyright update, footer restructuring, and CSS-to-Tailwind migration.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@evanpelle
evanpelle changed the base branch from main to v27 November 22, 2025 04:14
@evanpelle evanpelle added this to the v27 milestone Nov 22, 2025
@evanpelle
evanpelle merged commit 0b651b6 into v27 Nov 22, 2025
1 check was pending
@evanpelle
evanpelle deleted the evan-update-footer branch November 22, 2025 04:22

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
src/client/GameStartingModal.ts (1)

121-121: Inconsistent copyright text with footer.

The copyright in index.html (line 358) includes the trademark symbol: "© OpenFront™ and Contributors", but this modal omits it. Consider aligning both for consistency.

Apply this diff to match the footer:

-        <div class="copyright">© OpenFront and Contributors</div>
+        <div class="copyright">© OpenFront™ and Contributors</div>
📜 Review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 92372b7 and 737b11d.

📒 Files selected for processing (5)
  • resources/lang/en.json (1 hunks)
  • src/client/GameStartingModal.ts (2 hunks)
  • src/client/index.html (2 hunks)
  • src/client/styles.css (0 hunks)
  • src/client/styles/layout/footer.css (0 hunks)
💤 Files with no reviewable changes (2)
  • src/client/styles.css
  • src/client/styles/layout/footer.css
🧰 Additional context used
🧠 Learnings (4)
📚 Learning: 2025-08-16T10:52:08.292Z
Learnt from: TheGiraffe3
Repo: openfrontio/OpenFrontIO PR: 884
File: resources/lang/en.json:456-461
Timestamp: 2025-08-16T10:52:08.292Z
Learning: In OpenFrontIO, translation files in resources/lang/*.json (except en.json) should not be updated in regular PRs. Only dedicated translation PRs titled "mls" and made by Aotumori should update non-English locale files. Regular PRs should only update en.json when adding or modifying translation keys.

Applied to files:

  • resources/lang/en.json
📚 Learning: 2025-05-30T03:53:52.231Z
Learnt from: scottanderson
Repo: openfrontio/OpenFrontIO PR: 949
File: resources/lang/en.json:8-10
Timestamp: 2025-05-30T03:53:52.231Z
Learning: For the OpenFrontIO project, do not suggest updating translation files in resources/lang/*.json except for en.json. The project has a dedicated translation team that handles all other locale files.

Applied to files:

  • resources/lang/en.json
📚 Learning: 2025-06-02T14:27:37.609Z
Learnt from: andrewNiziolek
Repo: openfrontio/OpenFrontIO PR: 1007
File: resources/lang/de.json:115-115
Timestamp: 2025-06-02T14:27:37.609Z
Learning: For OpenFrontIO project: When localization keys are renamed in language JSON files, the maintainers separate technical changes from translation content updates. They wait for community translators to update the actual translation values rather than attempting to translate in the same PR. This allows technical changes to proceed while ensuring accurate translations from native speakers.

Applied to files:

  • resources/lang/en.json
📚 Learning: 2025-06-09T02:20:43.637Z
Learnt from: VariableVince
Repo: openfrontio/OpenFrontIO PR: 1110
File: src/client/Main.ts:293-295
Timestamp: 2025-06-09T02:20:43.637Z
Learning: In src/client/Main.ts, during game start in the handleJoinLobby callback, UI elements are hidden using direct DOM manipulation with classList.add("hidden") for consistency. This includes modals, buttons, and error divs. The codebase follows this pattern rather than using component APIs for hiding elements during game transitions.

Applied to files:

  • src/client/GameStartingModal.ts
🔇 Additional comments (7)
src/client/GameStartingModal.ts (1)

96-96: Font size reduction looks good.

The copyright text is now more subtle in the modal, which is appropriate for secondary information.

resources/lang/en.json (2)

24-24: Simplified Discord label is cleaner.

The shorter text works better for the footer layout and is more concise.


1-802: Removed translation keys verified clean.

The removed keys main.how_to_play and main.advertise have no references anywhere in the codebase (TypeScript, JavaScript, or HTML files). The removal is safe and complete.

src/client/index.html (4)

320-325: Responsive footer structure looks good.

The flex-based layout with breakpoints provides a clean, mobile-friendly footer that adapts well across screen sizes.


326-351: Link section styling is consistent and accessible.

The responsive alignment and consistent hover effects provide good UX. The translation key usage aligns with the updated en.json.


352-367: Copyright section is well-structured.

The centered layout with GitHub icon provides clear attribution. Note: This uses "© OpenFront™ and Contributors" while GameStartingModal.ts omits the ™ symbol (flagged separately).


368-387: Legal links section completes the responsive footer.

The right-aligned section on desktop balances the layout nicely, while centering on mobile maintains readability.

This branch was previously deployed

1 inactive deployment
staging — 737b11dc Deployed Nov 22, 2025 by openfrontio[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants