Skip to content

Add Svalmel - #2600

Merged
evanpelle merged 2 commits into
openfrontio:mainfrom
Duwibi:ChristmasMap
Dec 11, 2025
Merged

evanpelle merged 2 commits into
openfrontio:mainfrom
Duwibi:ChristmasMap

Conversation

@Duwibi

@Duwibi Duwibi commented Dec 11, 2025 •

Copy link
Copy Markdown
Contributor

Description:

This PR adds the Christmas map Svalmel with 5 nations.

Describe the PR.

Please complete the following:

  • I have added screenshots for all UI updates
  • I process any text displayed to the user through translateText() and I've added it to the en.json file
  • I have added relevant tests to the test directory
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced

Please put your Discord username so you can be contacted if a bug or regression is found:

DISCORD_USERNAME
Nikola123

@Duwibi
Duwibi requested a review from a team as a code owner December 11, 2025 21:45
@CLAassistant

Copy link
Copy Markdown

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@coderabbitai

coderabbitai Bot commented Dec 11, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

This PR adds a new map named "Svalmel" to the game by registering it across asset definitions, configuration files, localization, and gameplay systems. The map includes nation placements with specified coordinates, flag identifiers, and strength values. No new functionality or control-flow logic is introduced.

Changes

Cohort / File(s) Summary
Map Assets & Manifests
map-generator/assets/maps/svalmel/info.json, resources/maps/svalmel/manifest.json
New Svalmel map metadata with dimensions (1700×1580), land tile counts across scale variants (1011623, 248068, 59685), and five nation placements with coordinates, flags (santa_claus, no, ca), and strength values
Map Registration
map-generator/main.go
Added "svalmel" entry to the maps list
Localization
resources/lang/en.json
Added "svalmel": "Svalmel" translation key to the map section
Game Configuration & Type Definitions
src/client/components/Maps.ts, src/core/game/Game.ts, src/core/configuration/DefaultConfig.ts
Added Svalmel to MapDescription export constant, added GameMapType.Svalmel enum member, included it in mapCategories.fantasy array, and added numPlayersConfig entry with player counts [40, 36, 30]
Gameplay Settings
src/server/MapPlaylist.ts
Added Svalmel: 8 entry to map frequency configuration

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~5 minutes

This is a straightforward, repetitive addition following an established map-registration pattern. All changes are simple data insertions with no logic modifications, consistent across all affected files.

Possibly related PRs

  • Add Achiran #2280 — Adds a new map using the same registration pattern across map-generator, GameMapType enum, DefaultConfig, MapDescription, and MapPlaylist
  • Add New York City Map #2542 — Adds another new map with parallel code changes to GameMapType, numPlayersConfig, MapDescription, and map frequency mappings
  • Add a new Mars (Revised) map #1435 — Implements the same map-addition pattern with enum member, configuration entry, and playlist frequency updates

Suggested labels

Feature - Map

Suggested reviewers

  • evanpelle
  • TheGiraffe3

Poem

🗺️ Svalmel joins the fold today,
Five nations find their Arctic way,
From Santa's halls to Svalbard's snow,
The map grows rich, the options flow! ❄️

Pre-merge checks

✅ Passed checks (3 passed)
Check name Status Explanation
Title check ✅ Passed The title 'Add Svalmel' clearly and concisely summarizes the main change: introducing a new Christmas map called Svalmel.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Description check ✅ Passed The pull request description clearly describes adding the Christmas map 'Svalmel' with 5 nations, which aligns with the changeset that adds map configuration files, translations, and game type entries.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@Duwibi Duwibi added the Maps A new map, or adjustments to an existing map itself, its json, etc, label Dec 11, 2025
@Duwibi Duwibi modified the milestones: v27, v28 Dec 11, 2025

@evanpelle evanpelle left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@evanpelle
evanpelle added this pull request to the merge queue Dec 11, 2025
Merged via the queue into openfrontio:main with commit 1f8adb4 Dec 11, 2025
13 of 21 checks passed
@coderabbitai coderabbitai Bot mentioned this pull request Dec 24, 2025
4 tasks done
@coderabbitai coderabbitai Bot mentioned this pull request Jan 2, 2026
4 tasks done
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Maps A new map, or adjustments to an existing map itself, its json, etc,

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants