Repository navigation
Some little HumansVsNations improvements before public games launch 🤖 - #2825
Conversation
WalkthroughThe PR refactors nation name generation to prevent duplicate names using a tracking set and introduces helper functions. It also adjusts the difficulty mapping for HumansVsNations team mode from Hard to Impossible in map configurations. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~12 minutes Possibly related PRs
Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 1 | ❌ 2❌ Failed checks (1 warning, 1 inconclusive)
✅ Passed checks (1 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. 📜 Recent review detailsConfiguration used: Organization UI Review profile: CHILL Plan: Pro 📒 Files selected for processing (2)
🧰 Additional context used🧠 Learnings (4)📓 Common learnings📚 Learning: 2025-10-21T20:06:04.823ZApplied to files:
📚 Learning: 2025-10-20T20:15:28.858ZApplied to files:
📚 Learning: 2025-12-26T22:21:21.904ZApplied to files:
🧬 Code graph analysis (2)src/server/MapPlaylist.ts (2)
src/core/game/NationCreation.ts (1)
🔇 Additional comments (4)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Description:
generateUniqueNationName()toNationCreationbecause I saw a duplicate name while spawning 300 nations on Pangaea 😄Maybe I have to make nations donate troops to each other, we will see... Playtests won't tell the truth because the players attending these are probably better than the usual OF player. I will try to check the HVN winrate via API after launch
Please complete the following:
Please put your Discord username so you can be contacted if a bug or regression is found:
FloPinguin