Skip to content

Enlarge the teammate spawn glow - #6280

Merged
evanpelle merged 1 commit into
mainfrom
increase-teammate-glow
Nov 5, 2026
Merged

evanpelle merged 1 commit into
mainfrom
increase-teammate-glow

Conversation

@evanpelle

Copy link
Copy Markdown
Collaborator

Summary

  • Raise the teammate spawn ring's outer radius (spawnOverlay.mateMaxRad) from 14 to 18, about 30% larger, so teammates stand out more during the spawn phase of team games.
  • The inner radius (mateMinRad) stays at 5, so the ring spreads outward. Opacity and the self ring are unchanged.
  • SpawnOverlayPass sizes the instance quad from mateMaxRad, so the larger ring isn't clipped.

Test plan

  • Settings-only JSON change; no tests run locally. 18 sits on the debug slider's 0.5 step grid (range 5–30).

🤖 Generated with Claude Code

Raise mateMaxRad from 14 to 18 (~30%) so teammates' breathing spawn
rings read more clearly in team games. The inner radius stays at 5.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Nov 4, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The spawnOverlay.mateMaxRad setting changes from 14 to 18.

Changes

Spawn overlay

Layer / File(s) Summary
Update teammate radius
src/client/render/gl/render-settings.json
The maximum teammate radius setting changes from 14 to 18.

Estimated code review effort: 1 (Trivial) | ~2 minutes

Change: Feature

Possibly related PRs

  • openfrontio/OpenFrontIO#2768: Adds a teammate spawn pulse with a 5–14 radius; this change increases the same overlay’s maximum radius.

Suggested reviewers: jrouillard

Merge Risk: Minimal · up to 96fc2

No actionable code risk is identified in the teammate glow adjustment. Assign the required PR milestone before merging.

Pre-merge checks: Passed 5
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: increasing the teammate spawn glow size.
Description check Passed The description directly explains the radius change, its visual purpose, unchanged settings, and test plan.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

A ring grows wider by four,
The setting marks its new boundary.
Teammates gather in the glow,
The overlay reaches farther,
One small change completes the show.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: ad1d017b-d851-44d1-bf20-2965f9870c99
Commits

Reviewing files that changed from the base of the PR and between c3c7155 and 96fc230.

Files selected for processing: 1
  • src/client/render/gl/render-settings.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 4 remain after this review.

@evanpelle evanpelle added this to the v36 milestone Nov 5, 2026
@evanpelle
evanpelle merged commit c8e909d into main Nov 5, 2026
20 of 21 checks passed
@evanpelle
evanpelle deleted the increase-teammate-glow branch November 5, 2026 00:25
@github-project-automation github-project-automation Bot moved this from Triage to Complete in OpenFront Release Management Nov 5, 2026
This was referenced Nov 5, 2026

This branch was successfully deployed

1 active and 1 inactive deployments
backport — 96fc2300 Deployed Nov 5, 2026 by evanpelle via Cherry-pick #847
staging — 96fc2300 Deployed Nov 5, 2026 by openfrontio[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

1 participant