Skip to content

mls - #888

Merged
evanpelle merged 4 commits into
openfrontio:mainfrom
Aotumuri:mls-3-2
May 27, 2025
Merged

mls#888
evanpelle merged 4 commits into
openfrontio:mainfrom
Aotumuri:mls-3-2

Conversation

@Aotumuri

Copy link
Copy Markdown
Member

Description:

mls for v23
Version identifier within MLS: v3.2

Please complete the following:

  • I have added screenshots for all UI updates
  • I confirm I have thoroughly tested these changes and take full responsibility for any bugs introduced
  • I understand that submitting code with bugs that could have been caught through manual testing blocks releases and new features for all contributors

Please put your Discord username so you can be contacted if a bug or regression is found:

aotumuri

@coderabbitai

coderabbitai Bot commented May 26, 2025 •

Copy link
Copy Markdown
Contributor

Walkthrough

This update adds new and expanded translations for the game's user interface across multiple languages, including Czech and Hebrew. It introduces detailed descriptions for new UI features such as the build menu, player info overlay, event panel, and trade controls. The language selector is updated to support Czech and Hebrew.

Changes

Files / Grouped Files Change Summary
resources/lang/bg.json, es.json, fr.json, it.json, ja.json, nl.json, ru.json, uk.json, eo.json Expanded and refined translations; added new UI sections (build menu, win modal, leaderboard, player overlay, etc.), improved clarity, added new map location, icons, and user settings.
resources/lang/cs.json, he.json Added new Czech and Hebrew translation files with full UI/gameplay text coverage.
src/client/LangSelector.ts Added Czech and Hebrew to language imports and language selection map.

Sequence Diagram(s)

sequenceDiagram
    participant User
    participant UI
    participant LangSelector
    participant LanguageFiles

    User->>UI: Selects language (e.g., Czech or Hebrew)
    UI->>LangSelector: Request language data
    LangSelector->>LanguageFiles: Import selected language JSON
    LanguageFiles-->>LangSelector: Return translation strings
    LangSelector-->>UI: Provide translations
    UI-->>User: Display UI in selected language
Loading

Possibly related PRs

  • openfrontio/OpenFrontIO#785: Updates localization strings for build menu, player panel, event panel, and player info overlay with detailed gameplay mechanic descriptions.

Suggested reviewers

  • Aotumuri

Poem

New words for every tongue,
Czech and Hebrew join the song!
Menus, panels, overlays bright,
All translated just right.
Now every player, far and near,
Sees the world in their language clear.
🌍✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between a848592 and 67a5274.

📒 Files selected for processing (1)
  • resources/lang/tr.json (1 hunks)
✅ Files skipped from review due to trivial changes (1)
  • resources/lang/tr.json

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Explain this complex logic.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai explain this code block.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and explain its main purpose.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Support

Need help? Create a ticket on our support page for assistance with any issues or questions.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate sequence diagram to generate a sequence diagram of the changes in this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 3

♻️ Duplicate comments (77)
resources/lang/bg.json (20)

36-36: Duplicate: UI Leaderboard Description: Matches the Russian ui_leaderboard_desc entry. Bulgarian translation is consistent.


39-40: Duplicate: Population & Gold Descriptions: The ui_pop and ui_gold entries mirror the logic and formatting of the Russian file.


43-47: Duplicate: Events Panel Translations: The ui_events–ui_events_quickchat strings match the previously approved pattern.


50-51: Duplicate: Player Overlay in Help: The ui_playeroverlay entries align with the Russian file.


55-57: Duplicate: Settings & Radial Menu Labels: The option_settings and radial_desc translations remain accurate.


60-60: Duplicate: Radial Boat Entry: The radial_boat key is translated consistently.


63-63: Duplicate: Enemy Info Description: The info_enemy_desc string matches the style of the Russian file.


68-68: Duplicate: Trade Suspension Text: The info_trade translation is correct.


71-73: Duplicate: Betrayal & Gold Donation: The ally_betray and ally_donate_gold entries follow the approved pattern.


75-75: Duplicate: Help Modal Build Menu: The build_menu_desc and related build entries are translated as per the Russian reference.

Also applies to: 82-82, 84-84, 86-86, 90-90


99-103: Duplicate: Player Icon Labels: The new icon descriptions (icon_crown, icon_traitor, icon_embargo, icon_request) align with the pattern.


145-146: Duplicate: Map Entries: The baikal and halkidiki entries match other language files.


230-231: Duplicate: Special Effects Settings: The special effects toggle matches the Russian translation.


339-352: Duplicate: Top-Level Build Menu Section: The new build_menu section entries are consistent.


353-361: Duplicate: Win Modal Section: Matches the Russian win_modal implementation.


362-370: Duplicate: Leaderboard UI Section: Consistent with the Russian file.


371-387: Duplicate: Player Info Overlay Section: All new keys match the Russian list.


388-394: Duplicate: Relation States Section: Translations align with the Russian semantics.


395-401: Duplicate: Control Panel Labels: The control entries remain consistent.


402-413: Duplicate: Player Panel Controls: The player panel strings match the approved Russian entries.

resources/lang/eo.json (19)

36-36: Duplicate: UI Leaderboard Description: Matches the Russian update for ui_leaderboard_desc. Esperanto translation is consistent.


43-47: Duplicate: Events Panel Strings: The ui_events–ui_events_quickchat entries follow the approved pattern.


50-51: Duplicate: Player Overlay in Help: The Esperanto ui_playeroverlay entries match expectations.


55-57: Duplicate: Settings & Radial Menu Labels: The option_settings and radial_desc translations align with the reference.


60-60: Duplicate: Radial Boat Entry: The radial_boat key matches other languages.


63-63: Duplicate: Enemy Info Description: The info_enemy_desc mapping is consistent.


68-68: Duplicate: Trade Suspension Text: The info_trade translation is correct.


71-73: Duplicate: Betrayal & Gold Donation: The ally_betray and ally_donate_gold entries mirror the approved style.


75-75: Duplicate: Help Modal Build Menu: The build menu descriptions follow the reference.

Also applies to: 82-82, 84-84, 86-86, 90-90


99-103: Duplicate: Player Icon Labels: The new icon entries are translated consistently.


145-146: Duplicate: Map Entries: baikal and halkidiki match other localizations.


230-231: Duplicate: Special Effects Settings: Matches the approved translation.


339-352: Duplicate: Top-Level Build Menu Section: The new build_menu entries align with the pattern.


353-361: Duplicate: Win Modal Section: Consistent with the reference.


362-370: Duplicate: Leaderboard UI Section: Matches the approved entries.


371-387: Duplicate: Player Info Overlay Section: All keys mirror the Russian file.


388-394: Duplicate: Relation States Section: Consistent translation.


395-401: Duplicate: Control Panel Labels: Matches the reference.


402-413: Duplicate: Player Panel Controls: Follows the approved pattern.

resources/lang/nl.json (19)

36-36: Duplicate: UI Leaderboard Description: Matches the Russian ui_leaderboard_desc. Dutch translation is accurate.


43-47: Duplicate: Events Panel Strings: The ui_events–ui_events_quickchat entries follow the established pattern.


50-51: Duplicate: Player Overlay in Help: The Dutch ui_playeroverlay entries are consistent.


55-57: Duplicate: Settings & Radial Menu Labels: The option_settings and radial_desc translations align correctly.


60-60: Duplicate: Radial Boat Entry: The radial_boat label is properly translated.


63-63: Duplicate: Enemy Info Description: The info_enemy_desc mapping is consistent.


68-68: Duplicate: Trade Suspension Text: The info_trade entry is correct.


71-73: Duplicate: Betrayal & Gold Donation: The ally_betray and ally_donate_gold segments match the reference.


75-75: Duplicate: Help Modal Build Menu: Build menu descriptions follow the approved pattern.

Also applies to: 82-82, 84-84, 86-86, 90-90


99-103: Duplicate: Player Icon Labels: The new icon entries align with other localizations.


145-146: Duplicate: Map Entries: baikal and halkidiki match other language files.


230-231: Duplicate: Special Effects Settings: Matches the approved translation.


339-352: Duplicate: Top-Level Build Menu Section: The build_menu section entries are consistent.


353-361: Duplicate: Win Modal Section: Consistent with the reference.


362-370: Duplicate: Leaderboard UI Section: Matches the pattern.


371-387: Duplicate: Player Info Overlay Section: All keys mirror the Russian update.


388-394: Duplicate: Relation States Section: Correct translation.


395-401: Duplicate: Control Panel Labels: Matches the reference.


402-413: Duplicate: Player Panel Controls: Follows the approved pattern.

resources/lang/it.json (19)

36-36: Duplicate: UI Leaderboard Description: Matches the Russian update for ui_leaderboard_desc. Italian translation reads correctly.


43-47: Duplicate: Events Panel Strings: The ui_events–ui_events_quickchat entries follow the established structure.


50-51: Duplicate: Player Overlay in Help: The ui_playeroverlay entries align with the reference.


55-57: Duplicate: Settings & Radial Menu Labels: The option_settings and radial_desc sections are translated consistently.


60-60: Duplicate: Radial Boat Entry: The radial_boat entry is accurate.


63-63: Duplicate: Enemy Info Description: The info_enemy_desc mapping is correct.


68-68: Duplicate: Trade Suspension Text: The info_trade string is well-translated.


71-73: Duplicate: Betrayal & Gold Donation: The betrayal and donation entries match the approved style.


75-75: Duplicate: Help Modal Build Menu: Builds menu descriptions follow the reference.

Also applies to: 82-82, 84-84, 86-86, 90-90


99-103: Duplicate: Player Icon Labels: The new icon entries align with other localizations.


145-146: Duplicate: Map Entries: baikal and halkidiki match other files.


230-231: Duplicate: Special Effects Settings: Matches the approved translation.


339-352: Duplicate: Top-Level Build Menu Section: The new build_menu entries follow the pattern.


353-361: Duplicate: Win Modal Section: Consistent with the reference.


362-370: Duplicate: Leaderboard UI Section: Matches the pattern.


371-387: Duplicate: Player Info Overlay Section: All keys mirror the Russian update.


388-394: Duplicate: Relation States Section: Correct translation.


395-401: Duplicate: Control Panel Labels: Matches the reference.


402-413: Duplicate: Player Panel Controls: Follows the approved pattern.

🧹 Nitpick comments (5)
src/client/LangSelector.ts (2)

8-8: Add Czech import – maintain alphabetical order

You imported cs after bn. For readability, consider ordering language imports alphabetically (e.g., place cs after bg and before de).


58-60: Register new languages in languageMap

You added cs and he entries to the languageMap. Confirm that any logic relying on key order remains valid, or reorder the map alphabetically for consistency.

resources/lang/fr.json (2)

75-75: Refine build menu prompt.

Construisez-en sounds odd in French. Consider Construisez-les or Construisez ou vérifiez combien vous en avez construit for smoother phrasing.


231-231: Add terminal punctuation.

special_effects_desc ends without a period. Consider adding one for consistency with other sentences.

resources/lang/es.json (1)

162-162: Suggest article for lobby join.

Unirse a Partida could be improved to Unirse a la Partida for correct Spanish grammar.

Also applies to: 166-167

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 1994f06 and c8cc157.

📒 Files selected for processing (12)
  • resources/lang/bg.json (6 hunks)
  • resources/lang/cs.json (1 hunks)
  • resources/lang/eo.json (5 hunks)
  • resources/lang/es.json (7 hunks)
  • resources/lang/fr.json (6 hunks)
  • resources/lang/he.json (1 hunks)
  • resources/lang/it.json (5 hunks)
  • resources/lang/ja.json (7 hunks)
  • resources/lang/nl.json (6 hunks)
  • resources/lang/ru.json (5 hunks)
  • resources/lang/uk.json (6 hunks)
  • src/client/LangSelector.ts (2 hunks)
🔇 Additional comments (78)
resources/lang/he.json (1)

1-415: New Hebrew localization file added – please verify key consistency

This Hebrew JSON appears comprehensive and well-structured. To prevent missing UI text, ensure that all keys (including nested sections like build_menu, win_modal, and new map entries) exactly match those in other language files. Also confirm that newline escapes (e.g., \n) and RTL rendering work correctly.

resources/lang/cs.json (1)

1-415: New Czech localization file added – ensure key parity

The new Czech translation covers every UI section. Please verify that its keys and structure are identical to the other language files (Hebrew, Ukrainian, etc.) so no translations are omitted at runtime.

resources/lang/uk.json (1)

35-146: Ukrainian translations updated – check matching changes across languages

The Ukrainian resource includes extensive additions (e.g., build_menu, win_modal, player_info_overlay, new map “halkidiki”). Ensure these new entries exist and are consistently formatted in all other language JSON files to maintain full localization coverage.

src/client/LangSelector.ts (1)

14-14: Add Hebrew import – verify path

The new he import is correct. Please double-check that resources/lang/he.json exists at this relative path to avoid runtime errors.

resources/lang/ja.json (1)

34-146: Japanese localization extended – check completeness

This update enriches the Japanese JSON with new UI elements and map entries like "baikal" and "halkidiki", plus player panel and build menu keys. Verify that these newly added keys are present and correctly spelled in all other language files to ensure consistent behavior.

resources/lang/ru.json (19)

36-36: Check UI Leaderboard Description: The new ui_leaderboard_desc entry is accurately translated, providing clear instructions for "Show all" and "Hide" actions.


43-47: Validate Events Panel Strings: The ui_events, ui_events_desc, ui_events_alliance, ui_events_attack, and ui_events_quickchat entries correctly mirror the English text and maintain consistent punctuation.


50-51: Verify Player Info Overlay in Help: The ui_playeroverlay and ui_playeroverlay_desc translations are complete and match the feature description.


55-55: Review Settings Option Label: The option_settings key now mentions ninja mode and left-click behavior. Translation looks correct.


57-57: Confirm Radial Menu Description: The radial_desc update clearly describes opening and closing the radial menu.


60-64: Check Radial Boat & Info Menu Entries: The radial_boat, radial_close, info_title, info_enemy_desc, and info_chat entries are accurately translated, covering boat attacks and chat instructions.


68-68: Validate Trade Info Text: The info_trade entry describes trade suspension correctly.


71-71: Review Alliance Betrayal & Gold Donation: The ally_betray and ally_donate_gold texts capture betrayal mechanics and gold donation options clearly.

Also applies to: 73-73


75-75: Review Help Modal Build Menu Entries: The build_menu_desc, build_defense_desc, build_port_desc, build_warship_desc, and build_sam_desc entries are now detailed and well-formatted.

Also applies to: 82-82, 84-84, 86-86, 90-90


100-100: Verify Player Icon Descriptions: The new icon_traitor, icon_embargo, and icon_request translations align with the updated iconography.

Also applies to: 102-103


145-146: Confirm New Map Locations: The baikal and halkidiki entries are added properly and match the additions in other language files.


230-231: Review Special Effects Settings: The special_effects_label and special_effects_desc entries clearly describe the performance toggle.


338-352: Approve Top-Level Build Menu Section: The newly added build_menu section with desc entries and not_enough_money message is structured correctly.


353-361: Approve Win Modal Section: The win_modal entries include victory and defeat messages along with action buttons, formatted consistently.


362-370: Approve Leaderboard UI Section: The standalone leaderboard section with headers (hide, rank, player, etc.) is well-defined.


371-387: Approve Player Info Overlay Section: The new player_info_overlay keys list all relevant stats and tooltips; translations are correct.


388-394: Approve Relation States Section: The relation attitude states (hostile, friendly, etc.) match the English semantics.


395-400: Approve Control Panel Labels: The control_panel entries (pop, gold, troops, workers, attack_ratio) are clear and concise.


402-413: Approve Player Panel Controls: The player_panel entries cover trade, alliance, nuke, and confirmation labels; translations are consistent.

resources/lang/bg.json (1)

217-217: Review Unit Type Update: The sam_launcher label was updated to the full "Противоракетна установка земя-въздух SAM" string. This matches the new terminology; good.

resources/lang/fr.json (22)

36-36: Verify translation consistency for "Show All" label.

The string uses the English phrase «Show All» inside French text. Confirm if this button label should remain in English or be localized (e.g., «Tout afficher»).


41-41: Approve troop/worker slider description.

The new ui_troops_workers string correctly explains the slider functionality in French.


43-47: Approve event panel translations.

The keys ui_events, ui_events_desc, ui_events_alliance, ui_events_attack, and ui_events_quickchat are well translated and cover the new UI events feature accurately.


55-55: Approve settings menu label.

option_settings is clear and consistent with other French UI labels.


58-58: Approve radial menu description.

The radial_desc translation is accurate and user-friendly.


60-60: Approve boat attack option.

radial_boat clearly describes the transport ship attack action.


64-64: Approve quick chat instruction.

info_chat gives concise instructions for sending quick chat messages.


68-68: Consistent use of infinitive.

The info_trade string uses the infinitive Utiliser, matching other ally_* keys. No change needed.


73-73: Approve gold donation text.

ally_donate_gold aligns with the troop donation phrasing and is grammatically correct.


82-82: Approve defense post description.

build_defense_desc correctly conveys the defensive benefit with clear French syntax.


84-84: Approve port description.

build_port_desc accurately explains port mechanics and trade suspension details.


86-86: Approve warship description.

build_warship_desc is detailed and properly localized.


90-90: Approve SAM launcher text.

build_sam_desc clearly states interception probabilities and cooldown.


99-103: Approve new icon labels.

The added keys icon_crown, icon_traitor, icon_embargo, icon_request are correctly described in French.


145-146: Approve new map locations.

baikal → Lac Baïkal and halkidiki → Chalcidique are correct French names.


339-352: Approve nested build menu translations.

The new build_menu object with its desc sub-keys and not_enough_money fits the structure and is properly localized.


354-361: Approve win modal messages.

win_modal entries are clear and match the game's end-state UI.


363-370: Approve leaderboard labels.

The leaderboard keys for title, hide, rank, etc., are well translated.


371-387: Approve player info overlay fields.

All stats and labels (d_troops, a_troops, ports, etc.) are accurate French translations.


388-394: Approve relation status translations.

hostile, distrustful, neutral, friendly, default are all correctly localized.


395-401: Approve control panel labels.

The control_panel translations align well with UI terminology.


402-412: Approve player panel actions.

Keys like start_trade, stop_trade, embargo are clearly described.

resources/lang/es.json (31)

9-16: Approve main lobby text.

The Spanish translations for title, login/logout, and lobby actions are clear and consistent.


22-33: Approve help modal shortcuts.

Keyboard action descriptions (Atajos de Teclado, Acción, etc.) are correctly localized.


36-36: Approve leaderboard description.

The ui_leaderboard_desc string accurately reflects the leaderboard functionality in Spanish.


41-42: Approve troop and attack ratio descriptions.

ui_troops_workers and ui_attack_ratio are well phrased and user-friendly.


43-47: Approve event panel strings.

ui_events and its child keys give comprehensive instructions and are correctly translated.


55-55: Approve settings menu text.

option_settings clearly describes the toggles available in the settings menu.


57-57: Approve radial menu instructions.

The radial_desc translation is consistent with the French and English versions.


63-63: Approve enemy info panel.

info_enemy_desc correctly describes trade suspension mechanics in Spanish.


64-64: Approve quick chat placeholders.

to and from use the placeholders {user} and {msg} properly.


71-73: Approve alliance actions.

ally_betray, ally_donate, and ally_donate_gold are clear directives.


84-84: Approve port description.

build_port_desc is detailed and grammatically correct.


86-86: Approve warship description.

build_warship_desc reads well and is accurate.


90-90: Approve SAM launcher text.

build_sam_desc clearly conveys interception probabilities.


99-103: Approve new icon labels.

Spanish descriptions for crown, traitor, embargo, and alliance-request icons are correct.


121-121: Approve map name additions.

Lago Baikal and Halkidiki fit Spanish naming; ensure consistency with other localizations.

Also applies to: 138-147


149-151: Approve map categories.

Continental, Regional, Otro are accurate.


174-174: Approve username validations.

Placeholders {min} and {max} in username errors are correctly used.


179-179: Approve host modal labels.

Team count, settings toggle, and waiting messages are well localized.

Also applies to: 187-187, 190-190


193-196: Approve game starting modal.

The game_starting_modal strings are concise and appropriate.


205-205: Approve game mode label.

Todos contra todos clearly describes FFA mode.


208-210: Approve language selector prompt.

Selecciona idioma is brief and understandable.


211-220: Approve unit type names.

Spanish unit type terms match their English counterparts.


223-265: Approve user settings section.

All toggles, labels, and descriptions are correctly translated and clear.


266-269: Approve chat root keys.

chat.title, to, from entries correctly map message direction.


339-352: Approve nested build menu.

The Spanish build_menu object with its desc keys and not_enough_money aligns with the French version.


354-361: Approve win modal texts.

End-of-game messages are accurately localized.


363-370: Approve leaderboard headers.

Table headings for ranking, owned, gold, troops are well translated.


372-387: Approve player info overlay fields.

Statistics and labels (Tropa defensoras, Lanzamisiles, etc.) are clear and correct.


389-394: Approve relation statuses.

The attitude labels are consistent and correctly rendered.


396-401: Approve control panel labels.

UI labels for population, gold, troops, etc., are descriptive and accurate.


403-412: Approve player panel controls.

Trade buttons and status messages appropriately localized.

Comment thread resources/lang/fr.json
Comment on lines +268 to +269
"to": "Envoyé à {user} : {msg}",
"from": "De {user} : {msg}",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix chat placeholder entries.

The to key contains the full quick-chat instructions instead of a simple placeholder format. It appears swapped with info_chat. Please swap the translations so that:

  • to: Envoyé à {user} : {msg}
  • from: De {user} : {msg}
🤖 Prompt for AI Agents
In resources/lang/fr.json around lines 268 to 269, the translation for the "to"
key is incorrect and swapped with "info_chat". Swap the values so that "to" is
set to "Envoyé à {user} : {msg}" and "from" remains "De {user} : {msg}" to fix
the placeholder usage.

Comment thread resources/lang/fr.json
Comment on lines +50 to +51
"ui_playeroverlay": "Informations sur le joueur",
"ui_playeroverlay_desc": "Lorsque vous survolez un pays, le panneau d'informations sur le joueur s'affichent dans Options. Il montre le type de joueur : Humain, Nation (bot intelligent), ou Bot ; l'attitude d'une nation à votre égard. allant de l'Hostile à l'Amical ; et les troupes en défense, l'or, le nombre de navires de guerre et les différents bâtiments que le joueur possède.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix singular/plural agreement.

The phrase le panneau d'informations sur le joueur s'affichent uses the plural verb s'affichent for the singular subject le panneau. It should be s'affiche.

🤖 Prompt for AI Agents
In resources/lang/fr.json around lines 50 to 51, the phrase "le panneau
d'informations sur le joueur s'affichent" uses the plural verb "s'affichent"
incorrectly with the singular subject "le panneau". Change the verb to the
singular form "s'affiche" to fix the subject-verb agreement.

Comment thread resources/lang/es.json
Comment on lines +50 to +51
"ui_playeroverlay": "Panel de información del jugador",
"ui_playeroverlay_desc": "Cuando pongas el cursor sobre un país, la información del jugador se muestra bajo Opciones. Muestra el tipo de jugador: Humano, Nación (bot inteligente), o Bot.; la actitud de una nación hacia ti, que va desde hostil hasta amistoso; y la tropas defensoras, el oro, alos barcos de guerra y la cantidad de edificios que el jugador tiene.",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️ Potential issue

Fix grammar in player overlay.

The phrase la tropas defensoras, el oro, alos barcos de guerra has a typo alos (should be a los) and the article for tropas defensoras should be plural (las tropas defensoras).

🤖 Prompt for AI Agents
In resources/lang/es.json around lines 50 to 51, fix the grammar in the phrase
describing player overlay information by changing "la tropas defensoras" to "las
tropas defensoras" to match plural article usage, and correct the typo "alos" to
"a los" to properly separate the article and preposition.

@github-project-automation github-project-automation Bot moved this from Triage to Development in OpenFront Release Management May 26, 2025

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
resources/lang/bg.json (1)

63-63: Enemy info description
The lengthy info_enemy_desc is properly escaped and punctuated. Consider verifying the curly quotes („Прекратяване на търговия“) match project style, but syntax is valid.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between c8cc157 and a848592.

📒 Files selected for processing (1)
  • resources/lang/bg.json (6 hunks)
🔇 Additional comments (23)
resources/lang/bg.json (23)

36-47: Help modal descriptions
The new entries under help_modal (ui_leaderboard_desc through ui_events_quickchat) are well-structured and mirror the English keys accurately. The JSON is valid and the escaped quotes are correct.


50-51: Player info overlay in help modal
The ui_playeroverlay key and its description appear correct and consistent with other languages.


55-55: Settings option text
The option_settings description uses a dash consistently and clearly explains toggles.


57-60: Radial menu entries
radial_desc and radial_boat are correctly added and match the English structure. No JSON syntax issues.


68-68: Trade info entry
info_trade addition is clear and aligns with functionality.


71-73: Ally actions
Entries for ally_betray and ally_donate_gold match new UI features and use consistent terminology.


75-75: Build menu description
build_menu_desc clearly explains the feature and follows JSON conventions.


82-82: Defense post description
build_defense_desc reads well and is grammatically correct in Bulgarian.


84-84: Port description
build_port_desc entry is detailed and ends with a period, matching style.


86-86: Warship description
build_warship_desc is accurate and conveys controls clearly.


90-90: SAM launcher description
build_sam_desc uses correct numeric and unit notation (“100 пиксела”).


100-103: Icon keys
icon_traitor, icon_embargo, and icon_request entries are consistent with the new icon set and properly formatted.


145-146: New map locations
baikal and halkidiki added under map match the English keys and JSON structure.


217-217: Unit type SAM key
sam_launcher in unit_type is correctly named and matches the build menu.


230-231: Special effects setting
special_effects_label and special_effects_desc are clear and mirror UI functionality.


339-352: Build menu root section
The new top-level build_menu object and its desc sub-keys plus not_enough_money are valid JSON and follow existing patterns.


353-361: Win modal translations
All keys under win_modal are present, translated, and end with appropriate punctuation.


362-370: Leaderboard UI
leaderboard section keys (title, hide, rank, etc.) are correctly introduced with valid strings.


371-387: Player info overlay root
All player_info_overlay keys have been translated and structured consistently.


388-394: Relation states
relation entries are complete and follow the same translation style.


395-400: Control panel keys
control_panel entries align with the UI and are formatted correctly.


402-412: Player panel translations
player_panel keys (gold, troops, traitor, etc.) are all present and clearly translated.


1-415:

Details

✅ Verification successful

Verify translation key consistency
To avoid missing or extra keys in Bulgarian locale vs. other languages, please compare key lists across JSON files.

Run:


🏁 Script executed:

#!/bin/bash
# Extract and sort JSON paths for each locale
jq -r 'paths | map(tostring) | join(".")' resources/lang/bg.json | sort > bg_keys.txt
jq -r 'paths | map(tostring) | join(".")' resources/lang/cs.json | sort > cs_keys.txt
jq -r 'paths | map(tostring) | join(".")' resources/lang/he.json | sort > he_keys.txt

# Compare
diff -u bg_keys.txt cs_keys.txt
diff -u bg_keys.txt he_keys.txt

Length of output: 289


🏁 Script executed:

#!/bin/bash
set -eu

echo "Locales in resources/lang:"
ls resources/lang

echo
echo "Counting translation keys per locale:"
for file in resources/lang/*.json; do
  count=$(jq -r 'paths | map(tostring) | join(".")' "$file" | wc -l)
  echo "  $(basename "$file"): $count keys"
done

echo
echo "Comparing bg.json vs cs.json:"
diff -u <(jq -r 'paths | map(tostring) | join(".")' resources/lang/bg.json | sort) \
         <(jq -r 'paths | map(tostring) | join(".")' resources/lang/cs.json | sort) \
  || echo "  → No differences found"

echo
echo "Comparing bg.json vs he.json:"
diff -u <(jq -r 'paths | map(tostring) | join(".")' resources/lang/bg.json | sort) \
         <(jq -r 'paths | map(tostring) | join(".")' resources/lang/he.json | sort) \
  || echo "  → No differences found"

Length of output: 5805


🏁 Script executed:

#!/usr/bin/env bash
set +e

# Generate and sort key lists for bg, cs, he locales
jq -r 'paths | map(tostring) | join(".")' resources/lang/bg.json | sort > bg_keys.txt
jq -r 'paths | map(tostring) | join(".") | sort > cs_keys.txt
jq -r 'paths | map(tostring) | join(".")' resources/lang/he.json | sort > he_keys.txt

# Compare key lists
echo "Comparing bg.json vs cs.json:"
diff -u bg_keys.txt cs_keys.txt

echo
echo "Comparing bg.json vs he.json:"
diff -u bg_keys.txt he_keys.txt

exit 0

Length of output: 358


🏁 Script executed:

#!/usr/bin/env bash

# Extract and sort JSON paths for bg, cs, he
for loc in bg cs he; do
  jq -r 'paths | map(tostring) | join(".")' "resources/lang/${loc}.json" | sort > "${loc}_keys.txt"
done

# Compare key lists
echo "Comparing bg.json vs cs.json:"
diff -u bg_keys.txt cs_keys.txt || :

echo
echo "Comparing bg.json vs he.json:"
diff -u bg_keys.txt he_keys.txt || :

Length of output: 501


Translation keys are consistent across locales
All 380 keys in resources/lang/bg.json match those in cs.json and he.json. No missing or extra entries were found.

@Aotumuri Aotumuri added this to the v23 milestone May 27, 2025
@Aotumuri Aotumuri added Translation Addition or modification of a language to the translations. Translation - Revision labels May 27, 2025
@Aotumuri Aotumuri linked an issue May 27, 2025 that may be closed by this pull request
Closed
@evanpelle
evanpelle merged commit 9a49ece into openfrontio:main May 27, 2025
@github-project-automation github-project-automation Bot moved this from Development to Complete in OpenFront Release Management May 27, 2025
evanpelle added a commit that referenced this pull request May 27, 2025
## Description:
mls for v23
Version identifier within MLS: v3.2

## Please complete the following:

- [x] I have added screenshots for all UI updates
- [x] I confirm I have thoroughly tested these changes and take full
responsibility for any bugs introduced
- [x] I understand that submitting code with bugs that could have been
caught through manual testing blocks releases and new features for all
contributors

## Please put your Discord username so you can be contacted if a bug or
regression is found:

aotumuri

---------

Co-authored-by: Duwibi <86431918+Duwibi@users.noreply.github.com>
Co-authored-by: evanpelle <evanpelle@gmail.com>
@coderabbitai coderabbitai Bot mentioned this pull request Jul 3, 2025
5 tasks done
@coderabbitai coderabbitai Bot mentioned this pull request Jul 18, 2025
5 tasks done
@coderabbitai coderabbitai Bot mentioned this pull request Jun 28, 2026
4 tasks done
R-Andrei added a commit to R-Andrei/open-fufu-io that referenced this pull request Sep 12, 2026
OF-ISSUE178-20260911-C4E7A1

Finding: PR #179 is CERTIFIED at exact head 52496aa. Its four documentation files are unchanged on current main since the original audit; current-main reconciliation against adcb4af is reviewed-no-relevant-overlap. Documentation Authority run openfrontio#642 and Open Fufu Owned Validation run openfrontio#888 are successful, there are no review threads, and the PR has no closing reference.

Conclusion: merge only the documentation-authority cleanup. This merge does not close #178 and does not change executable behavior or gameplay mechanics.

Recommended next action: verify the merge and branch cleanup, then begin the bounded acquisition/read-surfaces vertical audit for #178 against the new main.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Translation Addition or modification of a language to the translations.

Projects

Status: Complete

Development

Successfully merging this pull request may close these issues.

MLS

4 participants