Repository navigation
Fix: Use UserWarning for unauthenticated duplicate run checks (Fixes #1210) - #1484
Conversation
|
Hi @PGijsbers, I have submitted this fix for #1210. I updated the warning to a UserWarning and added the specific check for the missing API key as discussed. Could you please review this when you have a moment? It looks like the GitHub workflows (CI) are waiting for approval to run as well. Thanks! |
…grawal/openml-python into fix/1210-auth-warning
for more information, see https://pre-commit.ci
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1484 +/- ##
==========================================
- Coverage 51.41% 51.24% -0.17%
==========================================
Files 63 63
Lines 5565 5565
==========================================
- Hits 2861 2852 -9
- Misses 2704 2713 +9 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
PGijsbers
left a comment
There was a problem hiding this comment.
Thanks for taking the time to contribute. We were flooded with PRs and unable to process them, so sorry for the delay in our response. The linked issue was supposed to be closed. However, I do think the clarification that the run proceeds with the risk of duplicates is a useful addition. Moreover, the UserWarning is probably more appropriate than the RuntimeWarning. So I am merging this now. Thanks again!
Description
This PR fixes #1210 by improving the warning message when
avoid_duplicate_runs=Trueis used without an API key.Changes:
RuntimeWarningwith aUserWarning.openml.config.apikey is None.Type of change
How Has This Been Tested?
I verified this locally by mocking
openml.runs.run_model_on_taskwithapikey=Noneand asserting that the newUserWarningis triggered correctly.