Skip to content

CORENET-6864, CORENET-6169: remove some duplicate ovnk test cases - #31822

Open
jluhrsen wants to merge 1 commit into
openshift:release-4.21from
jluhrsen:corenet-6864-remove-duplicate-ovnk-tests
Open

jluhrsen wants to merge 1 commit into
openshift:release-4.21from
jluhrsen:corenet-6864-remove-duplicate-ovnk-tests

Conversation

@jluhrsen

Copy link
Copy Markdown
Contributor

This is a recreation of #30940 (which went stale and has merge conflicts that can't be resolved by a non-author).

These test cases are duplicates of tests that already exist in the ovn-kubernetes repo. Removing them from origin to reduce test maintenance burden.

Cherry-pick of #30820.

/assign jluhrsen

Made with Cursor

@openshift-merge-bot

Copy link
Copy Markdown
Contributor

Pipeline controller notification

This PR uses the pipeline controller for second-stage tests. Selection and triggering follow the repository configuration.

Use /test ? to list jobs and /pipeline help for commands.

@openshift-ci-robot openshift-ci-robot added the jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. label Oct 28, 2026
@openshift-ci-robot

openshift-ci-robot commented Oct 28, 2026 •

Copy link
Copy Markdown

@jluhrsen: This pull request references CORENET-6864 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.21.z" version, but no target version was set.

This pull request references CORENET-6169 which is a valid jira issue.

Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the story to target the "4.21.z" version, but no target version was set.

Details

In response to this:

This is a recreation of #30940 (which went stale and has merge conflicts that can't be resolved by a non-author).

These test cases are duplicates of tests that already exist in the ovn-kubernetes repo. Removing them from origin to reduce test maintenance burden.

Cherry-pick of #30820.

/assign jluhrsen

Made with Cursor

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository.

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Important

Review skipped

Auto reviews are disabled on base/target branches other than the default branch.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Central YAML; Path: .coderabbit.yaml
  • Review profile: CHILL
  • Plan: Enterprise
  • Run ID: 533de716-bd0a-4e31-bac6-1c370b0efdbc

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

Comment @coderabbitai help to get the list of available commands.

@openshift-ci openshift-ci Bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2026
@jluhrsen
jluhrsen force-pushed the corenet-6864-remove-duplicate-ovnk-tests branch from 1bb8a4c to 3e33a69 Compare October 28, 2026 18:10
@openshift-ci openshift-ci Bot removed the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Oct 28, 2026
@martinkennelly

Copy link
Copy Markdown
Contributor

Do you need help?

These test cases are duplicates of tests that already exist in the ovn-kubernetes
repo. Removing them from origin to reduce test maintenance burden.

Co-authored-by: Cursor <cursoragent@cursor.com>
@jluhrsen
jluhrsen force-pushed the corenet-6864-remove-duplicate-ovnk-tests branch from 3e33a69 to 4eb5a0e Compare October 30, 2026 21:12
@jluhrsen

Copy link
Copy Markdown
Contributor Author

Do you need help?

@martinkennelly , yes please. can you type a /lgtm for me ? :)

@openshift-ci openshift-ci Bot added the vendor-update Touching vendor dir or related files label Oct 30, 2026
@openshift-ci

openshift-ci Bot commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: jluhrsen
Once this PR has been reviewed and has the lgtm label, please assign smg247 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Details Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

Chai test selection for 4eb5a0ee3b864abe7b38492d465613edffa1d9de → release-4.21

  • pull-ci-openshift-origin-release-4.21-e2e-gcp-ovn

Reason: This PR removes 4 duplicate NetworkSegmentation/UDN test cases and 3 associated helper functions from test/extended/networking/network_segmentation.go, along with the containernetworking/cni dependency and its vendor tree which was only used by the removed assertNADConfig helper. The ovn-kubernetes/.../cni/types vendor file was also removed for the same reason. Changed surfaces: - Test code (−175 lines): Removes It("should create NetworkAttachmentDefinition according to spec"), It("should create NAD according to spec in each target namespace..."), It("should create NAD in new created namespaces..."), It("should create NAD in namespaces that apply to mutated namespace-selector"), plus helpers assertNADConfig, assertNetAttachDefManifest, assertClusterNADManifest. No remaining test references any removed function. - Dependency (go.mod/go.sum/vendor/): Removes containernetworking/cni v1.3.0 direct dependency and ovn-kubernetes/.../cni/types vendor file, both exclusively consumed by removed code. First-stage go-verify-deps and verify-deps confirm no remaining import. Selection: e2e-gcp-ovn provides general e2e validation on GCP/OVN exercising the test binary with the dependency removed and covering the sig-network test surface. No other candidate is relevant — the change does not touch Jenkins, builds, image-registry, CSI, kubevirt, microshift, upgrade, or platform-specific code.

/test e2e-gcp-ovn

@redhat-chai-bot

Copy link
Copy Markdown
Contributor

/pipeline mark-pipeline-gate 4eb5a0e

@openshift-ci

openshift-ci Bot commented Oct 31, 2026

Copy link
Copy Markdown
Contributor

@jluhrsen: all tests passed!

Full PR test history. Your PR dashboard.

Details

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

jira/valid-reference Indicates that this PR references a valid Jira ticket of any type. vendor-update Touching vendor dir or related files

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants