Repository navigation
add CSV markers to go/v3 testdata - #5641
Merged
theishshah merged 3 commits intoApr 8, 2022
Merged
theishshah merged 3 commits into
theishshah merged 3 commits into
Conversation
this change makes it so that all the scorecard bundle tests pass when using the go/v3/memcached-operator testdata fixes operator-framework#4564 Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
update the scorecard tests for go operators only as ansible & helm did not have CSV markers added fixes operator-framework#4564 Signed-off-by: Bryce Palmer <bpalmer@redhat.com>
Contributor
|
/lgtm |
theishshah
approved these changes
Apr 8, 2022
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of the change:
Adds CSV markers to the generation logic that creates the testdata within the
testdata/go/v3/memcached-operator/directory.Motivation for the change:
This change makes it so that when running
operator-sdk scorecard bundleinside thetestdata/go/v3/memcached-operator/directory all the scorecard tests should pass.fixes #4564
Checklist
If the pull request includes user-facing changes, extra documentation is required:
changelog/fragments(seechangelog/fragments/00-template.yaml)website/content/en/docs