Repository navigation
fix comparison result depends on operand order (#10888) - #10942
Open
dritter-sap wants to merge 3 commits into
Open
dritter-sap wants to merge 3 commits into
dritter-sap wants to merge 3 commits into
Conversation
tglman
reviewed
Oct 16, 2026
tglman
left a comment
tglman
left a comment
Member
There was a problem hiding this comment.
This looks good for now, I'm not 100% convinced by this, in the long term there was the plano of "normalization of conditions" so in practice flip condition "a" = field to field = "a" this would help for index lookups and also this cases, for now we could merge this, but then it will become redundant as normalization is done
|
|
||
| // regression: #10888 | ||
| @Test | ||
| public void test_issue10888_operandOrderSymmetry() { |
Member
There was a problem hiding this comment.
Naming do not respect java convention
| // regression: #10888 | ||
| @Test | ||
| public void test_issue10888_operandOrderSymmetry() { | ||
| db.command("CREATE CLASS D10888").close(); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #10888.