Skip to content

perf(web): the proposed plan card compiles without manual memoization - #20707

Merged
juliusmarminge merged 1 commit into
mainfrom
rc2/proposed-plan-card
Oct 17, 2026
Merged

juliusmarminge merged 1 commit into
mainfrom
rc2/proposed-plan-card

Conversation

@juliusmarminge

Copy link
Copy Markdown
Member

ProposedPlanCard wrapped its find-reveal handler in a manual useCallback, which kept it out of the React Compiler strict bar.

The handler is now an inline arrow that the compiler hoists to a constant, so the find-reveal ref still attaches its listener once. The file joins REACT_COMPILED_FILES. No behaviour change.

🤖 Generated with Claude Code (Claude Opus 5.5)

@github-actions github-actions Bot added vouch:trusted Author is trusted by repo permissions or the VOUCHED list. size:XS 0-9 changed lines (additions + deletions). labels Oct 17, 2026
@macroscopeapp

ghost commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Approvability

Verdict: Approved at 61a5924

Macroscope's review found this PR approvable — This is a small, isolated React performance refactor that removes redundant manual memoization while preserving the existing find-reveal behavior. It introduces no new capability, default, schema, deployment, or static-analysis suppression.

Notes:

  • All code in this push has already been reviewed. Approvability was decided on eligibility alone.

You can add or adjust custom eligibility rules. Learn more.

macroscopeapp[bot]
macroscopeapp Bot previously approved these changes Oct 17, 2026
@coderabbitai

ghost commented Oct 17, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: 0a2f651f-f923-4683-b41c-63717c0f9189
📥 Commits

Reviewing files that changed from the base of the PR and between 742b22a and 61a5924.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • 🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration
  • Configuration used: Path: .coderabbit.config.ts
  • Review profile: CHILL
  • Plan: Team
  • Run ID: de6d97d3-4f4d-40c3-b5d7-dd307d1da0d4
📥 Commits

Reviewing files that changed from the base of the PR and between 70d60e0 and 742b22a.

📒 Files selected for processing: 2
  • apps/web/reactCompiledFiles.ts
  • apps/web/src/components/chat/ProposedPlanCard.tsx

Limit details: You’ve used all 10 included reviews currently available.

📝 Walkthrough

ProposedPlanCard now uses an inline find-reveal callback. The component is also included in the React Compiler file list.

Changes: Proposed plan card

Layer / File(s) Summary
Find-reveal callback and compiler coverage
apps/web/src/components/chat/ProposedPlanCard.tsx, apps/web/reactCompiledFiles.ts
The find-reveal handler sets expanded to true through an inline callback. ProposedPlanCard.tsx is added to the React Compiler file list.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Refactor

Suggested reviewers: noojuno

Merge Risk: ⚪ Minimal · up to 742b2

The find-reveal handler continues to expand the plan, and the web build preserves the stable callback required by the hook. No concrete PR-introduced behavior risk is established.

Pre-merge checks: Passed 3 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the problem and the code change, but it omits the required Scope and approval and Verification sections. It also does not provide test results or manual-check details. Add the required Problem, Change, Scope and approval, and Verification headings. Document the issue or approval basis, focused verification steps, observed results, and any checks that were not run.
Passed Passed checks: 3 passed
Check name Status Explanation
Title check Passed The title clearly and concisely describes the main change: removing manual memoization so ProposedPlanCard passes React Compiler checks.
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches: 💡 1
🛠️ Fix failing CI checks: 💡
  • Commit to this branch
  • Create a new PR
📝 Generate docstrings
  • Commit to this branch
  • Create a new PR
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Comment @coderabbitai help to get the list of available commands.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@macroscopeapp
macroscopeapp Bot dismissed their stale review October 17, 2026 04:30

Dismissing prior approval to re-evaluate 61a5924

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

size:XS 0-9 changed lines (additions + deletions). vouch:trusted Author is trusted by repo permissions or the VOUCHED list.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant