[tanav29]

Windows Markdown destinations such as C:\R&D folder\.t3\shot.png lose the separator before .t3, so links and images name the wrong file. Preserve authored Windows separators while decoding Markdown character references once, using micromark's existing decoder.

Closes #36579. The earlier fix PR #36580 is closed and unmerged; this independently written replacement is limited to the shared destination parser. Mobile already escapes its own destinations and does not use this destination extension.

Verification (Windows, Node 24.21.0):

• Added cases to the existing parser suite. Four cases fail on upstream before the fix, including literal ampersands, named/numeric references, and a separator before an entity-shaped directory. All pass afterward for links, images, and reference definitions.
• cd packages/shared; vp test run --config ../../vite.config.ts src/markdownWindowsPaths.test.ts src/markdownPipeline.test.ts: 34 tests pass.
• Shared package typecheck, changed-file lint/format, and commit hook knip checks pass. The decoder was already a transitive dependency; the lockfile adds only the direct dependency/catalog entries.
• The required check:changed runner was attempted during this task but its initial ignored-generated-file Git scan stalled on this Windows checkout. Full affected-package checks are not claimed. No image-opening browser or native-device capture was made; this PR proves the destination parsing boundary.

This is a small fix for an existing parser defect, without new UI, settings, contracts, or provider behavior.

Written with GPT-6.1 Sol through the Codex harness in T3 Code.

[macroscopeapp]

Approvability

Verdict: Approved at bc46cf2

Macroscope's review found this PR approvable — This preserves Windows path separators beside ampersands while still decoding Markdown character references. The change is confined to destination parsing, with existing rendering and file-access safeguards unchanged.

^{You can add or adjust custom eligibility rules. Learn more.}

[coderabbitai]

No actionable comments were generated in the recent review.

Walkthrough

Windows absolute Markdown destinations now preserve path separators while decoding character references. The shared package adds the decoder dependency and tests for links, images, and reference definitions.

Changes: Windows Markdown path decoding

Layer / File(s)	Summary
Windows destination decoding pnpm-workspace.yaml, packages/shared/package.json, packages/shared/src/markdownWindowsPaths.ts, packages/shared/src/markdownWindowsPaths.test.ts	The shared package adds micromark-util-decode-string. For Windows absolute destinations, the handler escapes authored backslashes and decodes the text. Tests cover literal ampersands and encoded references in links, images, and definitions.

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Bug fix · Severity of issue fixed: Low

Suggested reviewers: aksharp5

Merge Risk: Minimal · up to bb7c5

Windows Markdown paths containing spaces and ampersands now keep their separators and decode character references once. Impact is confined to the shared parser, and the tests cover the reported cases. The risk of merging is minimal.

Pre-merge checks: 4

Check name	Status	Explanation
Title check		The title names the main change: Windows path separators are kept when the destination contains ampersands. It follows the conventional commit format and is specific to the parser fix. It does not cov…
Description check		The description follows the template's main sections in substance. It gives the problem, the change, and a scope link to issue #36579 with a note on the closed earlier PR. It also gives detailed verif…
Linked Issues check		[#36579] requires three behaviors for Windows absolute Markdown destinations: (1) keep the separator before .t3 in C:\\R&D folder\\.t3\\shot.png, (2) decode & character references once, and (3)…
Out of Scope Changes check		All changes connect to #36579. The parser change in markdownWindowsPaths.ts is the fix. The test additions in markdownWindowsPaths.test.ts verify it. The packages/shared/package.json change adds…

Full details: Title check

Explanation

The title names the main change: Windows path separators are kept when the destination contains ampersands. It follows the conventional commit format and is specific to the parser fix. It does not cover the decoding detail, which is expected.

Full details: Description check

Explanation

The description follows the template's main sections in substance. It gives the problem, the change, and a scope link to issue #36579 with a note on the closed earlier PR. It also gives detailed verification with commands, results, and unverified items. The template's comment asks for a commit-style title, and the description does not restate it, but that is not required content. The description also lacks an explicit section heading for Problem, Change, Scope, and Verification, so its structure differs from the template. The agent-attribution line at the end is present. Overall the content is mostly complete.

Full details: Linked Issues check

Explanation

[#36579] requires three behaviors for Windows absolute Markdown destinations: (1) keep the separator before .t3 in C:\R&D folder\.t3\shot.png, (2) decode & character references once, and (3) apply the same result to images, links, and reference definitions. The change summary for packages/shared/src/markdownWindowsPaths.ts states that keepWindowsPathDestination now escapes backslashes in the authored text and decodes the result once with decodeString from micromark-util-decode-string. This preserves authored separators and decodes references. Before the change, destinations containing & used the parsed URL, which dropped the separator. The change summary for markdownWindowsPaths.test.ts reports added cases for literal ampersands, named and numeric references, and a separator before an entity-shaped directory, across links, images, and definitions. The PR reports that four of these cases failed before the fix and pass after it. Limits: this assessment had no repository read access in this run. Source hunks and test output were not inspected directly. The pass rests on the change summary and the author's reported test results. Non-Windows destinations keep the parsed URL, which matches the issue scope. Mobile is not affected, per the issue.

Full details: Out of Scope Changes check

Explanation

All changes connect to #36579. The parser change in markdownWindowsPaths.ts is the fix. The test additions in markdownWindowsPaths.test.ts verify it. The packages/shared/package.json change adds micromark-util-decode-string as a direct dependency, because the parser imports decodeString. The pnpm-workspace.yaml catalog entry at version 2.0.1 supplies that version. The summary shows no UI, settings, contract, or provider change. pnpm-lock.yaml is in ignored_files and was not inspected. Its exclusion does not affect this verdict, because it only records the dependency entries added in package.json and the catalog.

Finishing Touches

Generate unit tests (beta)

• Create a new PR

• Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Recent review info

Run configuration

• Source mode: Auto
• Repository: pingdotgg/t3code
• Branch: main
• File: .coderabbit.config.ts
• Commit: 3808e2d
• Layers: Repository TS config
• Review profile: CHILL
• Plan: Advanced
• Run ID: 05a0fc0d-1198-42a8-bf16-d387df2e102b

Commits

Reviewing files that changed from the base of the PR and between bc46cf2 and bb7c58d.

Files ignored due to path filters: 1

• pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

Files selected for processing: 1

• packages/shared/src/markdownWindowsPaths.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

[juliusmarminge]

Evidence

All captures: real Windows Server 2025, Chromium web client, dark theme, 1440×1000 viewport. Each commit ran its own server and fresh T3 home.

Placed the green PNG at C:\R&D folder\.t3\shot.png and a distinct blue PNG at C:\R&D folder\.t3\shot.png. Replayed agent replies with inline image/link destinations containing literal & and &, then reference-style image/link definitions with both spellings. Viewed each image and clicked each link. Also authored & to verify that exactly one decode selects the blue PNG.

Base loses the separator before .t3: images are unavailable and clicking links reports “Media file was not found.” Head loads the intended files in all five cases.

Case	Before	After
Commit	3808e2d77e	bb7c58dba7
Literal ampersand
Character reference
Reference literal
Reference encoded
Decode exactly once
Open literal-path link
All five interactions	Before recording	After recording

Recordings trim initial pairing/startup and crop the same top 120 pixels to exclude the environment label during navigation; stills retain the full viewport.

Seed script · Browser driver · Fixture preparation · All 25 stills and recordings · Complete evidence and fixtures

Not shown:

• Desktop and mobile clients were not separately run; this proof covers the Windows web client.