Skip to content

Feat/export as html table - #22

Merged
jpreese merged 4 commits into
plexsystems:mainfrom
baprx:feat/export-as-html-table
Aug 1, 2022
Merged

jpreese merged 4 commits into
plexsystems:mainfrom
baprx:feat/export-as-html-table

Conversation

@baprx

@baprx baprx commented Jun 30, 2022

Copy link
Copy Markdown
Contributor

This PR allow the user to export the prometheus alerts as an HTML file.
I added a go test so you can view an example here: examples/html/expected.html

This PR needs #21 to be merged first since I used it as my base.

Tell me if you have any question or want to change something.

Thanks

@jpreese

jpreese commented Jul 31, 2022

Copy link
Copy Markdown
Collaborator

@baprx @tpoindessous the other two PRs have been merged (thanks a ton! 🎉) which has caused some conflicts with this one.

Once these conflicts are resolved, which looks to just be re-running the generate, I'll merge this and create a new release which should also include the new arm binary.

@baprx

baprx commented Jul 31, 2022

Copy link
Copy Markdown
Contributor Author

Hey @jpreese thanks for merging my other PR, I resolved the conflicts in my latest commit.

@jpreese
jpreese merged commit 7bebdc6 into plexsystems:main Aug 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants