Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds a regression test for
_get_click_help_text()building the help context fromcmd.context_classrather than a plainclick.Context.This is the behavior that makes help rendering work for commands whose context builds a custom formatter — Typer's vendored Click and rich-click's
RichContext, for example. The existingcontext_classimplementation is correct; this test pins it.The test defines a
click.Commandwith a custom context/formatter that requires aconfigattribute, then asserts_get_click_help_text()returns the usage text. Against the oldclick.Context(cmd, ...)construction the test fails with:With
cmd.context_class(...)it passes.Tests
PYTHONPATH=$PWD pytest tests/test_cli_help_context.py -q→ 1 passedclick.Context(cmd, ...); the test failed with the expectedAttributeError.No production code changes.
Checklist