Repository navigation
feat: add get_row_flags() and duplicate handling for sundering - #533
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds
Validate.get_row_flags(), which returns the target table with apb_failed_<i>_column for each row-level step, pluspb_n_failed_(the number of steps the row failed) andpb_row_score_(the row's dimension-weighted pass fraction, 0–1). Bothget_row_flags()andget_sundered_data()gainduplicates=("keep_first","keep_last","flag_all", orNone) andduplicates_order_by=.These let
rows_distinct()steps take part by choosing which copy of a duplicate is kept.rows_distinct()itself, and its reported counts, are unchanged.rows_complete()steps now count when sundering, so rows with missing values go to the"fail"piece; this is a behaviour change. Calling either method before interrogation, or afterinterrogate(collect_tbl_checked=False), raises a clearValueError, andget_sundered_data(type="fail")no longer fails on PySpark when there are no row-level steps.